diff mbox series

[meta-filesystems] overlayfs-tools: Inhibit tests on configure

Message ID 20261021135357.14928-1-marek.vasut@mailbox.org
State Under Review
Headers show
Series [meta-filesystems] overlayfs-tools: Inhibit tests on configure | expand

Commit Message

Marek Vasut Oct. 21, 2026, 1:53 p.m. UTC
In case the overlayfs-tools are built using meson, a test triggers
during meson setup phase during do_configure task. The test invokes
"sudo", which may not be present on the build machine. Skip the test
at meson setup phase. Tests should be executed separately on demand
using "meson test" command instead, and invoking "sudo" and expecting
it to work during do_configure is unusual.

"
ERROR: overlayfs-tools-v2025.01-r0 do_configure: meson setup failed
...
| Run-time dependency musl-fts found: NO (tried pkgconfig)
| Library m found: YES
| Program test_cases/run_tests.py found: YES (/home/oe/build-some-target/tmp/work/arm64-distro-linux/overlayfs-tools/v2025.01/sources/overlayfs-tools-v2025.01/test_cases/run_tests.py)
|
| ../sources/overlayfs-tools-v2025.01/meson.build:94:0: ERROR: Program 'sudo' not found or not executable
|
| A full log can be found at /home/oe/build-some-target/tmp/work/arm64-distro-linux/overlayfs-tools/v2025.01/build/meson-logs/meson-log.txt
|
| Last 10 lines of meson-log.txt:
| Code:
| int main(void) { return 0; }
"

Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
---
Cc: Alexander Kanavin <alex@linutronix.de>
Cc: Ankur Tyagi <ankur.tyagi85@gmail.com>
Cc: Khem Raj <khem.raj@oss.qualcomm.com>
Cc: Vyacheslav Yurkov <uvv.mail@gmail.com>
---
 .../recipes-utils/overlayfs/overlayfs-tools_2025.01.bb        | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Vyacheslav Yurkov Oct. 21, 2026, 3:09 p.m. UTC | #1
Thanks for the patch Marek.

Could you please explain how you hit the issue? I can't reproduce it.
The sudo is required only for tests, which is a custom meson target. 
It's not supposed to be called during configure.

Slava

On 21.10.2026 15:53, Marek Vasut wrote:
> In case the overlayfs-tools are built using meson, a test triggers
> during meson setup phase during do_configure task. The test invokes
> "sudo", which may not be present on the build machine. Skip the test
> at meson setup phase. Tests should be executed separately on demand
> using "meson test" command instead, and invoking "sudo" and expecting
> it to work during do_configure is unusual.
>
> "
> ERROR: overlayfs-tools-v2025.01-r0 do_configure: meson setup failed
> ...
> | Run-time dependency musl-fts found: NO (tried pkgconfig)
> | Library m found: YES
> | Program test_cases/run_tests.py found: YES (/home/oe/build-some-target/tmp/work/arm64-distro-linux/overlayfs-tools/v2025.01/sources/overlayfs-tools-v2025.01/test_cases/run_tests.py)
> |
> | ../sources/overlayfs-tools-v2025.01/meson.build:94:0: ERROR: Program 'sudo' not found or not executable
> |
> | A full log can be found at /home/oe/build-some-target/tmp/work/arm64-distro-linux/overlayfs-tools/v2025.01/build/meson-logs/meson-log.txt
> |
> | Last 10 lines of meson-log.txt:
> | Code:
> | int main(void) { return 0; }
> "
>
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: Alexander Kanavin <alex@linutronix.de>
> Cc: Ankur Tyagi <ankur.tyagi85@gmail.com>
> Cc: Khem Raj <khem.raj@oss.qualcomm.com>
> Cc: Vyacheslav Yurkov <uvv.mail@gmail.com>
> ---
>   .../recipes-utils/overlayfs/overlayfs-tools_2025.01.bb        | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
> index 8583a0e2cb..3b5963bb26 100644
> --- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
> +++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
> @@ -14,3 +14,7 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
>   inherit meson pkgconfig
>   
>   DEPENDS:append:libc-musl = " fts"
> +
> +do_configure:prepend() {
> +	sed -i '/Custom targets for testing overlay function/,/command : .*permanent...changes/ d' ${S}/meson.build
> +}
Marek Vasut Oct. 21, 2026, 4:27 p.m. UTC | #2
On 10/21/26 5:09 PM, Vyacheslav Yurkov wrote:
> Thanks for the patch Marek.
> 
> Could you please explain how you hit the issue? I can't reproduce it.
> The sudo is required only for tests, which is a custom meson target. 
> It's not supposed to be called during configure.
$ bitbake -c configure overlayfs-tools

on aarch64 (STM32MP25) target (not using the ST layers).

I would also expect the tests to NOT run during configure.

It also happens in OE wrynose builds, but not in OE scarthgap builds.
diff mbox series

Patch

diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
index 8583a0e2cb..3b5963bb26 100644
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_2025.01.bb
@@ -14,3 +14,7 @@  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
 inherit meson pkgconfig
 
 DEPENDS:append:libc-musl = " fts"
+
+do_configure:prepend() {
+	sed -i '/Custom targets for testing overlay function/,/command : .*permanent...changes/ d' ${S}/meson.build
+}