diff mbox series

[meta-gnome,1/5] mutter: Fix build without remote desktop support

Message ID 20261020003022.1913623-1-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-gnome,1/5] mutter: Fix build without remote desktop support | expand

Commit Message

Khem Raj Oct. 20, 2026, 12:30 a.m. UTC 
The clipboard session is always built, as input capture uses it, but
the remote selection source it calls into was only built with
-Dremote_desktop=true, so libmutter failed to link with the default
PACKAGECONFIG:

  ld.lld: error: undefined symbol: meta_selection_source_remote_new

Build the remote selection source unconditionally.

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...ection-source-without-remote-desktop.patch | 42 +++++++++++++++++++
 .../recipes-gnome/mutter/mutter_51.0.bb       |  4 +-
 2 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 meta-gnome/recipes-gnome/mutter/files/0002-build-Build-remote-selection-source-without-remote-desktop.patch
diff mbox series

Patch

diff --git a/meta-gnome/recipes-gnome/mutter/files/0002-build-Build-remote-selection-source-without-remote-desktop.patch b/meta-gnome/recipes-gnome/mutter/files/0002-build-Build-remote-selection-source-without-remote-desktop.patch
new file mode 100644
index 0000000000..094270536e
--- /dev/null
+++ b/meta-gnome/recipes-gnome/mutter/files/0002-build-Build-remote-selection-source-without-remote-desktop.patch
@@ -0,0 +1,42 @@ 
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Khem Raj <khem.raj@oss.qualcomm.com>
+Date: Sun, 18 Oct 2026 17:50:00 -0700
+Subject: [PATCH] build: Build remote selection source without remote desktop
+
+meta-clipboard-session.c is built unconditionally, as input capture
+uses it, but it calls into meta-selection-source-remote.c, which is only
+built with remote desktop support. Linking libmutter with
+-Dremote_desktop=false fails:
+
+  ld.lld: error: undefined symbol: meta_selection_source_remote_new
+
+The remote selection source has no remote desktop dependencies, so
+build it unconditionally as well.
+
+Upstream-Status: Pending
+AI-Generated: Uses Claude Code
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ src/meson.build | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/src/meson.build
++++ b/src/meson.build
+@@ -345,6 +345,8 @@
+   'core/meta-selection.c',
+   'core/meta-selection-source.c',
+   'core/meta-selection-source-memory.c',
++  'core/meta-selection-source-remote.c',
++  'core/meta-selection-source-remote.h',
+   'core/meta-session-manager.c',
+   'core/meta-session-state.c',
+   'core/meta-sound-player.c',
+@@ -470,8 +472,6 @@
+     'backends/meta-stream-window.h',
+     'backends/meta-stream.c',
+     'backends/meta-stream.h',
+-    'core/meta-selection-source-remote.c',
+-    'core/meta-selection-source-remote.h',
+   ]
+ endif
+
diff --git a/meta-gnome/recipes-gnome/mutter/mutter_51.0.bb b/meta-gnome/recipes-gnome/mutter/mutter_51.0.bb
index 66a4666c55..4213e2cc06 100644
--- a/meta-gnome/recipes-gnome/mutter/mutter_51.0.bb
+++ b/meta-gnome/recipes-gnome/mutter/mutter_51.0.bb
@@ -35,7 +35,9 @@  DEPENDS = " \

 inherit gnomebase gsettings gobject-introspection gettext features_check

-SRC_URI += "file://0001-Dont-use-system-sysprof-dbus-folder.patch"
+SRC_URI += "file://0001-Dont-use-system-sysprof-dbus-folder.patch \
+            file://0002-build-Build-remote-selection-source-without-remote-desktop.patch \
+            "
 SRC_URI[archive.sha256sum] = "5d28f3ae225692428fcafb96500d673f34328b698b86960c9c1460d0b1d983b3"

 REQUIRED_DISTRO_FEATURES = "wayland polkit"