diff mbox series

[meta-oe,1/2] librelp: Skip tls-ossl-connect-failure-vg.sh when libtool is missing

Message ID 20261001201404.3518829-1-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-oe,1/2] librelp: Skip tls-ossl-connect-failure-vg.sh when libtool is missing | expand

Commit Message

Khem Raj Oct. 1, 2026, 8:14 p.m. UTC 
The test added in 1.13 runs the sender through ${srcdir}/../libtool,
which only exists in the build tree. In ptest the sender cannot start
and the test fails with exit status 127. Skip it like the other valgrind
tests already do when libtool is not available.

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...ssl-connect-failure-vg.sh-without-li.patch | 36 +++++++++++++++++++
 .../recipes-extended/rsyslog/librelp_1.13.bb  |  1 +
 2 files changed, 37 insertions(+)
 create mode 100644 meta-oe/recipes-extended/rsyslog/librelp/0001-tests-skip-tls-ossl-connect-failure-vg.sh-without-li.patch
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/rsyslog/librelp/0001-tests-skip-tls-ossl-connect-failure-vg.sh-without-li.patch b/meta-oe/recipes-extended/rsyslog/librelp/0001-tests-skip-tls-ossl-connect-failure-vg.sh-without-li.patch
new file mode 100644
index 0000000000..903c6a5bcc
--- /dev/null
+++ b/meta-oe/recipes-extended/rsyslog/librelp/0001-tests-skip-tls-ossl-connect-failure-vg.sh-without-li.patch
@@ -0,0 +1,36 @@ 
+From 1bd587299f7578f4e08242eb45282933b8c10b36 Mon Sep 17 00:00:00 2001
+From: Khem Raj <khem.raj@oss.qualcomm.com>
+Date: Thu, 1 Oct 2026 10:31:31 -0700
+Subject: [PATCH] tests: skip tls-ossl-connect-failure-vg.sh without libtool
+
+The test runs the sender through ${srcdir}/../libtool, which only exists
+in a build tree. When the test suite is installed and run elsewhere, as
+with ptest, the sender cannot be started and the test fails with:
+
+  tls-ossl-connect-failure-vg.sh: line 22: .../tests/../libtool: No such file or directory
+  unexpected sender exit status 127 (expected authentication failure)
+
+The other valgrind tests already skip in this case through
+startup_receiver_valgrind(). Skip this one as well.
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ tests/tls-ossl-connect-failure-vg.sh | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/tests/tls-ossl-connect-failure-vg.sh b/tests/tls-ossl-connect-failure-vg.sh
+index d67378d..08bf018 100755
+--- a/tests/tls-ossl-connect-failure-vg.sh
++++ b/tests/tls-ossl-connect-failure-vg.sh
+@@ -9,6 +9,10 @@ if ! ./have_tlslib "openssl"; then
+ 	echo "OpenSSL support is not available"
+ 	exit 77
+ fi
++if [ ! -x "${srcdir}/../libtool" ]; then
++	echo "libtool not available, cannot run under valgrind"
++	exit 77
++fi
+
+ export errorlog="error.$LIBRELP_DYN.log"
+ export TLSLIB="-l openssl"
diff --git a/meta-oe/recipes-extended/rsyslog/librelp_1.13.bb b/meta-oe/recipes-extended/rsyslog/librelp_1.13.bb
index 479905f728..b7d64fcb9d 100644
--- a/meta-oe/recipes-extended/rsyslog/librelp_1.13.bb
+++ b/meta-oe/recipes-extended/rsyslog/librelp_1.13.bb
@@ -8,6 +8,7 @@  DEPENDS = "gmp libidn zlib"

 SRC_URI = "git://github.com/rsyslog/librelp.git;protocol=https;branch=main;tag=v${PV} \
            file://run-ptest \
+           file://0001-tests-skip-tls-ossl-connect-failure-vg.sh-without-li.patch \
 "

 SRCREV = "bedc657e519568b25f611c8efc83eab6ac1068e9"