diff mbox series

[meta-oe,02/26] floret: add missing <cstdint> include for int64_t on musl

Message ID 20260929225723.1046705-2-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-oe,01/26] canvenient: include <sys/time.h> for struct timeval on musl | expand

Commit Message

Khem Raj Sept. 29, 2026, 10:56 p.m. UTC 
args.h uses int64_t without including <cstdint>; glibc headers pull it
in transitively via other includes, musl's don't.

AI-Generated: Uses Claude Code

Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...-missing-cstdint-include-for-int64_t.patch | 32 +++++++++++++++++++
 .../recipes-support/floret/floret_0.10.5.bb   |  4 ++-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta-oe/recipes-support/floret/files/0002-args.h-add-missing-cstdint-include-for-int64_t.patch
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/floret/files/0002-args.h-add-missing-cstdint-include-for-int64_t.patch b/meta-oe/recipes-support/floret/files/0002-args.h-add-missing-cstdint-include-for-int64_t.patch
new file mode 100644
index 0000000000..cfececbad7
--- /dev/null
+++ b/meta-oe/recipes-support/floret/files/0002-args.h-add-missing-cstdint-include-for-int64_t.patch
@@ -0,0 +1,32 @@ 
+From: Khem Raj <khem.raj@oss.qualcomm.com>
+Date: Tue, 29 Sep 2026 01:54:51 +0000
+Subject: [PATCH] args.h: add missing <cstdint> include for int64_t
+
+args.h declares getAutotuneModelSize() returning int64_t but never
+includes <cstdint> itself. On glibc/libstdc++ this compiles because
+some other transitively-included standard header happens to declare
+int64_t first, but that is not guaranteed. musl's libc++/libstdc++
+headers do not provide this transitive declaration, so args.h fails
+to parse with "unknown type name 'int64_t'". The existing
+0001-PATCH-floret patch adds <cstdint> to args.cc, but only after
+it includes "args.h", so it does not help args.h parse itself.
+Include <cstdint> directly in args.h so the header is self-contained.
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ src/args.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/args.h b/src/args.h
+index 1111111..2222222 100644
+--- a/src/args.h
++++ b/src/args.h
+@@ -8,6 +8,7 @@
+
+ #pragma once
+
++#include <cstdint>
+ #include <istream>
+ #include <ostream>
+ #include <string>
diff --git a/meta-oe/recipes-support/floret/floret_0.10.5.bb b/meta-oe/recipes-support/floret/floret_0.10.5.bb
index 52c46b2a4b..fd96ed701c 100644
--- a/meta-oe/recipes-support/floret/floret_0.10.5.bb
+++ b/meta-oe/recipes-support/floret/floret_0.10.5.bb
@@ -16,7 +16,9 @@  LIC_FILES_CHKSUM = "file://LICENSE;md5=4ce16d1d2b4c556959d654417007b713"
 DEPENDS = "zlib"
 
 SRC_URI = "git://github.com/explosion/floret.git;protocol=https;branch=main;tag=v${PV} \
-           file://0001-PATCH-floret-Adjust-CMake-flags-for-cross-compilation.patch"
+           file://0001-PATCH-floret-Adjust-CMake-flags-for-cross-compilation.patch \
+           file://0002-args.h-add-missing-cstdint-include-for-int64_t.patch \
+           "
 
 SRCREV = "775638223bee4fabc420cc8234632557452558e0"