diff mbox series

[meta-oe,8/9] hunspell: add missing gconv ptest RDEPENDS

Message ID 20260821180211.423633-8-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-oe,1/9] xdg-dbus-proxy: use VIRTUAL-RUNTIME_dbus for ptest RDEPENDS | expand

Commit Message

Khem Raj Aug. 21, 2026, 6:02 p.m. UTC 
From: Khem Raj <raj.khem@gmail.com>

All 25 ptest failures are missing glibc character-set converters. With
run-ptest no longer discarding test.sh output, the cause is explicit:

  error - iconv_open: ISO8859-1 -> UTF-8
  error - iconv_open: UTF-8 -> ISO8859-1
  =============================================
  Fail in allcaps3.good. Good words recognised as wrong:

Aggregated over the run: 382 ISO8859-1 and 10 ISO8859-15 iconv_open
failures, and every one of the 25 failing tests reports them.

Only glibc-gconv-iso8859-2 was pulled in, but the test corpus needs more
than that. Dictionaries with no SET line in their .aff fall back to
ISO8859-1 in both consumers of the default:

  csutil.hxx:99      #define SPELL_ENCODING "ISO8859-1"
  affixmgr.cxx:3502  if (encoding.empty()) encoding = SPELL_ENCODING;
  hashmgr.cxx:97     if (!csconv) csconv = get_current_cs(SPELL_ENCODING);

and 92 of the 144 installed .aff files have no SET, which is why tests
with pure-ASCII data and no SET line still needed a converter. The
encodings actually referenced across the corpus are ISO8859-1,
ISO8859-15, ISO-8859-15, ISO8859-2 and UTF-8; UTF-8 is built into glibc,
so add the two missing ISO8859 modules.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/hunspell/hunspell_1.7.3.bb | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/hunspell/hunspell_1.7.3.bb b/meta-oe/recipes-support/hunspell/hunspell_1.7.3.bb
index 23f6ac87d8..7d0921c25f 100644
--- a/meta-oe/recipes-support/hunspell/hunspell_1.7.3.bb
+++ b/meta-oe/recipes-support/hunspell/hunspell_1.7.3.bb
@@ -34,6 +34,11 @@  do_install_ptest() {
     sed -i 's|alias analyze=.*ANALYZE.*|alias analyze="$ANALYZE"|' ${D}${PTEST_PATH}/tests/test.sh
 }
 
-RDEPENDS:${PN}-ptest += "bash glibc-gconv-iso8859-2"
+RDEPENDS:${PN}-ptest += " \
+    bash \
+    glibc-gconv-iso8859-1 \
+    glibc-gconv-iso8859-2 \
+    glibc-gconv-iso8859-15 \
+"
 
 BBCLASSEXTEND = "native"