diff mbox series

[meta-oe,2/3] crash: drop unnecessary git scaffolding from do_compile

Message ID 20260625180841.2638737-2-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-oe,1/3] crash 8.0.6 -> 9.0.2 + crash-memory-driver | expand

Commit Message

Khem Raj June 25, 2026, 6:08 p.m. UTC
The do_compile:prepend ran "git init && git add . && git commit" inside the
staged gdb-16.2 tree. crash's build does not use git at all - the bundled gdb
is unpacked from a release tarball and merged with plain "patch -p0" - so this
served no purpose and only made the build depend on a working git identity.

In any environment where committer identity is unset, or where commit signing
is enabled globally (commit.gpgsign=true), do_compile fails with:

    error: gpg failed to sign the data
    fatal: failed to write commit object

Drop the git scaffolding entirely; the gdb patch still applies with patch(1).

Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 meta-oe/recipes-kernel/crash/crash.inc | 11 -----------
 1 file changed, 11 deletions(-)
diff mbox series

Patch

diff --git a/meta-oe/recipes-kernel/crash/crash.inc b/meta-oe/recipes-kernel/crash/crash.inc
index 4e889f7677..e7b3b9cf13 100644
--- a/meta-oe/recipes-kernel/crash/crash.inc
+++ b/meta-oe/recipes-kernel/crash/crash.inc
@@ -90,13 +90,6 @@  do_compile:prepend() {
     # 2. Copy the official clean GNU tarball source footprint into the active workspace mapping
     cp -rf ${UNPACKDIR}/gdb/gdb-16.2 ${B}/gdb-16.2

-    # 3. Initialize the localized tracking repository required by the crash build architecture
-    cd ${B}/gdb-16.2/
-    git init
-    git add .
-    git commit -m "initial commit"
-    cd ${B}
-
     bbnote "Writing dynamic target layout architecture context: ${ARCH_UPPER}"
     echo "${ARCH_UPPER}" > ${B}/gdb-16.2/crash.target

@@ -110,10 +103,6 @@  do_compile:prepend() {
     cd ${B}
     bbnote "Applying the native upstream crash integration patch onto the GDB source tree..."
     patch -p0 --fuzz=3 < gdb-16.2.patch
-    cd ${B}/gdb-16.2/
-    git add .
-    git commit -m "after upstream crash gdb-16.2.patch"
-    cd ${B}
 }

 do_compile() {