| Message ID | 20260506-bash-rr-v1-1-507ee57b7fe7@non.se.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-networking] openvpn: change bash rdepends to rrecommends | expand |
On 5/6/26 18:07, Louis Rannou via lists.openembedded.org wrote: > From: Louis Rannou <louis.rannou@non.se.com> > > The dependency to bash is only required for dns-updown scripts. As bash is > under the GPLv3 license, it might be preferred to exclude it. > > Signed-off-by: Louis Rannou <louis.rannou@non.se.com> > --- > meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > index 0cbe4641cd..d967a0dc12 100644 > --- a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > +++ b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > @@ -47,7 +47,7 @@ PACKAGECONFIG[iproute2] = "--enable-iproute2,,iproute2,iproute2-ip" > PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd" > PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux" > > -RDEPENDS:${PN}:append = " bash" > +RRECOMMENDS:${PN}:append = " bash" In case bash is excluded (with PACKAGE_EXCLUDE, INCOMPATIBLE_LICENSE, BAD_RECOMMENDATIONS...) I would expect this change to throw an error still, the latest during package QA, when it scans the scripts for missing dependencies - because the dependency itself is still present. Does it not fail those checks? As an alternative, I wonder if it would make sense to install this dns-updown script to a separate package, and make that depend on bash only. > RDEPENDS:${PN}-ptest:append = " bash" > > do_install:append() { > > --- > base-commit: 420222862f5a6d95023b8f5f3b7e1808b2264ef9 > change-id: 20260506-bash-rr-5fd0820519e4 > > Best regards, > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#126806): https://lists.openembedded.org/g/openembedded-devel/message/126806 > Mute This Topic: https://lists.openembedded.org/mt/119181734/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Gyorgy Sarvari via lists.openembedded.org <skandigraun= gmail.com@lists.openembedded.org> escreveu (quinta, 7/05/2026 à(s) 08:39): > > On 5/6/26 18:07, Louis Rannou via lists.openembedded.org wrote: > > From: Louis Rannou <louis.rannou@non.se.com> > > > > The dependency to bash is only required for dns-updown scripts. As bash > is > > under the GPLv3 license, it might be preferred to exclude it. > > > > Signed-off-by: Louis Rannou <louis.rannou@non.se.com> > > --- > > meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > > index 0cbe4641cd..d967a0dc12 100644 > > --- a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > > +++ b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > > @@ -47,7 +47,7 @@ PACKAGECONFIG[iproute2] = > "--enable-iproute2,,iproute2,iproute2-ip" > > PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd" > > PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux" > > > > -RDEPENDS:${PN}:append = " bash" > > +RRECOMMENDS:${PN}:append = " bash" > > > In case bash is excluded (with PACKAGE_EXCLUDE, INCOMPATIBLE_LICENSE, > BAD_RECOMMENDATIONS...) I would expect this change to throw an error > still, the latest during package QA, when it scans the scripts for > missing dependencies - because the dependency itself is still present. > Does it not fail those checks? > > As an alternative, I wonder if it would make sense to install this > dns-updown script to a separate package, and make that depend on bash only. > A new package would be more appropriate. On the other hand, is bash really necessary? Sometimes it's just shaband that's wrong on script and POSIx /bin/sh can even be used. Could you try this? Jose > > > > > RDEPENDS:${PN}-ptest:append = " bash" > > > > do_install:append() { > > > > --- > > base-commit: 420222862f5a6d95023b8f5f3b7e1808b2264ef9 > > change-id: 20260506-bash-rr-5fd0820519e4 > > > > Best regards, > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#126810): > https://lists.openembedded.org/g/openembedded-devel/message/126810 > Mute This Topic: https://lists.openembedded.org/mt/119181734/5052612 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > quaresma.jose@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On 5/7/26 10:46, Jose Quaresma wrote: > > > Gyorgy Sarvari via lists.openembedded.org > <http://lists.openembedded.org> > <skandigraun=gmail.com@lists.openembedded.org> escreveu (quinta, > 7/05/2026 à(s) 08:39): > > > On 5/6/26 18:07, Louis Rannou via lists.openembedded.org > <http://lists.openembedded.org> wrote: > > From: Louis Rannou <louis.rannou@non.se.com> > > > > The dependency to bash is only required for dns-updown scripts. > As bash is > > under the GPLv3 license, it might be preferred to exclude it. > > > > Signed-off-by: Louis Rannou <louis.rannou@non.se.com> > > --- > > meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > <http://openvpn_2.7.0.bb> | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > <http://openvpn_2.7.0.bb> > b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > <http://openvpn_2.7.0.bb> > > index 0cbe4641cd..d967a0dc12 100644 > > --- a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > <http://openvpn_2.7.0.bb> > > +++ b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb > <http://openvpn_2.7.0.bb> > > @@ -47,7 +47,7 @@ PACKAGECONFIG[iproute2] = > "--enable-iproute2,,iproute2,iproute2-ip" > > PACKAGECONFIG[systemd] = > "--enable-systemd,--disable-systemd,systemd" > > PACKAGECONFIG[selinux] = > "--enable-selinux,--disable-selinux,libselinux" > > > > -RDEPENDS:${PN}:append = " bash" > > +RRECOMMENDS:${PN}:append = " bash" > > > In case bash is excluded (with PACKAGE_EXCLUDE, INCOMPATIBLE_LICENSE, > BAD_RECOMMENDATIONS...) I would expect this change to throw an error > still, the latest during package QA, when it scans the scripts for > missing dependencies - because the dependency itself is still present. > Does it not fail those checks? > That is correct. The check fails, I ignore how I missed that. > > As an alternative, I wonder if it would make sense to install this > dns-updown script to a separate package, and make that depend on > bash only. > > > A new package would be more appropriate. > On the other hand, is bash really necessary? Sometimes it's just > shaband that's wrong on script > and POSIx /bin/sh can even be used. Could you try this? That was also my first thought. The scripts are not POSIX compliant unfortunately. It's quite sad as all older scripts used to be. I'll send a v2 with a package openvpn-dns-updown. Do you think I should add a rdepends between openvpn and this ? My first guess would be to not take the dependency as the dns-updown scripts are recent. Louis
Hi Louis, Louis Rannou <louis.rannou@semalibre.com> escreveu (quinta, 7/05/2026 à(s) 15:50): > > > On 5/7/26 10:46, Jose Quaresma wrote: > > > > Gyorgy Sarvari via lists.openembedded.org <skandigraun= > gmail.com@lists.openembedded.org> escreveu (quinta, 7/05/2026 à(s) 08:39): > >> >> On 5/6/26 18:07, Louis Rannou via lists.openembedded.org wrote: >> > From: Louis Rannou <louis.rannou@non.se.com> >> > >> > The dependency to bash is only required for dns-updown scripts. As bash >> is >> > under the GPLv3 license, it might be preferred to exclude it. >> > >> > Signed-off-by: Louis Rannou <louis.rannou@non.se.com> >> > --- >> > meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb >> b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb >> > index 0cbe4641cd..d967a0dc12 100644 >> > --- a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb >> > +++ b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb >> > @@ -47,7 +47,7 @@ PACKAGECONFIG[iproute2] = >> "--enable-iproute2,,iproute2,iproute2-ip" >> > PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd" >> > PACKAGECONFIG[selinux] = >> "--enable-selinux,--disable-selinux,libselinux" >> > >> > -RDEPENDS:${PN}:append = " bash" >> > +RRECOMMENDS:${PN}:append = " bash" >> >> >> In case bash is excluded (with PACKAGE_EXCLUDE, INCOMPATIBLE_LICENSE, >> BAD_RECOMMENDATIONS...) I would expect this change to throw an error >> still, the latest during package QA, when it scans the scripts for >> missing dependencies - because the dependency itself is still present. >> Does it not fail those checks? >> > That is correct. The check fails, I ignore how I missed that. > > >> As an alternative, I wonder if it would make sense to install this >> dns-updown script to a separate package, and make that depend on bash >> only. >> > > A new package would be more appropriate. > On the other hand, is bash really necessary? Sometimes it's just shaband > that's wrong on script > and POSIx /bin/sh can even be used. Could you try this? > > That was also my first thought. The scripts are not POSIX compliant > unfortunately. It's quite sad as all older scripts used to be. > > I'll send a v2 with a package openvpn-dns-updown. Do you think I should > add a rdepends between openvpn and this ? My first guess would be to not > take the dependency as the dns-updown scripts are recent. > I think we can ignore it for now, and in the meantime, who knows, maybe someone will port the script to posix and the package won't be necessary in future versions. Jose > > Louis >
diff --git a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb index 0cbe4641cd..d967a0dc12 100644 --- a/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb +++ b/meta-networking/recipes-support/openvpn/openvpn_2.7.0.bb @@ -47,7 +47,7 @@ PACKAGECONFIG[iproute2] = "--enable-iproute2,,iproute2,iproute2-ip" PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd" PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux" -RDEPENDS:${PN}:append = " bash" +RRECOMMENDS:${PN}:append = " bash" RDEPENDS:${PN}-ptest:append = " bash" do_install:append() {