diff mbox series

[meta-networking] networkd-dispatcher: Refactor recipe

Message ID 20260319170223.1353-1-mark.jonas@de.bosch.com
State Under Review
Headers show
Series [meta-networking] networkd-dispatcher: Refactor recipe | expand

Commit Message

Jonas Mark (BT-FS/ENG1-Mue) March 19, 2026, 5:02 p.m. UTC 
From: Ricardo Simoes <ricardo.simoes@pt.bosch.com>

This commit fixes the below issues with the networkd-dispatcher recipe:
- Add the missing required variables defined in [1]:
  - HOMEPAGE
  - BUGTRACKER
- Add the SECTION variable allowing improved package management [2]
- Drop SYSTEMD_PACKAGES PN as this is already handled by systemd
  bbclass [3]
- Inherit allarch as the recipe does not create any architecture
  dependent files
- Change the recipe ordering so that [4] is respected
- Add tag parameter for the git fetch, as recommended by [5]

[1] https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#required-variables
[2] https://docs.yoctoproject.org/dev/ref-manual/variables.html#term-SECTION
[3] https://docs.yoctoproject.org/dev/ref-manual/variables.html#term-SYSTEMD_PACKAGES
[4] https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#variable-ordering
[5] https://docs.yoctoproject.org/dev/migration-guides/migration-5.3.html#bitbake-git-fetcher-tag-parameter

Signed-off-by: Ricardo Simoes <ricardo.simoes@pt.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
---
 .../networkd-dispatcher/networkd-dispatcher_2.2.4.bb | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/meta-networking/recipes-daemons/networkd-dispatcher/networkd-dispatcher_2.2.4.bb b/meta-networking/recipes-daemons/networkd-dispatcher/networkd-dispatcher_2.2.4.bb
index e7db8a948b..aa7c9b8736 100644
--- a/meta-networking/recipes-daemons/networkd-dispatcher/networkd-dispatcher_2.2.4.bb
+++ b/meta-networking/recipes-daemons/networkd-dispatcher/networkd-dispatcher_2.2.4.bb
@@ -2,20 +2,20 @@  SUMMARY = "Dispatcher service for systemd-networkd connection status changes"
 DESCRIPTION = "This daemon is similar to NetworkManager-dispatcher, but is much \
 more limited in the types of events it supports due to the limited nature of \
 systemd-networkd(8)."
+HOMEPAGE = "https://gitlab.com/craftyguy/networkd-dispatcher"
+BUGTRACKER = "https://gitlab.com/craftyguy/networkd-dispatcher/-/issues"
+SECTION = "network"
 
 LICENSE = "GPL-3.0-only"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=84dcc94da3adb52b53ae4fa38fe49e5d"
 
-inherit features_check systemd
+inherit allarch features_check systemd
 
-RDEPENDS:${PN} = "python3-pygobject python3-dbus python3-json"
 REQUIRED_DISTRO_FEATURES = "systemd gobject-introspection-data"
 
+SRC_URI = "git://gitlab.com/craftyguy/networkd-dispatcher;protocol=https;nobranch=1;tag=${PV}"
 SRCREV = "dfd26d72793914eb3da910ef8c71de6d7c8942a2"
-SRC_URI = "git://gitlab.com/craftyguy/networkd-dispatcher;protocol=https;nobranch=1"
 
-
-SYSTEMD_PACKAGES = "${PN}"
 SYSTEMD_SERVICE:${PN} = "networkd-dispatcher.service"
 SYSTEMD_AUTO_ENABLE = "disable"
 
@@ -28,3 +28,5 @@  do_install() {
     install -D -m 0644 ${S}/networkd-dispatcher.service ${D}/${systemd_system_unitdir}/networkd-dispatcher.service
     install -D -m 0644 ${S}/networkd-dispatcher.conf ${D}/${sysconfdir}/conf.d/networkd-dispatcher.conf
 }
+
+RDEPENDS:${PN} = "python3-dbus python3-json python3-pygobject"