diff mbox series

[meta-networking] openl2tp: Fix do_package_qa Issue

Message ID 20260126071627.4466-1-liuyd.fnst@fujitsu.com
State New
Headers show
Series [meta-networking] openl2tp: Fix do_package_qa Issue | expand

Commit Message

Liu Yiding Jan. 26, 2026, 7:16 a.m. UTC
Fix following issue when using customized kernel without kernel-module-l2tp-ppp enabled.
ERROR: openl2tp-1.8-r0 do_package_qa: QA Issue: openl2tp-ptest rdepends on kernel-module-l2tp-ppp, but it isn't a build dependency? [build-deps]

Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
 meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Gyorgy Sarvari Jan. 26, 2026, 7:12 p.m. UTC | #1
On 1/26/26 08:16, Yiding Liu (Fujitsu) via lists.openembedded.org wrote:
> Fix following issue when using customized kernel without kernel-module-l2tp-ppp enabled.
> ERROR: openl2tp-1.8-r0 do_package_qa: QA Issue: openl2tp-ptest rdepends on kernel-module-l2tp-ppp, but it isn't a build dependency? [build-deps]

But does it make sense to build ptests for this recipe with such a
kernel? I'd expect that it fails the latest at runtime due to the
missing module (but most likely during buildtime, due to missing RDEPENDS)
Instead of disabling this check (which seems to work as expected),
wouldn't it be better to disable ptest completely in user layer
(bbappend, local.conf...)?

Or maybe the module could be moved to RRECOMMENDS, so it won't be a hard
dependency. Ptests would still fail at runtime (with incompatible kernel
config), but the build and qa checks could go on.

> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
>  meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> index 4e5b45891d..ac9dece2f9 100644
> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> @@ -97,3 +97,5 @@ do_install_ptest () {
>  
>  RDEPENDS:${PN} = "ppp ppp-l2tp bash"
>  RDEPENDS:${PN}-ptest += "rpcbind kernel-module-l2tp-ppp procps-ps tcl"
> +
> +INSANE_SKIP:${PN}-ptest += "build-deps"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#123859): https://lists.openembedded.org/g/openembedded-devel/message/123859
> Mute This Topic: https://lists.openembedded.org/mt/117464733/6084445
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj Jan. 26, 2026, 11:55 p.m. UTC | #2
On Sun, Jan 25, 2026 at 11:16 PM Yiding Liu (Fujitsu) via
lists.openembedded.org <liuyd.fnst=fujitsu.com@lists.openembedded.org>
wrote:

> Fix following issue when using customized kernel without
> kernel-module-l2tp-ppp enabled.
> ERROR: openl2tp-1.8-r0 do_package_qa: QA Issue: openl2tp-ptest rdepends on
> kernel-module-l2tp-ppp, but it isn't a build dependency? [build-deps]
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
>  meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> index 4e5b45891d..ac9dece2f9 100644
> --- a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> +++ b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
> @@ -97,3 +97,5 @@ do_install_ptest () {
>
>  RDEPENDS:${PN} = "ppp ppp-l2tp bash"
>  RDEPENDS:${PN}-ptest += "rpcbind kernel-module-l2tp-ppp procps-ps tcl"
>

Try changing above line to use
RRECOMMENDS:${PN}-ptest instead of rdep


> +
> +INSANE_SKIP:${PN}-ptest += "build-deps"
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#123859):
> https://lists.openembedded.org/g/openembedded-devel/message/123859
> Mute This Topic: https://lists.openembedded.org/mt/117464733/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
index 4e5b45891d..ac9dece2f9 100644
--- a/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
+++ b/meta-networking/recipes-protocols/openl2tp/openl2tp_1.8.bb
@@ -97,3 +97,5 @@  do_install_ptest () {
 
 RDEPENDS:${PN} = "ppp ppp-l2tp bash"
 RDEPENDS:${PN}-ptest += "rpcbind kernel-module-l2tp-ppp procps-ps tcl"
+
+INSANE_SKIP:${PN}-ptest += "build-deps"