diff mbox series

[meta-oe] hdf5: add pkgconfig-native as DEPENDS explicitly

Message ID 20251201062620.2517114-1-changqing.li@windriver.com
State Under Review
Headers show
Series [meta-oe] hdf5: add pkgconfig-native as DEPENDS explicitly | expand

Commit Message

Changqing Li Dec. 1, 2025, 6:26 a.m. UTC 
From: Changqing Li <changqing.li@windriver.com>

Add pkgconfig-native as DEPENDS explicitly, this can avoid install
conflict when enable multilib when pkgconfig is installed on host,
and also improve build reproducibility

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-oe/recipes-support/hdf5/hdf5_2.0.0.bb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Ross Burton Dec. 1, 2025, 9:53 a.m. UTC | #1 
On 1 Dec 2025, at 06:26, Changqing Li via lists.openembedded.org <changqing.li=windriver.com@lists.openembedded.org> wrote:
> 
> From: Changqing Li <changqing.li@windriver.com>
> 
> Add pkgconfig-native as DEPENDS explicitly, this can avoid install
> conflict when enable multilib when pkgconfig is installed on host,
> and also improve build reproducibility

Convention is to inherit pkgconfig.

Ross
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/hdf5/hdf5_2.0.0.bb b/meta-oe/recipes-support/hdf5/hdf5_2.0.0.bb
index 798ca1b83f..9f77028ce1 100644
--- a/meta-oe/recipes-support/hdf5/hdf5_2.0.0.bb
+++ b/meta-oe/recipes-support/hdf5/hdf5_2.0.0.bb
@@ -7,9 +7,9 @@  SECTION = "libs"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=71a191398102f76050a4e56e78cb4891"
 
-inherit cmake siteinfo qemu multilib_header
+inherit cmake siteinfo qemu multilib_header multilib_script
 
-DEPENDS += "qemu-native zlib"
+DEPENDS += "qemu-native zlib pkgconfig-native"
 
 SRC_URI = "https://support.hdfgroup.org/releases/hdf5/v2_0/v2_0_0/downloads/${BPN}-${PV}.tar.gz \
            file://0002-Remove-suffix-shared-from-shared-library-name.patch \
@@ -48,8 +48,11 @@  do_configure:append() {
 do_install:append() {
     # Used for generating config files on target
     oe_multilib_header H5pubconf.h
+    sed -i -e 's|${RECIPE_SYSROOT_NATIVE}||g' ${D}${bindir}/h5cc
 }
 
+MULTILIB_SCRIPTS += "${PN}:${bindir}/h5cc"
+
 BBCLASSEXTEND = "native"
 
 # h5fuse.sh script needs bash