diff mbox series

[meta-oe] valkey: Upgrade 8.1.4 -> 9.0.0

Message ID 20251124092909.3234487-1-leon.anavi@konsulko.com
State Under Review
Headers show
Series [meta-oe] valkey: Upgrade 8.1.4 -> 9.0.0 | expand

Commit Message

Leon Anavi Nov. 24, 2025, 9:29 a.m. UTC
Upgrade to release 9.0.0:

- HSETEX with FXX should not create an object if it does not exist
- Fix crash when aborting a slot migration while child snapshot is
  active
- Fix double MOVED reply on unblock at failover
- Fix memory leak with CLIENT LIST/KILL duplicate filters
- Fix incorrect accounting after completed atomic slot migration
- Fix Lua VM crash after FUNCTION FLUSH ASYNC + FUNCTION LOAD
- Fix invalid memory address caused by hashtable shrinking during
  safe iteration

Replace dependency hiredis with libvalkey.

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
---
 .../hiredis-use-default-CC-if-it-is-set.patch | 43 -------------------
 .../{valkey_8.1.4.bb => valkey_9.0.0.bb}      |  7 ++-
 2 files changed, 3 insertions(+), 47 deletions(-)
 delete mode 100644 meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch
 rename meta-oe/recipes-extended/valkey/{valkey_8.1.4.bb => valkey_9.0.0.bb} (91%)

Comments

Khem Raj Nov. 25, 2025, 5:59 a.m. UTC | #1
Fails on qemuarm - https://errors.yoctoproject.org/Errors/Details/889836/

On Mon, Nov 24, 2025 at 1:29 AM Leon Anavi via lists.openembedded.org
<leon.anavi=konsulko.com@lists.openembedded.org> wrote:

> Upgrade to release 9.0.0:
>
> - HSETEX with FXX should not create an object if it does not exist
> - Fix crash when aborting a slot migration while child snapshot is
>   active
> - Fix double MOVED reply on unblock at failover
> - Fix memory leak with CLIENT LIST/KILL duplicate filters
> - Fix incorrect accounting after completed atomic slot migration
> - Fix Lua VM crash after FUNCTION FLUSH ASYNC + FUNCTION LOAD
> - Fix invalid memory address caused by hashtable shrinking during
>   safe iteration
>
> Replace dependency hiredis with libvalkey.
>
> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> ---
>  .../hiredis-use-default-CC-if-it-is-set.patch | 43 -------------------
>  .../{valkey_8.1.4.bb => valkey_9.0.0.bb}      |  7 ++-
>  2 files changed, 3 insertions(+), 47 deletions(-)
>  delete mode 100644
> meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch
>  rename meta-oe/recipes-extended/valkey/{valkey_8.1.4.bb =>
> valkey_9.0.0.bb} (91%)
>
> diff --git
> a/meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch
> b/meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch
> deleted file mode 100644
> index ffb365f371..0000000000
> ---
> a/meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch
> +++ /dev/null
> @@ -1,43 +0,0 @@
> -From a5bcf56630df520040076dd14c3c54fef0785ceb Mon Sep 17 00:00:00 2001
> -From: Venture Research <tech@ventureresearch.com>
> -Date: Fri, 8 Feb 2013 17:39:52 -0600
> -Subject: [PATCH] hiredis: use default CC if it is set
> -MIME-Version: 1.0
> -Content-Type: text/plain; charset=UTF-8
> -Content-Transfer-Encoding: 8bit
> -
> -Instead of trying to automagically figure out CC, which breaks with OE
> -as CC has spaces in it, just skip it if one was already passed in.
> -
> -Signed-off-by: Venture Research <tech@ventureresearch.com>
> -
> -Update to work with 4.0.8
> -Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> -
> -Reworked for 6.0.4
> -Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> -
> -Reworked for 8.0.0
> -Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> -
> -Reworked for 8.1.0
> -Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> -
> -Upstream-Status: Inappropriate [OE-specifc]
> ----
> - deps/hiredis/Makefile | 2 --
> - 1 file changed, 2 deletions(-)
> -
> -diff --git a/deps/hiredis/Makefile b/deps/hiredis/Makefile
> -index 4a3de1f6e..49bb525cd 100644
> ---- a/deps/hiredis/Makefile
> -+++ b/deps/hiredis/Makefile
> -@@ -36,8 +36,6 @@ endef
> - export REDIS_TEST_CONFIG
> -
> - # Fallback to gcc when $CC is not in $PATH.
> --CC:=$(shell sh -c 'type $${CC%% *} >/dev/null 2>/dev/null && echo $(CC)
> || echo gcc')
> --CXX:=$(shell sh -c 'type $${CXX%% *} >/dev/null 2>/dev/null && echo
> $(CXX) || echo g++')
> - OPTIMIZATION?=-O3
> - WARNINGS=-Wall -Wextra -Werror -Wstrict-prototypes -Wwrite-strings
> -Wno-missing-field-initializers
> - DEBUG_FLAGS?= -g -ggdb
> diff --git a/meta-oe/recipes-extended/valkey/valkey_8.1.4.bb
> b/meta-oe/recipes-extended/valkey/valkey_9.0.0.bb
> similarity index 91%
> rename from meta-oe/recipes-extended/valkey/valkey_8.1.4.bb
> rename to meta-oe/recipes-extended/valkey/valkey_9.0.0.bb
> index 9947a9299c..82b08d7a82 100644
> --- a/meta-oe/recipes-extended/valkey/valkey_8.1.4.bb
> +++ b/meta-oe/recipes-extended/valkey/valkey_9.0.0.bb
> @@ -7,17 +7,16 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=08b9159809d809e8aaa340a8387e693e"
>  DEPENDS = "readline lua ncurses"
>
>  SRC_URI = " \
> -       git://github.com/valkey-io/valkey.git;branch=8.1;protocol=https \
> +       git://github.com/valkey-io/valkey.git;branch=9.0;protocol=https \
>          file://valkey.conf \
>         file://init-valkey-server \
>         file://valkey.service \
> -       file://hiredis-use-default-CC-if-it-is-set.patch \
>         file://lua-update-Makefile-to-use-environment-build-setting.patch \
>         file://oe-use-libc-malloc.patch \
>         file://0001-src-Do-not-reset-FINAL_LIBS.patch \
>         file://GNU_SOURCE-7.patch \
>  "
> -SRCREV = "5f4bae3ea10174a7c872cc099c953b0e91afa93a"
> +SRCREV = "5018b12b0de2d2322a1bbf6b041c43740587c0f2"
>
>  RPROVIDES:${PN} = "virtual-redis"
>
> @@ -41,7 +40,7 @@ PACKAGECONFIG[systemd] =
> "USE_SYSTEMD=yes,USE_SYSTEMD=no,systemd"
>  EXTRA_OEMAKE += "${PACKAGECONFIG_CONFARGS}"
>
>  do_compile() {
> -    oe_runmake -C deps hiredis lua linenoise
> +    oe_runmake -C deps libvalkey lua linenoise
>      oe_runmake
>  }
>
> --
> 2.47.3
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#122005):
> https://lists.openembedded.org/g/openembedded-devel/message/122005
> Mute This Topic: https://lists.openembedded.org/mt/116448996/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch b/meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch
deleted file mode 100644
index ffb365f371..0000000000
--- a/meta-oe/recipes-extended/valkey/valkey/hiredis-use-default-CC-if-it-is-set.patch
+++ /dev/null
@@ -1,43 +0,0 @@ 
-From a5bcf56630df520040076dd14c3c54fef0785ceb Mon Sep 17 00:00:00 2001
-From: Venture Research <tech@ventureresearch.com>
-Date: Fri, 8 Feb 2013 17:39:52 -0600
-Subject: [PATCH] hiredis: use default CC if it is set
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Instead of trying to automagically figure out CC, which breaks with OE
-as CC has spaces in it, just skip it if one was already passed in.
-
-Signed-off-by: Venture Research <tech@ventureresearch.com>
-
-Update to work with 4.0.8
-Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
-
-Reworked for 6.0.4
-Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
-
-Reworked for 8.0.0
-Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
-
-Reworked for 8.1.0
-Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
-
-Upstream-Status: Inappropriate [OE-specifc]
----
- deps/hiredis/Makefile | 2 --
- 1 file changed, 2 deletions(-)
-
-diff --git a/deps/hiredis/Makefile b/deps/hiredis/Makefile
-index 4a3de1f6e..49bb525cd 100644
---- a/deps/hiredis/Makefile
-+++ b/deps/hiredis/Makefile
-@@ -36,8 +36,6 @@ endef
- export REDIS_TEST_CONFIG
- 
- # Fallback to gcc when $CC is not in $PATH.
--CC:=$(shell sh -c 'type $${CC%% *} >/dev/null 2>/dev/null && echo $(CC) || echo gcc')
--CXX:=$(shell sh -c 'type $${CXX%% *} >/dev/null 2>/dev/null && echo $(CXX) || echo g++')
- OPTIMIZATION?=-O3
- WARNINGS=-Wall -Wextra -Werror -Wstrict-prototypes -Wwrite-strings -Wno-missing-field-initializers
- DEBUG_FLAGS?= -g -ggdb
diff --git a/meta-oe/recipes-extended/valkey/valkey_8.1.4.bb b/meta-oe/recipes-extended/valkey/valkey_9.0.0.bb
similarity index 91%
rename from meta-oe/recipes-extended/valkey/valkey_8.1.4.bb
rename to meta-oe/recipes-extended/valkey/valkey_9.0.0.bb
index 9947a9299c..82b08d7a82 100644
--- a/meta-oe/recipes-extended/valkey/valkey_8.1.4.bb
+++ b/meta-oe/recipes-extended/valkey/valkey_9.0.0.bb
@@ -7,17 +7,16 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=08b9159809d809e8aaa340a8387e693e"
 DEPENDS = "readline lua ncurses"
 
 SRC_URI = " \
-	git://github.com/valkey-io/valkey.git;branch=8.1;protocol=https \
+	git://github.com/valkey-io/valkey.git;branch=9.0;protocol=https \
         file://valkey.conf \
 	file://init-valkey-server \
 	file://valkey.service \
-	file://hiredis-use-default-CC-if-it-is-set.patch \
 	file://lua-update-Makefile-to-use-environment-build-setting.patch \
 	file://oe-use-libc-malloc.patch \
 	file://0001-src-Do-not-reset-FINAL_LIBS.patch \
 	file://GNU_SOURCE-7.patch \
 "
-SRCREV = "5f4bae3ea10174a7c872cc099c953b0e91afa93a"
+SRCREV = "5018b12b0de2d2322a1bbf6b041c43740587c0f2"
 
 RPROVIDES:${PN} = "virtual-redis"
 
@@ -41,7 +40,7 @@  PACKAGECONFIG[systemd] = "USE_SYSTEMD=yes,USE_SYSTEMD=no,systemd"
 EXTRA_OEMAKE += "${PACKAGECONFIG_CONFARGS}"
 
 do_compile() {
-    oe_runmake -C deps hiredis lua linenoise
+    oe_runmake -C deps libvalkey lua linenoise
     oe_runmake
 }