diff mbox series

[meta-oe] libplist: fix ptest error

Message ID 20251120054646.3709798-1-ankur.tyagi85@gmail.com
State Accepted
Headers show
Series [meta-oe] libplist: fix ptest error | expand

Commit Message

Ankur Tyagi Nov. 20, 2025, 5:46 a.m. UTC 
From: Ankur Tyagi <ankur.tyagi85@gmail.com>

Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
---
 .../0001-test-fix-operator-error.patch        | 68 +++++++++++++++++++
 .../libimobiledevice/libplist_2.6.0.bb        |  1 +
 2 files changed, 69 insertions(+)
 create mode 100644 meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch

Comments

Khem Raj Nov. 20, 2025, 8:38 a.m. UTC | #1 
We still have build QA errors to address

WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File
/usr/lib/libplist/ptest/test/tools/plistutil in package libplist-ptest
contains reference to TMPDIR [buildpaths]
WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File
/usr/lib/libplist/ptest/test/test/plist_test++ in package libplist-ptest
contains reference to TMPDIR [buildpaths]
WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File
/usr/lib/libplist/ptest/test/test/plist_jtest in package libplist-ptest
contains reference to TMPDIR [buildpaths]
WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File
/usr/lib/libplist/ptest/test/test/plist_btest in package libplist-ptest
contains reference to TMPDIR [buildpaths]
WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File
/usr/lib/libplist/ptest/test/test/plist_otest in package libplist-ptest
contains reference to TMPDIR [buildpaths]

On Wed, Nov 19, 2025 at 9:46 PM Ankur Tyagi via lists.openembedded.org
<ankur.tyagi85=gmail.com@lists.openembedded.org> wrote:

> From: Ankur Tyagi <ankur.tyagi85@gmail.com>
>
> Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> ---
>  .../0001-test-fix-operator-error.patch        | 68 +++++++++++++++++++
>  .../libimobiledevice/libplist_2.6.0.bb        |  1 +
>  2 files changed, 69 insertions(+)
>  create mode 100644
> meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
>
> diff --git
> a/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
> b/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
> new file mode 100644
> index 0000000000..0866851537
> --- /dev/null
> +++
> b/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
> @@ -0,0 +1,68 @@
> +From 18e5b22a71f85091127cc063db79c8df687c582c Mon Sep 17 00:00:00 2001
> +From: Ankur Tyagi <ankur.tyagi85@gmail.com>
> +Date: Thu, 20 Nov 2025 16:01:58 +1300
> +Subject: [PATCH] test: fix operator error
> +
> +Otherwise test fail with error [: -neq: binary operator expected
> +
> +Upstream-Status: Submitted [
> https://github.com/libimobiledevice/libplist/pull/284]
> +Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> +---
> + test/json-invalid-types.test  | 6 +++---
> + test/ostep-invalid-types.test | 6 +++---
> + 2 files changed, 6 insertions(+), 6 deletions(-)
> +
> +diff --git a/test/json-invalid-types.test b/test/json-invalid-types.test
> +index c532316..a21fcd9 100755
> +--- a/test/json-invalid-types.test
> ++++ b/test/json-invalid-types.test
> +@@ -14,19 +14,19 @@ export PLIST_JSON_DEBUG=1
> +
> + echo "Converting (failure expected)"
> + $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE0 -o /dev/null
> +-if [ $? -neq 2 ]; then
> ++if [ $? -ne 2 ]; then
> +   exit 1
> + fi
> +
> + echo "Converting (failure expected)"
> + $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE1 -o /dev/null
> +-if [ $? -neq 2 ]; then
> ++if [ $? -ne 2 ]; then
> +   exit 2
> + fi
> +
> + echo "Converting (failure expected)"
> + $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE2 -o /dev/null
> +-if [ $? -neq 2 ]; then
> ++if [ $? -ne 2 ]; then
> +   exit 3
> + fi
> +
> +diff --git a/test/ostep-invalid-types.test b/test/ostep-invalid-types.test
> +index 9222394..240505c 100755
> +--- a/test/ostep-invalid-types.test
> ++++ b/test/ostep-invalid-types.test
> +@@ -14,19 +14,19 @@ export PLIST_OSTEP_DEBUG=1
> +
> + echo "Converting (failure expected)"
> + $top_builddir/tools/plistutil -f openstep -i $DATASRC/$TESTFILE0 -o
> /dev/null
> +-if [ $? -neq 2 ]; then
> ++if [ $? -ne 2 ]; then
> +   exit 1
> + fi
> +
> + echo "Converting (failure expected)"
> + $top_builddir/tools/plistutil -f openstepn -i $DATASRC/$TESTFILE1 -o
> /dev/null
> +-if [ $? -neq 2 ]; then
> ++if [ $? -ne 2 ]; then
> +   exit 2
> + fi
> +
> + echo "Converting (failure expected)"
> + $top_builddir/tools/plistutil -f openstep -i $DATASRC/$TESTFILE2 -o
> /dev/null
> +-if [ $? -neq 2 ]; then
> ++if [ $? -ne 2 ]; then
> +   exit 3
> + fi
> +
> diff --git a/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
> b/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
> index 69b9b46d62..17b1d7cfd3 100644
> --- a/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
> +++ b/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
> @@ -11,6 +11,7 @@ inherit autotools pkgconfig python3native
> python3targetconfig ptest
>  SRCREV = "2117b8fdb6b4096455bd2041a63e59a028120136"
>  SRC_URI = "git://
> github.com/libimobiledevice/libplist;protocol=https;branch=master;tag=${PV}
> <http://github.com/libimobiledevice/libplist;protocol=https;branch=master;tag=$%7BPV%7D>
> \
>             file://run-ptest \
> +           file://0001-test-fix-operator-error.patch \
>  "
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#121926):
> https://lists.openembedded.org/g/openembedded-devel/message/121926
> Mute This Topic: https://lists.openembedded.org/mt/116387427/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Ankur Tyagi Nov. 20, 2025, 9:29 a.m. UTC | #2 
On Thu, Nov 20, 2025 at 9:39 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> We still have build QA errors to address
>
> WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File /usr/lib/libplist/ptest/test/tools/plistutil in package libplist-ptest contains reference to TMPDIR [buildpaths]
> WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File /usr/lib/libplist/ptest/test/test/plist_test++ in package libplist-ptest contains reference to TMPDIR [buildpaths]
> WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File /usr/lib/libplist/ptest/test/test/plist_jtest in package libplist-ptest contains reference to TMPDIR [buildpaths]
> WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File /usr/lib/libplist/ptest/test/test/plist_btest in package libplist-ptest contains reference to TMPDIR [buildpaths]
> WARNING: libplist-2.6.0-r0 do_package_qa: QA Issue: File /usr/lib/libplist/ptest/test/test/plist_otest in package libplist-ptest contains reference to TMPDIR [buildpaths]
>
Hi Khem,

I was not seeing these errors in my build, fetching the latest version
and will try again.

cheers
Ankur

> On Wed, Nov 19, 2025 at 9:46 PM Ankur Tyagi via lists.openembedded.org <ankur.tyagi85=gmail.com@lists.openembedded.org> wrote:
>>
>> From: Ankur Tyagi <ankur.tyagi85@gmail.com>
>>
>> Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
>> ---
>>  .../0001-test-fix-operator-error.patch        | 68 +++++++++++++++++++
>>  .../libimobiledevice/libplist_2.6.0.bb        |  1 +
>>  2 files changed, 69 insertions(+)
>>  create mode 100644 meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
>>
>> diff --git a/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch b/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
>> new file mode 100644
>> index 0000000000..0866851537
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
>> @@ -0,0 +1,68 @@
>> +From 18e5b22a71f85091127cc063db79c8df687c582c Mon Sep 17 00:00:00 2001
>> +From: Ankur Tyagi <ankur.tyagi85@gmail.com>
>> +Date: Thu, 20 Nov 2025 16:01:58 +1300
>> +Subject: [PATCH] test: fix operator error
>> +
>> +Otherwise test fail with error [: -neq: binary operator expected
>> +
>> +Upstream-Status: Submitted [https://github.com/libimobiledevice/libplist/pull/284]
>> +Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
>> +---
>> + test/json-invalid-types.test  | 6 +++---
>> + test/ostep-invalid-types.test | 6 +++---
>> + 2 files changed, 6 insertions(+), 6 deletions(-)
>> +
>> +diff --git a/test/json-invalid-types.test b/test/json-invalid-types.test
>> +index c532316..a21fcd9 100755
>> +--- a/test/json-invalid-types.test
>> ++++ b/test/json-invalid-types.test
>> +@@ -14,19 +14,19 @@ export PLIST_JSON_DEBUG=1
>> +
>> + echo "Converting (failure expected)"
>> + $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE0 -o /dev/null
>> +-if [ $? -neq 2 ]; then
>> ++if [ $? -ne 2 ]; then
>> +   exit 1
>> + fi
>> +
>> + echo "Converting (failure expected)"
>> + $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE1 -o /dev/null
>> +-if [ $? -neq 2 ]; then
>> ++if [ $? -ne 2 ]; then
>> +   exit 2
>> + fi
>> +
>> + echo "Converting (failure expected)"
>> + $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE2 -o /dev/null
>> +-if [ $? -neq 2 ]; then
>> ++if [ $? -ne 2 ]; then
>> +   exit 3
>> + fi
>> +
>> +diff --git a/test/ostep-invalid-types.test b/test/ostep-invalid-types.test
>> +index 9222394..240505c 100755
>> +--- a/test/ostep-invalid-types.test
>> ++++ b/test/ostep-invalid-types.test
>> +@@ -14,19 +14,19 @@ export PLIST_OSTEP_DEBUG=1
>> +
>> + echo "Converting (failure expected)"
>> + $top_builddir/tools/plistutil -f openstep -i $DATASRC/$TESTFILE0 -o /dev/null
>> +-if [ $? -neq 2 ]; then
>> ++if [ $? -ne 2 ]; then
>> +   exit 1
>> + fi
>> +
>> + echo "Converting (failure expected)"
>> + $top_builddir/tools/plistutil -f openstepn -i $DATASRC/$TESTFILE1 -o /dev/null
>> +-if [ $? -neq 2 ]; then
>> ++if [ $? -ne 2 ]; then
>> +   exit 2
>> + fi
>> +
>> + echo "Converting (failure expected)"
>> + $top_builddir/tools/plistutil -f openstep -i $DATASRC/$TESTFILE2 -o /dev/null
>> +-if [ $? -neq 2 ]; then
>> ++if [ $? -ne 2 ]; then
>> +   exit 3
>> + fi
>> +
>> diff --git a/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb b/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
>> index 69b9b46d62..17b1d7cfd3 100644
>> --- a/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
>> +++ b/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
>> @@ -11,6 +11,7 @@ inherit autotools pkgconfig python3native python3targetconfig ptest
>>  SRCREV = "2117b8fdb6b4096455bd2041a63e59a028120136"
>>  SRC_URI = "git://github.com/libimobiledevice/libplist;protocol=https;branch=master;tag=${PV} \
>>             file://run-ptest \
>> +           file://0001-test-fix-operator-error.patch \
>>  "
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#121926): https://lists.openembedded.org/g/openembedded-devel/message/121926
>> Mute This Topic: https://lists.openembedded.org/mt/116387427/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch b/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
new file mode 100644
index 0000000000..0866851537
--- /dev/null
+++ b/meta-oe/recipes-extended/libimobiledevice/libplist/0001-test-fix-operator-error.patch
@@ -0,0 +1,68 @@ 
+From 18e5b22a71f85091127cc063db79c8df687c582c Mon Sep 17 00:00:00 2001
+From: Ankur Tyagi <ankur.tyagi85@gmail.com>
+Date: Thu, 20 Nov 2025 16:01:58 +1300
+Subject: [PATCH] test: fix operator error
+
+Otherwise test fail with error [: -neq: binary operator expected
+
+Upstream-Status: Submitted [https://github.com/libimobiledevice/libplist/pull/284]
+Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
+---
+ test/json-invalid-types.test  | 6 +++---
+ test/ostep-invalid-types.test | 6 +++---
+ 2 files changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/test/json-invalid-types.test b/test/json-invalid-types.test
+index c532316..a21fcd9 100755
+--- a/test/json-invalid-types.test
++++ b/test/json-invalid-types.test
+@@ -14,19 +14,19 @@ export PLIST_JSON_DEBUG=1
+ 
+ echo "Converting (failure expected)"
+ $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE0 -o /dev/null
+-if [ $? -neq 2 ]; then
++if [ $? -ne 2 ]; then
+   exit 1
+ fi
+ 
+ echo "Converting (failure expected)"
+ $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE1 -o /dev/null
+-if [ $? -neq 2 ]; then
++if [ $? -ne 2 ]; then
+   exit 2
+ fi
+ 
+ echo "Converting (failure expected)"
+ $top_builddir/tools/plistutil -f json -i $DATASRC/$TESTFILE2 -o /dev/null
+-if [ $? -neq 2 ]; then
++if [ $? -ne 2 ]; then
+   exit 3
+ fi
+ 
+diff --git a/test/ostep-invalid-types.test b/test/ostep-invalid-types.test
+index 9222394..240505c 100755
+--- a/test/ostep-invalid-types.test
++++ b/test/ostep-invalid-types.test
+@@ -14,19 +14,19 @@ export PLIST_OSTEP_DEBUG=1
+ 
+ echo "Converting (failure expected)"
+ $top_builddir/tools/plistutil -f openstep -i $DATASRC/$TESTFILE0 -o /dev/null
+-if [ $? -neq 2 ]; then
++if [ $? -ne 2 ]; then
+   exit 1
+ fi
+ 
+ echo "Converting (failure expected)"
+ $top_builddir/tools/plistutil -f openstepn -i $DATASRC/$TESTFILE1 -o /dev/null
+-if [ $? -neq 2 ]; then
++if [ $? -ne 2 ]; then
+   exit 2
+ fi
+ 
+ echo "Converting (failure expected)"
+ $top_builddir/tools/plistutil -f openstep -i $DATASRC/$TESTFILE2 -o /dev/null
+-if [ $? -neq 2 ]; then
++if [ $? -ne 2 ]; then
+   exit 3
+ fi
+ 
diff --git a/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb b/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
index 69b9b46d62..17b1d7cfd3 100644
--- a/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
+++ b/meta-oe/recipes-extended/libimobiledevice/libplist_2.6.0.bb
@@ -11,6 +11,7 @@  inherit autotools pkgconfig python3native python3targetconfig ptest
 SRCREV = "2117b8fdb6b4096455bd2041a63e59a028120136"
 SRC_URI = "git://github.com/libimobiledevice/libplist;protocol=https;branch=master;tag=${PV} \
            file://run-ptest \
+           file://0001-test-fix-operator-error.patch \
 "