| Message ID | 20251113112122.1553793-1-anuj.mittal@oss.qualcomm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [meta-networking,master,scarthgap] remmina: add DEPENDS on curl | expand |
This patch mentions master in subject but the patch is not for version of recipe in master. Can you confirm if it is still needed with the master version ? On Thu, Nov 13, 2025 at 3:21 AM Anuj Mittal via lists.openembedded.org <anuj.mittal=oss.qualcomm.com@lists.openembedded.org> wrote: > remmina has a hard dependency on curl [1]. This doesn't result in an > error on branches with gtk4 because curl gets pulled in via vte -> > gtk4 -> gstreamer-plugins-bad -> curl. > > Add an explicit DEPENDS on curl to reflect the dependency. > > [1] > https://github.com/FreeRDP/Remmina/blob/a8afdd728d215791e3ce2ebc0411569529cd0296/src/CMakeLists.txt#L259 > > Signed-off-by: Anuj Mittal <anuj.mittal@oss.qualcomm.com> > --- > meta-oe/recipes-support/remmina/remmina_1.4.34.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb > b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb > index 921d34d9fd..d101908b94 100644 > --- a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb > +++ b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb > @@ -20,6 +20,7 @@ DEPENDS = " \ > libvncserver \ > libsecret \ > libxkbfile \ > + curl \ > " > > DEPENDS:append:libc-musl = " libexecinfo" > -- > 2.51.2 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#121643): > https://lists.openembedded.org/g/openembedded-devel/message/121643 > Mute This Topic: https://lists.openembedded.org/mt/116272361/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
Sorry, I must have generated it from wrong workspace. I had tested on master and it doesn't give an error there because of the reasons mentioned but it'd be good to explicitly mention the dependency anyway. Should I send a v2 for correct recipe version? On Fri, Nov 14, 2025 at 10:17 AM Khem Raj <raj.khem@gmail.com> wrote: > This patch mentions master in subject but the patch is not for version of > recipe in master. Can you confirm if it is still needed with the master > version ? > > On Thu, Nov 13, 2025 at 3:21 AM Anuj Mittal via lists.openembedded.org > <anuj.mittal=oss.qualcomm.com@lists.openembedded.org> wrote: > >> remmina has a hard dependency on curl [1]. This doesn't result in an >> error on branches with gtk4 because curl gets pulled in via vte -> >> gtk4 -> gstreamer-plugins-bad -> curl. >> >> Add an explicit DEPENDS on curl to reflect the dependency. >> >> [1] >> https://github.com/FreeRDP/Remmina/blob/a8afdd728d215791e3ce2ebc0411569529cd0296/src/CMakeLists.txt#L259 >> >> Signed-off-by: Anuj Mittal <anuj.mittal@oss.qualcomm.com> >> --- >> meta-oe/recipes-support/remmina/remmina_1.4.34.bb | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >> b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >> index 921d34d9fd..d101908b94 100644 >> --- a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >> +++ b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >> @@ -20,6 +20,7 @@ DEPENDS = " \ >> libvncserver \ >> libsecret \ >> libxkbfile \ >> + curl \ >> " >> >> DEPENDS:append:libc-musl = " libexecinfo" >> -- >> 2.51.2 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#121643): >> https://lists.openembedded.org/g/openembedded-devel/message/121643 >> Mute This Topic: https://lists.openembedded.org/mt/116272361/1997914 >> Group Owner: openembedded-devel+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ >> raj.khem@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >>
On Thu, Nov 13, 2025 at 6:22 PM Anuj Mittal <anuj.mittal@oss.qualcomm.com> wrote: > Sorry, I must have generated it from wrong workspace. I had tested on > master and it doesn't give an error there because of the reasons mentioned > but it'd be good to explicitly mention the dependency anyway. > > Should I send a v2 for correct recipe version? > Yes please. > > On Fri, Nov 14, 2025 at 10:17 AM Khem Raj <raj.khem@gmail.com> wrote: > >> This patch mentions master in subject but the patch is not for version of >> recipe in master. Can you confirm if it is still needed with the master >> version ? >> >> On Thu, Nov 13, 2025 at 3:21 AM Anuj Mittal via lists.openembedded.org >> <anuj.mittal=oss.qualcomm.com@lists.openembedded.org> wrote: >> >>> remmina has a hard dependency on curl [1]. This doesn't result in an >>> error on branches with gtk4 because curl gets pulled in via vte -> >>> gtk4 -> gstreamer-plugins-bad -> curl. >>> >>> Add an explicit DEPENDS on curl to reflect the dependency. >>> >>> [1] >>> https://github.com/FreeRDP/Remmina/blob/a8afdd728d215791e3ce2ebc0411569529cd0296/src/CMakeLists.txt#L259 >>> >>> Signed-off-by: Anuj Mittal <anuj.mittal@oss.qualcomm.com> >>> --- >>> meta-oe/recipes-support/remmina/remmina_1.4.34.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >>> b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >>> index 921d34d9fd..d101908b94 100644 >>> --- a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >>> +++ b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb >>> @@ -20,6 +20,7 @@ DEPENDS = " \ >>> libvncserver \ >>> libsecret \ >>> libxkbfile \ >>> + curl \ >>> " >>> >>> DEPENDS:append:libc-musl = " libexecinfo" >>> -- >>> 2.51.2 >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> View/Reply Online (#121643): >>> https://lists.openembedded.org/g/openembedded-devel/message/121643 >>> Mute This Topic: https://lists.openembedded.org/mt/116272361/1997914 >>> Group Owner: openembedded-devel+owner@lists.openembedded.org >>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ >>> raj.khem@gmail.com] >>> -=-=-=-=-=-=-=-=-=-=-=- >>> >>>
diff --git a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb index 921d34d9fd..d101908b94 100644 --- a/meta-oe/recipes-support/remmina/remmina_1.4.34.bb +++ b/meta-oe/recipes-support/remmina/remmina_1.4.34.bb @@ -20,6 +20,7 @@ DEPENDS = " \ libvncserver \ libsecret \ libxkbfile \ + curl \ " DEPENDS:append:libc-musl = " libexecinfo"
remmina has a hard dependency on curl [1]. This doesn't result in an error on branches with gtk4 because curl gets pulled in via vte -> gtk4 -> gstreamer-plugins-bad -> curl. Add an explicit DEPENDS on curl to reflect the dependency. [1] https://github.com/FreeRDP/Remmina/blob/a8afdd728d215791e3ce2ebc0411569529cd0296/src/CMakeLists.txt#L259 Signed-off-by: Anuj Mittal <anuj.mittal@oss.qualcomm.com> --- meta-oe/recipes-support/remmina/remmina_1.4.34.bb | 1 + 1 file changed, 1 insertion(+)