diff mbox series

[meta-oe] poppler: fix racing build issue

Message ID 20251021102233.706528-1-hongxu.jia@windriver.com
State New
Headers show
Series [meta-oe] poppler: fix racing build issue | expand

Commit Message

Hongxu Jia Oct. 21, 2025, 10:22 a.m. UTC
There is a racing issue in world build while multilib enabled:

...log.do_install...
CMake Error at utils/po/ca/cmake_install.cmake:46 (file):
  file INSTALL cannot find
  "TOPDIR/tmp/work/core2-32-wrs-linux/poppler/25.08.0/build/utils/po/ca/pdfsig.gmo":
  No such file or directory.
Call Stack (most recent call first):
  utils/po/cmake_install.cmake:47 (include)
  utils/cmake_install.cmake:243 (include)
  cmake_install.cmake:229 (include)
...log.do_install...

It seems gettext_process_po_files has racing issue [1], but
not sure, and the catalan translation of pdfsig is not vital
for poppler. So revert upstream commit "pdfsig: Catalan translation"
to workaround

[1] https://public.kitware.com/Bug/view.php?id=14904

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 .../0001-workaround-build-racing.patch        | 43 +++++++++++++++++++
 .../poppler/poppler_25.08.0.bb                |  1 +
 2 files changed, 44 insertions(+)
 create mode 100644 meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch

Comments

Khem Raj Oct. 21, 2025, 3:59 p.m. UTC | #1
if it is meant for master branch then please make sure to rebase on
top of latest master always. If it is for a release then tag the
subject with branch name.

On Tue, Oct 21, 2025 at 3:22 AM hongxu via lists.openembedded.org
<hongxu.jia=eng.windriver.com@lists.openembedded.org> wrote:
>
> There is a racing issue in world build while multilib enabled:
>
> ...log.do_install...
> CMake Error at utils/po/ca/cmake_install.cmake:46 (file):
>   file INSTALL cannot find
>   "TOPDIR/tmp/work/core2-32-wrs-linux/poppler/25.08.0/build/utils/po/ca/pdfsig.gmo":
>   No such file or directory.
> Call Stack (most recent call first):
>   utils/po/cmake_install.cmake:47 (include)
>   utils/cmake_install.cmake:243 (include)
>   cmake_install.cmake:229 (include)
> ...log.do_install...
>
> It seems gettext_process_po_files has racing issue [1], but
> not sure, and the catalan translation of pdfsig is not vital
> for poppler. So revert upstream commit "pdfsig: Catalan translation"
> to workaround
>
> [1] https://public.kitware.com/Bug/view.php?id=14904
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  .../0001-workaround-build-racing.patch        | 43 +++++++++++++++++++
>  .../poppler/poppler_25.08.0.bb                |  1 +
>  2 files changed, 44 insertions(+)
>  create mode 100644 meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch
>
> diff --git a/meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch b/meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch
> new file mode 100644
> index 0000000000..fdf4f7ff70
> --- /dev/null
> +++ b/meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch
> @@ -0,0 +1,43 @@
> +From 83ad73024c69d41fda302f39acf50c381684890e Mon Sep 17 00:00:00 2001
> +From: Hongxu Jia <hongxu.jia@windriver.com>
> +Date: Tue, 21 Oct 2025 02:39:36 -0700
> +Subject: [PATCH] workaround build racing
> +
> +There is a racing issue in world build while multilib enabled:
> +
> +...log.do_install...
> +CMake Error at utils/po/ca/cmake_install.cmake:46 (file):
> +  file INSTALL cannot find
> +  "TOPDIR/tmp/work/core2-32-wrs-linux/poppler/25.08.0/build/utils/po/ca/pdfsig.gmo":
> +  No such file or directory.
> +Call Stack (most recent call first):
> +  utils/po/cmake_install.cmake:47 (include)
> +  utils/cmake_install.cmake:243 (include)
> +  cmake_install.cmake:229 (include)
> +...log.do_install...
> +
> +Revert "pdfsig: Catalan translation" to workaround
> +
> +This reverts commit 99f5416d9bfb6a34bbc5cbcb368e258b98fd3f08.
> +
> +Upstream-Status: Inappropriate [Yocto specific]
> +
> +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> +---
> + utils/po/ca/CMakeLists.txt | 4 ----
> + 1 file changed, 4 deletions(-)
> + delete mode 100644 utils/po/ca/CMakeLists.txt
> +
> +diff --git a/utils/po/ca/CMakeLists.txt b/utils/po/ca/CMakeLists.txt
> +deleted file mode 100644
> +index 3225131c..00000000
> +--- a/utils/po/ca/CMakeLists.txt
> ++++ /dev/null
> +@@ -1,4 +0,0 @@
> +-get_filename_component(_lang ${CMAKE_CURRENT_SOURCE_DIR} NAME)
> +-gettext_process_po_files(${_lang} ALL INSTALL_DESTINATION ${CMAKE_INSTALL_LOCALEDIR} PO_FILES
> +-  pdfsig.po
> +-)
> +--
> +2.49.0
> +
> diff --git a/meta-oe/recipes-support/poppler/poppler_25.08.0.bb b/meta-oe/recipes-support/poppler/poppler_25.08.0.bb
> index 45f94b0ae7..3b0b4b0e99 100644
> --- a/meta-oe/recipes-support/poppler/poppler_25.08.0.bb
> +++ b/meta-oe/recipes-support/poppler/poppler_25.08.0.bb
> @@ -7,6 +7,7 @@ SRC_URI = "http://poppler.freedesktop.org/${BP}.tar.xz \
>             file://0001-Do-not-overwrite-all-our-build-flags.patch \
>             file://basename-include.patch \
>             file://0001-cmake-Do-not-use-isystem.patch \
> +           file://0001-workaround-build-racing.patch \
>             "
>  SRC_URI[sha256sum] = "425ed4d4515a093bdcdbbaac6876f20617451edc710df6a4fd6c45dd67eb418d"
>
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#120834): https://lists.openembedded.org/g/openembedded-devel/message/120834
> Mute This Topic: https://lists.openembedded.org/mt/115870675/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch b/meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch
new file mode 100644
index 0000000000..fdf4f7ff70
--- /dev/null
+++ b/meta-oe/recipes-support/poppler/poppler/0001-workaround-build-racing.patch
@@ -0,0 +1,43 @@ 
+From 83ad73024c69d41fda302f39acf50c381684890e Mon Sep 17 00:00:00 2001
+From: Hongxu Jia <hongxu.jia@windriver.com>
+Date: Tue, 21 Oct 2025 02:39:36 -0700
+Subject: [PATCH] workaround build racing
+
+There is a racing issue in world build while multilib enabled:
+
+...log.do_install...
+CMake Error at utils/po/ca/cmake_install.cmake:46 (file):
+  file INSTALL cannot find
+  "TOPDIR/tmp/work/core2-32-wrs-linux/poppler/25.08.0/build/utils/po/ca/pdfsig.gmo":
+  No such file or directory.
+Call Stack (most recent call first):
+  utils/po/cmake_install.cmake:47 (include)
+  utils/cmake_install.cmake:243 (include)
+  cmake_install.cmake:229 (include)
+...log.do_install...
+
+Revert "pdfsig: Catalan translation" to workaround
+
+This reverts commit 99f5416d9bfb6a34bbc5cbcb368e258b98fd3f08.
+
+Upstream-Status: Inappropriate [Yocto specific]
+
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+---
+ utils/po/ca/CMakeLists.txt | 4 ----
+ 1 file changed, 4 deletions(-)
+ delete mode 100644 utils/po/ca/CMakeLists.txt
+
+diff --git a/utils/po/ca/CMakeLists.txt b/utils/po/ca/CMakeLists.txt
+deleted file mode 100644
+index 3225131c..00000000
+--- a/utils/po/ca/CMakeLists.txt
++++ /dev/null
+@@ -1,4 +0,0 @@
+-get_filename_component(_lang ${CMAKE_CURRENT_SOURCE_DIR} NAME)
+-gettext_process_po_files(${_lang} ALL INSTALL_DESTINATION ${CMAKE_INSTALL_LOCALEDIR} PO_FILES
+-  pdfsig.po
+-)
+-- 
+2.49.0
+
diff --git a/meta-oe/recipes-support/poppler/poppler_25.08.0.bb b/meta-oe/recipes-support/poppler/poppler_25.08.0.bb
index 45f94b0ae7..3b0b4b0e99 100644
--- a/meta-oe/recipes-support/poppler/poppler_25.08.0.bb
+++ b/meta-oe/recipes-support/poppler/poppler_25.08.0.bb
@@ -7,6 +7,7 @@  SRC_URI = "http://poppler.freedesktop.org/${BP}.tar.xz \
            file://0001-Do-not-overwrite-all-our-build-flags.patch \
            file://basename-include.patch \
            file://0001-cmake-Do-not-use-isystem.patch \
+           file://0001-workaround-build-racing.patch \
            "
 SRC_URI[sha256sum] = "425ed4d4515a093bdcdbbaac6876f20617451edc710df6a4fd6c45dd67eb418d"