| Message ID | 20250925062111.240262-4-ankur.tyagi85@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | cherry-picks from master branch | expand |
I dunno. This recipe is a bit of a mess, at least regarding the application's versioning habits and the recipe's history due to this. The changelog definitely looks suitable enough. And interestingly Kirkstone has a newer version - which has been reverted later in master (which revert was later reverted once again, to have the latest version), and that old version got into Walnascar. But here is the real problem: this version goes backwards[1] (at least as far as Bitbake is concerned) - and I have seen people being unhappy about this. I wonder if maybe in master it would be better to give this recipe a PE... [1]: https://gist.github.com/OldManYellsAtCloud/f3e26c13bd68118f8e586803e9b3a8d4 - this was copied from buildhistory.bbclass and from bb.utils module On 9/25/25 08:21, Ankur Tyagi via lists.openembedded.org wrote: > From: Changqing Li <changqing.li@windriver.com> > > Upstream changelogs: > https://sg.danny.cz/scsi/lsscsi.ChangeLog > > Changes in this commit are referenced from 51e410a84eaa9742ea8881435925a242fb5529cd. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > (cherry picked from commit 51e410a84eaa9742ea8881435925a242fb5529cd) > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com> > --- > .../recipes-bsp/lsscsi/{lsscsi_030.bb => lsscsi_0.32.bb} | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > rename meta-oe/recipes-bsp/lsscsi/{lsscsi_030.bb => lsscsi_0.32.bb} (63%) > > diff --git a/meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb b/meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb > similarity index 63% > rename from meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb > rename to meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb > index 63b94e9d6e..127be8fbfa 100644 > --- a/meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb > +++ b/meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb > @@ -6,8 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" > > SRC_URI = "http://sg.danny.cz/scsi/${BP}.tgz" > > -SRC_URI[sha256sum] = "619a2187405f02c5f57682f3478bffc75326803cd08839e39d434250c5518b15" > +SRC_URI[sha256sum] = "0a800e9e94dca2ab702d65d72777ae8cae078e3d74d0bcbed64ba0849e8029a1" > > inherit autotools > > -S = "${WORKDIR}/lsscsi-${PV}r154" > +S = "${WORKDIR}/lsscsi-${PV}" > + > +UPSTREAM_CHECK_REGEX = "lsscsi-(?P<pver>\d+(\.\d+)+)\.tgz" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#119852): https://lists.openembedded.org/g/openembedded-devel/message/119852 > Mute This Topic: https://lists.openembedded.org/mt/115426052/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, Sep 26, 2025 at 1:33 AM Gyorgy Sarvari <skandigraun@gmail.com> wrote: > > I dunno. This recipe is a bit of a mess, at least regarding the > application's versioning habits and the recipe's history due to this. > > The changelog definitely looks suitable enough. And interestingly > Kirkstone has a newer version - which has been reverted later in master > (which revert was later reverted once again, to have the latest > version), and that old version got into Walnascar. > > But here is the real problem: this version goes backwards[1] (at least > as far as Bitbake is concerned) - and I have seen people being unhappy > about this. I wonder if maybe in master it would be better to give this > recipe a PE... > > [1]: > https://gist.github.com/OldManYellsAtCloud/f3e26c13bd68118f8e586803e9b3a8d4 > - this was copied from buildhistory.bbclass and from bb.utils module > very good catch, I was able to reproduce that by replicating upgrade from lsscsi_030.bb -> lsscsi_0.32.bb $ bitbake -c cleansstate lsscsi ... $ bitbake -e lsscsi | grep "^PV=" PV="030" $ bitbake lsscsi ... meta-oe meta-python meta-networking meta-gnome meta-filesystems meta-initramfs meta-multimedia meta-perl meta-webserver meta-xfce = "walnascar:80ab58cc404959ae2f0e8b2e68935b3bfd8e8cfe" Sstate summary: Wanted 83 Local 73 Mirrors 1 Missed 9 Current 191 (89% match, 96% complete)#################################################################### | ETA: 0:00:00 Initialising tasks: 100% |#####################################################################################################################################################| Time: 0:00:03 NOTE: Executing Tasks NOTE: Tasks Summary: Attempted 834 tasks of which 816 didn't need to be rerun and all succeeded. <= checkout dev branch => $ bitbake -e lsscsi | grep "^PV=" PV="0.32" $ bitbake lsscsi ... meta-oe meta-python meta-networking meta-gnome meta-filesystems meta-initramfs meta-multimedia meta-perl meta-webserver meta-xfce = "lsscsi-walnascar:2aaa71377618350d2af8fafc51dcd4fb403ed554" Sstate summary: Wanted 83 Local 83 Mirrors 0 Missed 0 Current 191 (100% match, 100% complete)################################################################## | ETA: 0:00:00 Initialising tasks: 100% |#####################################################################################################################################################| Time: 0:00:01 NOTE: Executing Tasks NOTE: Tasks Summary: Attempted 834 tasks of which 833 didn't need to be rerun and all succeeded. <= bump PE => $ bitbake -e lsscsi | grep "^PE=" PE="1" $ bitbake lsscsi ... meta-oe meta-python meta-networking meta-gnome meta-filesystems meta-initramfs meta-multimedia meta-perl meta-webserver meta-xfce = "lsscsi-walnascar:2aaa71377618350d2af8fafc51dcd4fb403ed554" Sstate summary: Wanted 81 Local 74 Mirrors 0 Missed 7 Current 193 (91% match, 97% complete)#################################################################### | ETA: 0:00:00 Removing 5 stale sstate objects for arch core2-64: 100% |######################################################################################################################| Time: 0:00:00 Removing 1 stale sstate objects for arch qemux86_64: 100% |####################################################################################################################| Time: 0:00:00 NOTE: Executing Tasks NOTE: Tasks Summary: Attempted 834 tasks of which 818 didn't need to be rerun and all succeeded. I will send patches for master and walnascar. > On 9/25/25 08:21, Ankur Tyagi via lists.openembedded.org wrote: > > From: Changqing Li <changqing.li@windriver.com> > > > > Upstream changelogs: > > https://sg.danny.cz/scsi/lsscsi.ChangeLog > > > > Changes in this commit are referenced from 51e410a84eaa9742ea8881435925a242fb5529cd. > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > (cherry picked from commit 51e410a84eaa9742ea8881435925a242fb5529cd) > > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com> > > --- > > .../recipes-bsp/lsscsi/{lsscsi_030.bb => lsscsi_0.32.bb} | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > rename meta-oe/recipes-bsp/lsscsi/{lsscsi_030.bb => lsscsi_0.32.bb} (63%) > > > > diff --git a/meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb b/meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb > > similarity index 63% > > rename from meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb > > rename to meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb > > index 63b94e9d6e..127be8fbfa 100644 > > --- a/meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb > > +++ b/meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb > > @@ -6,8 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" > > > > SRC_URI = "http://sg.danny.cz/scsi/${BP}.tgz" > > > > -SRC_URI[sha256sum] = "619a2187405f02c5f57682f3478bffc75326803cd08839e39d434250c5518b15" > > +SRC_URI[sha256sum] = "0a800e9e94dca2ab702d65d72777ae8cae078e3d74d0bcbed64ba0849e8029a1" > > > > inherit autotools > > > > -S = "${WORKDIR}/lsscsi-${PV}r154" > > +S = "${WORKDIR}/lsscsi-${PV}" > > + > > +UPSTREAM_CHECK_REGEX = "lsscsi-(?P<pver>\d+(\.\d+)+)\.tgz" > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#119852): https://lists.openembedded.org/g/openembedded-devel/message/119852 > > Mute This Topic: https://lists.openembedded.org/mt/115426052/6084445 > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > >
diff --git a/meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb b/meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb similarity index 63% rename from meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb rename to meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb index 63b94e9d6e..127be8fbfa 100644 --- a/meta-oe/recipes-bsp/lsscsi/lsscsi_030.bb +++ b/meta-oe/recipes-bsp/lsscsi/lsscsi_0.32.bb @@ -6,8 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" SRC_URI = "http://sg.danny.cz/scsi/${BP}.tgz" -SRC_URI[sha256sum] = "619a2187405f02c5f57682f3478bffc75326803cd08839e39d434250c5518b15" +SRC_URI[sha256sum] = "0a800e9e94dca2ab702d65d72777ae8cae078e3d74d0bcbed64ba0849e8029a1" inherit autotools -S = "${WORKDIR}/lsscsi-${PV}r154" +S = "${WORKDIR}/lsscsi-${PV}" + +UPSTREAM_CHECK_REGEX = "lsscsi-(?P<pver>\d+(\.\d+)+)\.tgz"