diff mbox series

[meta-python,2/4] python3-frozenlist: support reproducible

Message ID 20250918071548.3934769-2-hongxu.jia@windriver.com
State Accepted
Headers show
Series [meta-python,1/4] python3-pyzmq: set cmake build dir to support reproducible | expand

Commit Message

Hongxu Jia Sept. 18, 2025, 7:15 a.m. UTC
In order to make the generated library be reproducible, build wheel
in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's
option -fdebug-prefix-map could work as expected

Note: To support reproducible, it also requires oe-core commit [1] to be merged

[1] https://lists.openembedded.org/g/openembedded-core/message/223604?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2C%2C20%2C2%2C0%2C115291386%2Cd%253D3&d=3

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 .../files/0001-build-wheel-in-place.patch     | 31 +++++++++++++++++++
 .../python/python3-frozenlist_1.7.0.bb        |  3 ++
 2 files changed, 34 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch

Comments

Khem Raj Sept. 19, 2025, 4:01 a.m. UTC | #1
seeing

stdio: ERROR: python3-frozenlist-1.7.0-r0 do_package_qa: QA Issue:
File /usr/src/debug/python3-frozenlist/1.7.0/frozenlist/_frozenlist.cpp
in package python3-frozenlist-src contains reference to TMPDIR
[buildpaths]
stdio: ERROR: python3-frozenlist-1.7.0-r0 do_package_qa: Fatal QA
errors were found, failing task.


See - https://autobuilder.yoctoproject.org/valkyrie/?#/builders/81/builds/935

On Thu, Sep 18, 2025 at 12:16 AM hongxu via lists.openembedded.org
<hongxu.jia=eng.windriver.com@lists.openembedded.org> wrote:
>
> In order to make the generated library be reproducible, build wheel
> in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's
> option -fdebug-prefix-map could work as expected
>
> Note: To support reproducible, it also requires oe-core commit [1] to be merged
>
> [1] https://lists.openembedded.org/g/openembedded-core/message/223604?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2C%2C20%2C2%2C0%2C115291386%2Cd%253D3&d=3
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  .../files/0001-build-wheel-in-place.patch     | 31 +++++++++++++++++++
>  .../python/python3-frozenlist_1.7.0.bb        |  3 ++
>  2 files changed, 34 insertions(+)
>  create mode 100644 meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch
>
> diff --git a/meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch b/meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch
> new file mode 100644
> index 0000000000..84f81da775
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch
> @@ -0,0 +1,31 @@
> +From 606843ad079d9d0dac1172533d42b5a2327b99ed Mon Sep 17 00:00:00 2001
> +From: Hongxu Jia <hongxu.jia@windriver.com>
> +Date: Wed, 17 Sep 2025 15:41:09 +0800
> +Subject: [PATCH] build wheel in place
> +
> +In order to make the generated library be reproducible, build wheel
> +in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's
> +option -fdebug-prefix-map could work as expected
> +
> +Upstream-Status: Pending
> +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> +---
> + packaging/pep517_backend/_backend.py | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/packaging/pep517_backend/_backend.py b/packaging/pep517_backend/_backend.py
> +index 61cad34..d5d839e 100644
> +--- a/packaging/pep517_backend/_backend.py
> ++++ b/packaging/pep517_backend/_backend.py
> +@@ -316,7 +316,7 @@ def build_wheel(
> +     """
> +     with maybe_prebuild_c_extensions(
> +             line_trace_cython_when_unset=False,
> +-            build_inplace=False,
> ++            build_inplace=True,
> +             config_settings=config_settings,
> +     ):
> +         return _setuptools_build_wheel(
> +--
> +2.34.1
> +
> diff --git a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb
> index 7d813a026c..d832494c82 100644
> --- a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb
> +++ b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb
> @@ -7,6 +7,9 @@ SRC_URI[sha256sum] = "2e310d81923c2437ea8670467121cc3e9b0f76d3043cc1d2331d56c7fb
>
>  inherit pypi python_setuptools_build_meta cython
>
> +SRC_URI += " \
> +    file://0001-build-wheel-in-place.patch \
> +"
>  DEPENDS += " \
>      python3-expandvars-native \
>  "
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#119531): https://lists.openembedded.org/g/openembedded-devel/message/119531
> Mute This Topic: https://lists.openembedded.org/mt/115306109/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
hongxu Sept. 21, 2025, 2:34 a.m. UTC | #2
On Thu, Sep 18, 2025 at 09:01 PM, Khem Raj wrote:

> 
> seeing
> 
> stdio: ERROR: python3-frozenlist-1.7.0-r0 do_package_qa: QA Issue:
> File /usr/src/debug/python3-frozenlist/1.7.0/frozenlist/_frozenlist.cpp
> in package python3-frozenlist-src contains reference to TMPDIR
> [buildpaths]
> stdio: ERROR: python3-frozenlist-1.7.0-r0 do_package_qa: Fatal QA
> errors were found, failing task.
> 
> 
> See - https://autobuilder.yoctoproject.org/valkyrie/?#/builders/81/builds/935
> ( https://autobuilder.yoctoproject.org/valkyrie/#/builders/81/builds/935 )

As I mentioned in the commit message, it also requires oe-core commit [1] to be merged, otherwise the issue you met

[1] https://lists.openembedded.org/g/openembedded-core/message/223604?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2C%2C20%2C2%2C0%2C115291386%2Cd%253D3&d=3

//Hongxu

> 
> On Thu, Sep 18, 2025 at 12:16 AM hongxu via lists.openembedded.org
> <hongxu.jia=eng.windriver.com@...> wrote:
diff mbox series

Patch

diff --git a/meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch b/meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch
new file mode 100644
index 0000000000..84f81da775
--- /dev/null
+++ b/meta-python/recipes-devtools/python/files/0001-build-wheel-in-place.patch
@@ -0,0 +1,31 @@ 
+From 606843ad079d9d0dac1172533d42b5a2327b99ed Mon Sep 17 00:00:00 2001
+From: Hongxu Jia <hongxu.jia@windriver.com>
+Date: Wed, 17 Sep 2025 15:41:09 +0800
+Subject: [PATCH] build wheel in place
+
+In order to make the generated library be reproducible, build wheel
+in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's
+option -fdebug-prefix-map could work as expected
+
+Upstream-Status: Pending
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+---
+ packaging/pep517_backend/_backend.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/packaging/pep517_backend/_backend.py b/packaging/pep517_backend/_backend.py
+index 61cad34..d5d839e 100644
+--- a/packaging/pep517_backend/_backend.py
++++ b/packaging/pep517_backend/_backend.py
+@@ -316,7 +316,7 @@ def build_wheel(
+     """
+     with maybe_prebuild_c_extensions(
+             line_trace_cython_when_unset=False,
+-            build_inplace=False,
++            build_inplace=True,
+             config_settings=config_settings,
+     ):
+         return _setuptools_build_wheel(
+-- 
+2.34.1
+
diff --git a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb
index 7d813a026c..d832494c82 100644
--- a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb
+++ b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb
@@ -7,6 +7,9 @@  SRC_URI[sha256sum] = "2e310d81923c2437ea8670467121cc3e9b0f76d3043cc1d2331d56c7fb
 
 inherit pypi python_setuptools_build_meta cython
 
+SRC_URI += " \
+    file://0001-build-wheel-in-place.patch \
+"
 DEPENDS += " \
     python3-expandvars-native \
 "