diff mbox series

[meta-oe,RESEND,v2] imx-cst: Replace hard-coded linux64 with linux${SITEINFO_BITS}

Message ID 20250902180740.263633-1-marek.vasut@mailbox.org
State Under Review
Headers show
Series [meta-oe,RESEND,v2] imx-cst: Replace hard-coded linux64 with linux${SITEINFO_BITS} | expand

Commit Message

Marek Vasut Sept. 2, 2025, 6:07 p.m. UTC 
Replace hard-coded linux64 with linux${SITEINFO_BITS}. This way,
32bit machines can also build and use this tool correctly.

Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
---
Cc: Kelefa Sane <kelefa.sane@smile.fr>
Cc: Khem Raj <raj.khem@gmail.com>
Cc: Ulrich Ölmann <u.oelmann@pengutronix.de>
Cc: Yoann Congal <yoann.congal@smile.fr>
---
V2: - inherit siteinfo
---
 meta-oe/recipes-support/imx-cst/imx-cst_3.4.1.bb | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Marek Vasut Sept. 2, 2025, 6:08 p.m. UTC | #1 
On 9/2/25 8:07 PM, Marek Vasut wrote:
> Replace hard-coded linux64 with linux${SITEINFO_BITS}. This way,
> 32bit machines can also build and use this tool correctly.
> 
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: Kelefa Sane <kelefa.sane@smile.fr>
> Cc: Khem Raj <raj.khem@gmail.com>
> Cc: Ulrich Ölmann <u.oelmann@pengutronix.de>
> Cc: Yoann Congal <yoann.congal@smile.fr>
> ---
> V2: - inherit siteinfo
Sorry for the all the noise, had some ML subscription issues, now resolved.
Fabio Estevam Sept. 2, 2025, 6:54 p.m. UTC | #2 
On Tue, Sep 2, 2025 at 3:08 PM Marek Vasut via lists.openembedded.org
<marek.vasut=mailbox.org@lists.openembedded.org> wrote:
>
> Replace hard-coded linux64 with linux${SITEINFO_BITS}. This way,
> 32bit machines can also build and use this tool correctly.
>
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>

Thanks for the fix.

Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/imx-cst/imx-cst_3.4.1.bb b/meta-oe/recipes-support/imx-cst/imx-cst_3.4.1.bb
index 12b319843e..97117eb914 100644
--- a/meta-oe/recipes-support/imx-cst/imx-cst_3.4.1.bb
+++ b/meta-oe/recipes-support/imx-cst/imx-cst_3.4.1.bb
@@ -25,15 +25,17 @@  S = "${UNPACKDIR}/${DEBIAN_PGK_NAME}-${DEBIAN_PGK_VERSION}"
 
 EXTRA_OEMAKE = 'CC="${CC}" LD="${CC}" AR="${AR}" OBJCOPY="${OBJCOPY}"'
 
+inherit siteinfo
+
 do_compile() {
-    oe_runmake -C code/obj.linux64 OSTYPE=linux64 ENCRYPTION=yes COPTIONS="${CFLAGS} ${CPPFLAGS}" LDOPTIONS="${LDFLAGS}"
+    oe_runmake -C code/obj.linux${SITEINFO_BITS} OSTYPE=linux${SITEINFO_BITS} ENCRYPTION=yes COPTIONS="${CFLAGS} ${CPPFLAGS}" LDOPTIONS="${LDFLAGS}"
     oe_runmake -C add-ons/hab_csf_parser COPTS="${CFLAGS} ${CPPFLAGS} ${LDFLAGS}"
 }
 
 do_install () {
     install -d ${D}${bindir}
-    install -m 755 ${S}/code/obj.linux64/cst ${D}${bindir}/
-    install -m 755 ${S}/code/obj.linux64/srktool ${D}${bindir}
+    install -m 755 ${S}/code/obj.linux${SITEINFO_BITS}/cst ${D}${bindir}/
+    install -m 755 ${S}/code/obj.linux${SITEINFO_BITS}/srktool ${D}${bindir}
     install -m 755 ${S}/add-ons/hab_csf_parser/csf_parser ${D}${bindir}
 }