diff mbox series

[meta-oe] uftrace: fix issue that actually not install

Message ID 20250730081937.1572-1-liuyd.fnst@fujitsu.com
State Under Review
Headers show
Series [meta-oe] uftrace: fix issue that actually not install | expand

Commit Message

Liu Yiding July 30, 2025, 8:19 a.m. UTC
1. "oe_runmake DESTDIR=${D} install" will actually install to ${D},
"oe_runmake DESTDIR=${D}" will skip install, ${D} is empty

2. fix issue that:
| ERROR: uftrace-0.18-r0 do_package: QA Issue: File '/usr/lib/libelf.so' from
| uftrace was already stripped, this will prevent future debugging! [already-stripped]

we have set to use sysroot libelf in do_configure with "--with-elfutils=${STAGING_EXECPREFIXDIR}",
here remove uftrace build libelf

Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
 meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Khem Raj July 30, 2025, 3:07 p.m. UTC | #1
On Wed, Jul 30, 2025 at 1:19 AM Liu Yiding <liuyd.fnst@fujitsu.com> wrote:
>
> 1. "oe_runmake DESTDIR=${D} install" will actually install to ${D},
> "oe_runmake DESTDIR=${D}" will skip install, ${D} is empty
>
> 2. fix issue that:
> | ERROR: uftrace-0.18-r0 do_package: QA Issue: File '/usr/lib/libelf.so' from
> | uftrace was already stripped, this will prevent future debugging! [already-stripped]
>
> we have set to use sysroot libelf in do_configure with "--with-elfutils=${STAGING_EXECPREFIXDIR}",
> here remove uftrace build libelf
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
>  meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb b/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb
> index 7ba2dcadc9..6764557f37 100644
> --- a/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb
> +++ b/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb
> @@ -41,7 +41,8 @@ do_compile() {
>  }
>
>  do_install() {
> -    oe_runmake DESTDIR=${D}
> +    oe_runmake DESTDIR=${D} install
> +    rm -f ${D}/usr/lib/libelf.so*

Thanks, it should be using ${libdir} instead of /usr/lib here which I have fixed
locally.

>  }
>
>  FILES_SOLIBSDEV = ""
> --
> 2.43.0
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb b/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb
index 7ba2dcadc9..6764557f37 100644
--- a/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb
+++ b/meta-oe/recipes-devtools/uftrace/uftrace_0.18.bb
@@ -41,7 +41,8 @@  do_compile() {
 }
 
 do_install() {
-    oe_runmake DESTDIR=${D}
+    oe_runmake DESTDIR=${D} install
+    rm -f ${D}/usr/lib/libelf.so*
 }
 
 FILES_SOLIBSDEV = ""