diff mbox series

[meta-openembedded,14/20] ettercap: Add patch for CMake 4+ compatibility

Message ID 20250709173054.605430-14-alperyasinak1@gmail.com
State Under Review
Headers show
Series [meta-openembedded,01/20] librdkafka: Upgrade 1.8.2 -> 2.11.0 to allow CMake 4+ compatibility | expand

Commit Message

Alper Ak July 9, 2025, 5:30 p.m. UTC
Fix:

| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
|   Compatibility with CMake < 3.5 has been removed from CMake.
|
|   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
|   to tell CMake that the project requires at least <min> but has been updated
|   to work with policies introduced by <max> or earlier.
|
|   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
|
|
| -- Configuring incomplete, errors occurred!

Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
 .../0002-allow-build-with-cmake-4.patch       | 54 +++++++++++++++++++
 .../ettercap/ettercap_0.8.3.1.bb              |  4 +-
 2 files changed, 56 insertions(+), 2 deletions(-)
 create mode 100644 meta-networking/recipes-support/ettercap/ettercap/0002-allow-build-with-cmake-4.patch
diff mbox series

Patch

diff --git a/meta-networking/recipes-support/ettercap/ettercap/0002-allow-build-with-cmake-4.patch b/meta-networking/recipes-support/ettercap/ettercap/0002-allow-build-with-cmake-4.patch
new file mode 100644
index 0000000000..70e48f7d9e
--- /dev/null
+++ b/meta-networking/recipes-support/ettercap/ettercap/0002-allow-build-with-cmake-4.patch
@@ -0,0 +1,54 @@ 
+From 337e790d4fc8fed00a4f62047de1bc702f06105e Mon Sep 17 00:00:00 2001
+From: Alper Ak <alperyasinak1@gmail.com>
+Date: Wed, 9 Jul 2025 14:15:32 +0300
+Subject: [PATCH] cmake: Set minimum required version to 3.5 for CMake 4+
+ compatibility
+
+Fix:
+
+| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
+|   Compatibility with CMake < 3.5 has been removed from CMake.
+|
+|   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
+|   to tell CMake that the project requires at least <min> but has been updated
+|   to work with policies introduced by <max> or earlier.
+|
+|   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
+|
+|
+| -- Configuring incomplete, errors occurred!
+
+Upstream-Status: Submitted [https://github.com/Ettercap/ettercap/pull/1279]
+
+Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
+---
+ CMakeLists.txt               | 2 +-
+ cmake/Modules/FindGTK3.cmake | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 1c08875a..600bd9f4 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-cmake_minimum_required(VERSION 2.8)
++cmake_minimum_required(VERSION 3.5)
+ project(ettercap C)
+ 
+ set(VERSION "0.8.3.1")
+diff --git a/cmake/Modules/FindGTK3.cmake b/cmake/Modules/FindGTK3.cmake
+index e07a4e90..f37fee1c 100644
+--- a/cmake/Modules/FindGTK3.cmake
++++ b/cmake/Modules/FindGTK3.cmake
+@@ -351,7 +351,7 @@ endif()
+ #
+ if(GTK3_FIND_VERSION)
+   if(NOT DEFINED CMAKE_MINIMUM_REQUIRED_VERSION)
+-    cmake_minimum_required(VERSION 2.6.2)
++    cmake_minimum_required(VERSION 3.5)
+   endif()
+   set(GTK3_FAILED_VERSION_CHECK true)
+   if(GTK3_DEBUG)
+-- 
+2.43.0
+
diff --git a/meta-networking/recipes-support/ettercap/ettercap_0.8.3.1.bb b/meta-networking/recipes-support/ettercap/ettercap_0.8.3.1.bb
index d5dc10a889..027b6dd190 100644
--- a/meta-networking/recipes-support/ettercap/ettercap_0.8.3.1.bb
+++ b/meta-networking/recipes-support/ettercap/ettercap_0.8.3.1.bb
@@ -21,11 +21,11 @@  DEPENDS += "ethtool \
 RDEPENDS:${PN} += "bash ethtool libgcc"
 
 SRC_URI = "gitsm://github.com/Ettercap/ettercap;branch=master;protocol=https \
-           file://0001-sslstrip-Enhance-the-libcurl-version-check-to-consid.patch"
+           file://0001-sslstrip-Enhance-the-libcurl-version-check-to-consid.patch \
+           file://0002-allow-build-with-cmake-4.patch"
 
 SRCREV = "7281fbddb7da7478beb1d21e3cb105fff3778b31"
 
-
 EXTRA_OECMAKE = " \
     -DCMAKE_SKIP_RPATH=TRUE \
     -DBUNDLED_LIBS=ON \