diff mbox series

[meta-oe] android-tools: Drop workaround flag for incompatible pointer types

Message ID 20250623155621.173813-1-alperyasinak1@gmail.com
State New
Headers show
Series [meta-oe] android-tools: Drop workaround flag for incompatible pointer types | expand

Commit Message

Alper Ak June 23, 2025, 3:56 p.m. UTC 
- The build completes successfully without adding the flag. In fact, the flag is never actually added. Because:

If we use the += operator to add flags to the CC variable early in the recipe, changes will be overwritten because BitBake applies class assignments to CC at a later stage, which replaces any previous modifications. We should use :append to ensure that additions are applied to the final value, after all assignments from core classes have been processed.

- Additionally, the standard way to pass compiler flags in C projects is to use CFLAGS.

Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
 .../android-tools/android-tools_5.1.1.r37.bb                 | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb b/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb
index ff83b6c2ee..c04a1ef8c4 100644
--- a/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb
+++ b/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb
@@ -187,8 +187,3 @@  FILES:${PN}-fstools = "\
 "
 
 BBCLASSEXTEND = "native"
-
-# http://errors.yoctoproject.org/Errors/Details/766881/
-# android-tools/5.1.1.r37/git/system/core/adb/adb_auth_host.c:86:23: error: passing argument 2 of 'RSA_get0_key' from incompatible pointer type [-Wincompatible-pointer-types]
-# android-tools/5.1.1.r37/git/system/core/adb/adb_auth_host.c:86:27: error: passing argument 3 of 'RSA_get0_key' from incompatible pointer type [-Wincompatible-pointer-types]
-CC += "-Wno-error=incompatible-pointer-types"