| Message ID | 20250521151544.3831931-1-f_l_k@t-online.de |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe] libsdl2-compat: use nonarch_libdir | expand |
On Wed, May 21, 2025 at 8:15 AM Markus Volk via lists.openembedded.org <f_l_k=t-online.de@lists.openembedded.org> wrote: > > Use nonarch_libdir for do_install:append > > This should prevent a possible multilib issue > > Signed-off-by: Markus Volk <f_l_k@t-online.de> > --- > meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb > index 7e3a06f34f..1d46ebf511 100644 > --- a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb > +++ b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb > @@ -23,7 +23,7 @@ inherit cmake pkgconfig upstream-version-is-even features_check > REQUIRED_DISTRO_FEATURES = "opengl x11" > > do_install:append() { > - mv ${D}${libdir}/pkgconfig/sdl2-compat.pc ${D}${libdir}/pkgconfig/sdl2.pc > + mv ${D}${nonarch_libdir}/pkgconfig/sdl2-compat.pc ${D}${nonarch_libdir}/pkgconfig/sdl2.pc > } Can you check if sdl2.pc is identical in both multilib builds ? > > FILES:${PN} += "${datadir}/licenses" > -- > 2.49.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#117573): https://lists.openembedded.org/g/openembedded-devel/message/117573 > Mute This Topic: https://lists.openembedded.org/mt/113230803/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Thu, May 22 2025 at 07:30:27 -07:00:00, Khem Raj
<raj.khem@gmail.com> wrote:
> Can you check if sdl2.pc is identical in both multilib builds ?
Checked it. This patch seems pointless and can be ignored
diff --git a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb index 7e3a06f34f..1d46ebf511 100644 --- a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb +++ b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb @@ -23,7 +23,7 @@ inherit cmake pkgconfig upstream-version-is-even features_check REQUIRED_DISTRO_FEATURES = "opengl x11" do_install:append() { - mv ${D}${libdir}/pkgconfig/sdl2-compat.pc ${D}${libdir}/pkgconfig/sdl2.pc + mv ${D}${nonarch_libdir}/pkgconfig/sdl2-compat.pc ${D}${nonarch_libdir}/pkgconfig/sdl2.pc } FILES:${PN} += "${datadir}/licenses"
Use nonarch_libdir for do_install:append This should prevent a possible multilib issue Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)