diff mbox series

[meta-oe,scarthgap] lmsensors: Fix build without sensord

Message ID 20250505095620.14907-1-l.anderweit@phytec.de
State New
Headers show
Series [meta-oe,scarthgap] lmsensors: Fix build without sensord | expand

Commit Message

Leonard Anderweit May 5, 2025, 9:56 a.m. UTC 
When building with sensord disabled (PACKAGECONFIG = ""), do_install
would fail because it tried to build sensord which was skiped in
do_compile.
Error log:
make: *** No rule to make target 'rrd.h', needed by 'prog/sensord/rrd.rd'. Stop.

Avoid building sensord in do_install by explicitly setting PROG_EXTRA.

(master rev: fc88c96c4e40d9dbc6097c4679ac79ed55356730)

Fixes: 86b20b84ec27 (lmsensors: Clean stale files for sensord to avoid
incorrect GCC header dependencies)

Signed-off-by: Leonard Anderweit <l.anderweit@phytec.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Alexander Stein May 15, 2025, 2:52 p.m. UTC | #1 
Am Montag, 5. Mai 2025, 11:56:20 CEST schrieb Leonard Anderweit via lists.openembedded.org:
> When building with sensord disabled (PACKAGECONFIG = ""), do_install
> would fail because it tried to build sensord which was skiped in

small typo: skiped -> skipped

> do_compile.
> Error log:
> make: *** No rule to make target 'rrd.h', needed by 'prog/sensord/rrd.rd'. Stop.
> 
> Avoid building sensord in do_install by explicitly setting PROG_EXTRA.
> 
> (master rev: fc88c96c4e40d9dbc6097c4679ac79ed55356730)
> 
> Fixes: 86b20b84ec27 (lmsensors: Clean stale files for sensord to avoid
> incorrect GCC header dependencies)
> 
> Signed-off-by: Leonard Anderweit <l.anderweit@phytec.de>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Otherwise this fixes the build issue
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> ---
>  meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> index e3186132c76c..6e4cf29f479f 100644
> --- a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> +++ b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> @@ -48,7 +48,8 @@ S = "${WORKDIR}/git"
>  EXTRA_OEMAKE = 'EXLDFLAGS="${LDFLAGS}" \
>          MACHINE=${TARGET_ARCH} PREFIX=${prefix} MANDIR=${mandir} \
>          LIBDIR=${libdir} \
> -        CC="${CC}" AR="${AR}"'
> +        CC="${CC}" AR="${AR}" \
> +        PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"'
>  
>  do_configure:prepend() {
>      sed -i -e 's:^#\(PROG_EXTRA\):\1:' ${S}/Makefile
> @@ -59,7 +60,7 @@ do_compile() {
>      sed -i -e 's/\$(LIBDIR)$/\$(LIBDIR) \$(LDFLAGS)/g' ${S}/Makefile
>      sed -i -e 's/\$(LIBSHSONAME) -o/$(LIBSHSONAME) \$(LDFLAGS) -o/g' \
>                  ${S}/lib/Module.mk
> -    oe_runmake user PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"
> +    oe_runmake user
>  }
>  
>  do_install() {
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
index e3186132c76c..6e4cf29f479f 100644
--- a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
+++ b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
@@ -48,7 +48,8 @@  S = "${WORKDIR}/git"
 EXTRA_OEMAKE = 'EXLDFLAGS="${LDFLAGS}" \
         MACHINE=${TARGET_ARCH} PREFIX=${prefix} MANDIR=${mandir} \
         LIBDIR=${libdir} \
-        CC="${CC}" AR="${AR}"'
+        CC="${CC}" AR="${AR}" \
+        PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"'
 
 do_configure:prepend() {
     sed -i -e 's:^#\(PROG_EXTRA\):\1:' ${S}/Makefile
@@ -59,7 +60,7 @@  do_compile() {
     sed -i -e 's/\$(LIBDIR)$/\$(LIBDIR) \$(LDFLAGS)/g' ${S}/Makefile
     sed -i -e 's/\$(LIBSHSONAME) -o/$(LIBSHSONAME) \$(LDFLAGS) -o/g' \
                 ${S}/lib/Module.mk
-    oe_runmake user PROG_EXTRA="sensors ${PACKAGECONFIG_CONFARGS}"
+    oe_runmake user
 }
 
 do_install() {