| Message ID | 20250413104350.34628-1-nguyenthaithuanalg@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe] Propose a contribution: "simplelog-topic". | expand |
Some initial thoughts: 1. Could you please add some description in the commit message, what is it, and the benefits or reason of adding it to the layer? 2. Please remove the unneeded comments from the recipe. Also, add some more standard metadata, like SUMMARY, DESCRIPTION or HOMEPAGE (see some standard details of the other recipes) 3. There is an existing folder-hierachy for the recipes, e.g there is recipes-support, recipes-core... please move the recipe to the corresponding folder (instead of recipes-libsimplelog) 4. For the commit summary, please use "RECIPENAME: summary" format. E.g. "libsimplelog: add recipe". See the other commits for examples. On 4/13/25 12:43, Thuận Nguyễn-Thái via lists.openembedded.org wrote: > --- > .../libsimplelog/libsimplelog_git.bb | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 meta-oe/recipes-libsimplelog/libsimplelog/libsimplelog_git.bb > > diff --git a/meta-oe/recipes-libsimplelog/libsimplelog/libsimplelog_git.bb b/meta-oe/recipes-libsimplelog/libsimplelog/libsimplelog_git.bb > new file mode 100644 > index 000000000..8c403ed88 > --- /dev/null > +++ b/meta-oe/recipes-libsimplelog/libsimplelog/libsimplelog_git.bb > @@ -0,0 +1,24 @@ > +# Recipe created by recipetool > +# This is the basis of a recipe and may need further editing in order to be fully functional. > +# (Feel free to remove these comments when editing.) > + > +# WARNING: the following LICENSE and LIC_FILES_CHKSUM values are best guesses - it is > +# your responsibility to verify that the values are complete and correct. > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=22cdd382a6275cb4c2e75c517952ac7c" > + > +SRC_URI = "git://github.com/thuanalg/simplelog-topic.git;branch=main;protocol=https" > + > +# Modify these as desired > +PV = "1.0+git" > +SRCREV = "ff30ba71807db1d7e1962dd014c2bb0a060572a3" > +#ff30ba71807db1d7e1962dd014c2bb0a060572a3 > + > +S = "${WORKDIR}/git" > + > +inherit cmake > + > +# Specify any options you want to pass to cmake using EXTRA_OECMAKE: > +EXTRA_OECMAKE += "-DUNIX_LINUX=1" > + > + > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#116829): https://lists.openembedded.org/g/openembedded-devel/message/116829 > Mute This Topic: https://lists.openembedded.org/mt/112239337/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-oe/recipes-libsimplelog/libsimplelog/libsimplelog_git.bb b/meta-oe/recipes-libsimplelog/libsimplelog/libsimplelog_git.bb new file mode 100644 index 000000000..8c403ed88 --- /dev/null +++ b/meta-oe/recipes-libsimplelog/libsimplelog/libsimplelog_git.bb @@ -0,0 +1,24 @@ +# Recipe created by recipetool +# This is the basis of a recipe and may need further editing in order to be fully functional. +# (Feel free to remove these comments when editing.) + +# WARNING: the following LICENSE and LIC_FILES_CHKSUM values are best guesses - it is +# your responsibility to verify that the values are complete and correct. +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=22cdd382a6275cb4c2e75c517952ac7c" + +SRC_URI = "git://github.com/thuanalg/simplelog-topic.git;branch=main;protocol=https" + +# Modify these as desired +PV = "1.0+git" +SRCREV = "ff30ba71807db1d7e1962dd014c2bb0a060572a3" +#ff30ba71807db1d7e1962dd014c2bb0a060572a3 + +S = "${WORKDIR}/git" + +inherit cmake + +# Specify any options you want to pass to cmake using EXTRA_OECMAKE: +EXTRA_OECMAKE += "-DUNIX_LINUX=1" + +