diff mbox series

[RFC,meta-oe] pmtools: remove recipes

Message ID 20250410055958.2998865-1-changqing.li@windriver.com
State Accepted
Headers show
Series [RFC,meta-oe] pmtools: remove recipes | expand

Commit Message

Changqing Li April 10, 2025, 5:59 a.m. UTC
From: Changqing Li <changqing.li@windriver.com>

Remove this not maintained recipe. The latest commit of pmtools is 12
years ago. And it generates 3 binaries: acpidump/acpixtract/madt, but
there is a recipe acpica in oe-core provides acpidump/acpixtract, and
according to README.madt, it is hacked out from Linux kernel, if someone
requests it, mayb user can add one recipe similar like turbostat.

[1] https://github.com/anyc/pmtools/tree/master

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 .../packagegroups/packagegroup-meta-oe.bb     |  4 +-
 ...o-dynamic-buffer-for-huge-ACPI-table.patch | 82 -------------------
 .../recipes-devtools/pmtools/pmtools_git.bb   | 34 --------
 3 files changed, 2 insertions(+), 118 deletions(-)
 delete mode 100644 meta-oe/recipes-devtools/pmtools/pmtools/pmtools-switch-to-dynamic-buffer-for-huge-ACPI-table.patch
 delete mode 100644 meta-oe/recipes-devtools/pmtools/pmtools_git.bb
diff mbox series

Patch

diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb b/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
index ebb0f0f810..d3d2f05c47 100644
--- a/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
+++ b/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
@@ -294,8 +294,8 @@  RDEPENDS:packagegroup-meta-oe-devtools = "\
     yajl \
     yasm \
 "
-RDEPENDS:packagegroup-meta-oe-devtools:append:x86 = " cpuid msr-tools pahole pmtools"
-RDEPENDS:packagegroup-meta-oe-devtools:append:x86-64 = " cpuid msr-tools pahole pcimem pmtools"
+RDEPENDS:packagegroup-meta-oe-devtools:append:x86 = " cpuid msr-tools pahole"
+RDEPENDS:packagegroup-meta-oe-devtools:append:x86-64 = " cpuid msr-tools pahole pcimem"
 RDEPENDS:packagegroup-meta-oe-devtools:append:riscv64 = " pcimem"
 RDEPENDS:packagegroup-meta-oe-devtools:append:arm = " pcimem"
 RDEPENDS:packagegroup-meta-oe-devtools:append:aarch64 = " pahole pcimem"
diff --git a/meta-oe/recipes-devtools/pmtools/pmtools/pmtools-switch-to-dynamic-buffer-for-huge-ACPI-table.patch b/meta-oe/recipes-devtools/pmtools/pmtools/pmtools-switch-to-dynamic-buffer-for-huge-ACPI-table.patch
deleted file mode 100644
index 3be18986fc..0000000000
--- a/meta-oe/recipes-devtools/pmtools/pmtools/pmtools-switch-to-dynamic-buffer-for-huge-ACPI-table.patch
+++ /dev/null
@@ -1,82 +0,0 @@ 
-From 03a886252f6555d6b0af76b654e76459642b89da Mon Sep 17 00:00:00 2001
-From: Yunguo Wei <yunguo.wei@windriver.com>
-Date: Tue, 3 Dec 2013 18:12:50 +0800
-Subject: [PATCH] pmtools: switch to dynamic buffer for huge ACPI tables
-
-For servers like Canoe Pass or Thunder Ridge, there are much more
-entries in ACPI table, so original 1K buffer is insufficient.
-
-We switch to dynamic buffer on this situation.
-
-Signed-off-by: Yunguo Wei <yunguo.wei@windriver.com>
-
-
-Upstream-Status: Pending
-
-Signed-off-by: Kai Kang <kai.kang@windriver.com>
----
- madt/madt.c | 18 +++++++++++++++++-
- 1 file changed, 17 insertions(+), 1 deletion(-)
-
---- a/madt/madt.c
-+++ b/madt/madt.c
-@@ -34,14 +34,16 @@ typedef unsigned long long u64;
- //#include <sys/mman.h>
- #include <stdio.h> // fread
- #include <stdlib.h> // malloc
-+#include <string.h> // memset/memcpy
- 
- #include "./tables.c"
- 
- int verbose = 0;
- /*
--/* read standard input
-+ * read standard input
-  * write decoded madt to standard output
-  */
-+size_t
- get_next_entry(acpi_table_entry_header * entry_header)
- {
- 	size_t retval;
-@@ -51,9 +53,11 @@ get_next_entry(acpi_table_entry_header *
- 	return retval;
- }
- 
--u8	buffer[1024];
- 
--main()
-+u8	buf[1024];
-+u8	*buffer = buf;
-+int
-+main(int argc, char *argv[])
- {
- 	size_t retval;
- 	struct acpi_table_madt *madt_header;
-@@ -75,6 +79,17 @@ main()
- 
- 	if (verbose) printf("header.length %d\n", madt_header->header.length);
- 
-+	/* if 1K buffer is insufficient for acpi table, switch to a larger memory buffer */
-+	if(expected_length > sizeof(buf)) {
-+		buffer = malloc(expected_length);
-+		if (!buffer) {
-+			perror("malloc");
-+			exit(1);
-+		}
-+		memset(buffer, 0, expected_length);
-+		memcpy(buffer, buf, sizeof(struct acpi_table_madt));
-+	}
-+
- 	acpi_table_print((void*)&(buffer[bytes_read]), 0);
- 
- 	bytes_read = sizeof(struct acpi_table_madt);
-@@ -118,6 +133,9 @@ done:
- 		printf("Checksum 0x%x != 0; 0x%x in header ERROR\n", csum,
- 			 madt_header->header.checksum);
- 
-+	if(buffer != buf)
-+		free(buffer);
-+
- 	return 0;
- }
- 
diff --git a/meta-oe/recipes-devtools/pmtools/pmtools_git.bb b/meta-oe/recipes-devtools/pmtools/pmtools_git.bb
deleted file mode 100644
index ad149de12c..0000000000
--- a/meta-oe/recipes-devtools/pmtools/pmtools_git.bb
+++ /dev/null
@@ -1,34 +0,0 @@ 
-DESCRIPTION = "This is a small collection of power management \
-    test and investigation tools"
-HOMEPAGE = "http://lesswatts.org/projects/acpi"
-LICENSE = "GPL-2.0-or-later"
-LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
-
-PV = "20130209+git"
-
-SRC_URI = "git://github.com/anyc/pmtools.git;branch=master;protocol=https \
-    file://pmtools-switch-to-dynamic-buffer-for-huge-ACPI-table.patch \
-"
-SRCREV = "3ebe0e54c54061b4c627236cbe35d820de2e1168"
-
-COMPATIBLE_HOST = "(i.86|x86_64).*-linux"
-
-S = "${WORKDIR}/git"
-
-inherit update-alternatives
-
-ALTERNATIVE_PRIORITY = "90"
-ALTERNATIVE:${PN} = "acpixtract acpidump"
-
-do_configure[noexec] = "1"
-do_compile() {
-    oe_runmake
-}
-
-do_install() {
-    install -d ${D}${bindir} ${D}${docdir}
-    install -m 755 ${S}/acpidump/acpidump ${D}${bindir}
-    install -m 755 ${S}/acpixtract/acpixtract ${D}${bindir}
-    install -m 755 ${S}/madt/madt ${D}${bindir}
-    install -m 644 ${S}/README ${D}${docdir}
-}