diff mbox series

valkey: update from 8.0.2 -> 8.1.0

Message ID 20250403204412.1686638-1-Randy.MacLeod@windriver.com
State Accepted
Headers show
Series valkey: update from 8.0.2 -> 8.1.0 | expand

Commit Message

Randy MacLeod April 3, 2025, 8:44 p.m. UTC
From: Randy MacLeod <Randy.MacLeod@windriver.com>

Release notes:
   https://github.com/valkey-io/valkey/releases/tag/8.1.0

The license file checksum changed because upstream added the line:
   SPDX-License-Identifier: BSD-3-Clause
Add OECONF to avoid build-time checks for strcase[str|cmp], both of
which have been in glibc and musl for > 10 years so it's sensible to
default to yes.

Adjust the patches using devtool and manually munge the Upstream-Status-es.

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb}    | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
 rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%)

Comments

Khem Raj April 3, 2025, 9:03 p.m. UTC | #1
On Thu, Apr 3, 2025 at 1:44 PM Randy MacLeod via lists.openembedded.org
<randy.macleod=windriver.com@lists.openembedded.org> wrote:

> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>
> Release notes:
>    https://github.com/valkey-io/valkey/releases/tag/8.1.0
>
> The license file checksum changed because upstream added the line:
>    SPDX-License-Identifier: BSD-3-Clause
> Add OECONF to avoid build-time checks for strcase[str|cmp], both of
> which have been in glibc and musl for > 10 years so it's sensible to
> default to yes.


Why do they fail I wonder

>
>
> Adjust the patches using devtool and manually munge the Upstream-Status-es.
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
>  .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb}    | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>  rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%)
>
> diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb
> b/meta-oe/recipes-support/nano/nano_8.4.bb
> similarity index 75%
> rename from meta-oe/recipes-support/nano/nano_8.3.bb
> rename to meta-oe/recipes-support/nano/nano_8.4.bb
> index d1af89ef8d..1aae49d3b6 100644
> --- a/meta-oe/recipes-support/nano/nano_8.3.bb
> +++ b/meta-oe/recipes-support/nano/nano_8.4.bb
> @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base"
>  PV_MAJOR = "${@d.getVar('PV').split('.')[0]}"
>
>  SRC_URI = "https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz"
> -SRC_URI[sha256sum] =
> "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e"
> +SRC_URI[sha256sum] =
> "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d"
>
>  UPSTREAM_CHECK_URI = "https://ftp.gnu.org/gnu/nano"
>
>  inherit autotools gettext pkgconfig
>
> +EXTRA_OECONF = " \
> +    ac_cv_func_strcasestr=yes \
> +    gl_cv_func_strcasecmp_works=yes \
> +    ac_cv_func_strcasecmp=yes \
> +"
> +
> +
>  PACKAGECONFIG[tiny] = "--enable-tiny,"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#116546):
> https://lists.openembedded.org/g/openembedded-devel/message/116546
> Mute This Topic: https://lists.openembedded.org/mt/112047294/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Randy MacLeod April 4, 2025, 12:33 a.m. UTC | #2
On 2025-04-03 5:03 p.m., Khem Raj wrote:
>
>
> On Thu, Apr 3, 2025 at 1:44 PM Randy MacLeod via 
> lists.openembedded.org 
> <https://urldefense.com/v3/__http://lists.openembedded.org__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaXjzbMJQg$> 
> <randy.macleod=windriver.com@lists.openembedded.org> wrote:
>
>     From: Randy MacLeod <Randy.MacLeod@windriver.com>
>
>     Release notes:
>     https://github.com/valkey-io/valkey/releases/tag/8.1.0
>     <https://urldefense.com/v3/__https://github.com/valkey-io/valkey/releases/tag/8.1.0__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaXjTQ4EYA$>
>
>     The license file checksum changed because upstream added the line:
>        SPDX-License-Identifier: BSD-3-Clause
>     Add OECONF to avoid build-time checks for strcase[str|cmp], both of
>     which have been in glibc and musl for > 10 years so it's sensible to
>     default to yes.
>
>
> Why do they fail I wonder

I dug a bit but wanted to get the package update in.

It's not a key package so whatever.


ALSO: I need to resend with a corrected subject line!

It's nano, not valkey - copy pasta!!!

v2 sent.

../Randy


>
>
>     Adjust the patches using devtool and manually munge the
>     Upstream-Status-es.
>
>     Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>     ---
>      .../recipes-support/nano/{nano_8.3.bb
>     <https://urldefense.com/v3/__http://nano_8.3.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWue17a0g$>
>     => nano_8.4.bb
>     <https://urldefense.com/v3/__http://nano_8.4.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaX6U5-bFQ$>}
>       | 9 ++++++++-
>      1 file changed, 8 insertions(+), 1 deletion(-)
>      rename meta-oe/recipes-support/nano/{nano_8.3.bb
>     <https://urldefense.com/v3/__http://nano_8.3.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWue17a0g$>
>     => nano_8.4.bb
>     <https://urldefense.com/v3/__http://nano_8.4.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaX6U5-bFQ$>}
>     (75%)
>
>     diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb
>     <https://urldefense.com/v3/__http://nano_8.3.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWue17a0g$>
>     b/meta-oe/recipes-support/nano/nano_8.4.bb
>     <https://urldefense.com/v3/__http://nano_8.4.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaX6U5-bFQ$>
>     similarity index 75%
>     rename from meta-oe/recipes-support/nano/nano_8.3.bb
>     <https://urldefense.com/v3/__http://nano_8.3.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWue17a0g$>
>     rename to meta-oe/recipes-support/nano/nano_8.4.bb
>     <https://urldefense.com/v3/__http://nano_8.4.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaX6U5-bFQ$>
>     index d1af89ef8d..1aae49d3b6 100644
>     --- a/meta-oe/recipes-support/nano/nano_8.3.bb
>     <https://urldefense.com/v3/__http://nano_8.3.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWue17a0g$>
>     +++ b/meta-oe/recipes-support/nano/nano_8.4.bb
>     <https://urldefense.com/v3/__http://nano_8.4.bb__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaX6U5-bFQ$>
>     @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base"
>      PV_MAJOR = "${@d.getVar('PV').split('.')[0]}"
>
>      SRC_URI =
>     "https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz
>     <https://urldefense.com/v3/__https://nano-editor.org/dist/v$*7BPV_MAJOR*7D/nano-$*7BPV*7D.tar.xz__;JSUlJQ!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWZXassYg$>"
>     -SRC_URI[sha256sum] =
>     "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e"
>     +SRC_URI[sha256sum] =
>     "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d"
>
>      UPSTREAM_CHECK_URI = "https://ftp.gnu.org/gnu/nano
>     <https://urldefense.com/v3/__https://ftp.gnu.org/gnu/nano__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWTSqt3UA$>"
>
>      inherit autotools gettext pkgconfig
>
>     +EXTRA_OECONF = " \
>     +    ac_cv_func_strcasestr=yes \
>     +    gl_cv_func_strcasecmp_works=yes \
>     +    ac_cv_func_strcasecmp=yes \
>     +"
>     +
>     +
>      PACKAGECONFIG[tiny] = "--enable-tiny,"
>     -- 
>     2.34.1
>
>
>     -=-=-=-=-=-=-=-=-=-=-=-
>     Links: You receive all messages sent to this group.
>     View/Reply Online (#116546):
>     https://lists.openembedded.org/g/openembedded-devel/message/116546
>     <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-devel/message/116546__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaVcDBLDnQ$>
>     Mute This Topic:
>     https://lists.openembedded.org/mt/112047294/1997914
>     <https://urldefense.com/v3/__https://lists.openembedded.org/mt/112047294/1997914__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaWAaXj1zA$>
>     Group Owner: openembedded-devel+owner@lists.openembedded.org
>     <mailto:openembedded-devel%2Bowner@lists.openembedded.org>
>     Unsubscribe:
>     https://lists.openembedded.org/g/openembedded-devel/unsub
>     <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-devel/unsub__;!!AjveYdw8EvQ!eInicRMNhjFgfQKzcuSHuc1F7NDtnyYvxuxHuj-AFqBVGuBTHPt4zA8cD2SioWhdFiA-Tg7KKX3InaXrmtBMTA$>
>     [raj.khem@gmail.com]
>     -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj April 4, 2025, 12:56 a.m. UTC | #3
On Thu, Apr 3, 2025 at 5:33 PM Randy MacLeod
<randy.macleod@windriver.com> wrote:
>
> On 2025-04-03 5:03 p.m., Khem Raj wrote:
>
>
>
> On Thu, Apr 3, 2025 at 1:44 PM Randy MacLeod via lists.openembedded.org <randy.macleod=windriver.com@lists.openembedded.org> wrote:
>>
>> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>>
>> Release notes:
>>    https://github.com/valkey-io/valkey/releases/tag/8.1.0
>>
>> The license file checksum changed because upstream added the line:
>>    SPDX-License-Identifier: BSD-3-Clause
>> Add OECONF to avoid build-time checks for strcase[str|cmp], both of
>> which have been in glibc and musl for > 10 years so it's sensible to
>> default to yes.
>
>
> Why do they fail I wonder
>
> I dug a bit but wanted to get the package update in.

I looked a bit and it seems that gnulib got updated
https://git.savannah.gnu.org/cgit/nano.git/commit/?id=c7033324a9e31d7b00454db04496880e889d32f0

which perhaps added new logic which is not working in cross compile maybe ?



>
> It's not a key package so whatever.
>
>
> ALSO: I need to resend with a corrected subject line!
>
> It's nano, not valkey - copy pasta!!!
>
> v2 sent.
>
> ../Randy
>
>
>>
>>
>> Adjust the patches using devtool and manually munge the Upstream-Status-es.
>>
>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>> ---
>>  .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb}    | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>  rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%)
>>
>> diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb
>> similarity index 75%
>> rename from meta-oe/recipes-support/nano/nano_8.3.bb
>> rename to meta-oe/recipes-support/nano/nano_8.4.bb
>> index d1af89ef8d..1aae49d3b6 100644
>> --- a/meta-oe/recipes-support/nano/nano_8.3.bb
>> +++ b/meta-oe/recipes-support/nano/nano_8.4.bb
>> @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base"
>>  PV_MAJOR = "${@d.getVar('PV').split('.')[0]}"
>>
>>  SRC_URI = "https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz"
>> -SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e"
>> +SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d"
>>
>>  UPSTREAM_CHECK_URI = "https://ftp.gnu.org/gnu/nano"
>>
>>  inherit autotools gettext pkgconfig
>>
>> +EXTRA_OECONF = " \
>> +    ac_cv_func_strcasestr=yes \
>> +    gl_cv_func_strcasecmp_works=yes \
>> +    ac_cv_func_strcasecmp=yes \
>> +"
>> +
>> +
>>  PACKAGECONFIG[tiny] = "--enable-tiny,"
>> --
>> 2.34.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#116546): https://lists.openembedded.org/g/openembedded-devel/message/116546
>> Mute This Topic: https://lists.openembedded.org/mt/112047294/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>
> --
> # Randy MacLeod
> # Wind River Linux
Randy MacLeod April 4, 2025, 2:39 p.m. UTC | #4
On 2025-04-03 8:56 p.m., Khem Raj wrote:
> On Thu, Apr 3, 2025 at 5:33 PM Randy MacLeod
> <randy.macleod@windriver.com> wrote:
>> On 2025-04-03 5:03 p.m., Khem Raj wrote:
>>
>>
>>
>> On Thu, Apr 3, 2025 at 1:44 PM Randy MacLeod via lists.openembedded.org<randy.macleod=windriver.com@lists.openembedded.org> wrote:
>>> From: Randy MacLeod<Randy.MacLeod@windriver.com>
>>>
>>> Release notes:
>>>     https://github.com/valkey-io/valkey/releases/tag/8.1.0
>>>
>>> The license file checksum changed because upstream added the line:
>>>     SPDX-License-Identifier: BSD-3-Clause
>>> Add OECONF to avoid build-time checks for strcase[str|cmp], both of
>>> which have been in glibc and musl for > 10 years so it's sensible to
>>> default to yes.
>> Why do they fail I wonder
>>
>> I dug a bit but wanted to get the package update in.
> I looked a bit and it seems that gnulib got updated
> https://git.savannah.gnu.org/cgit/nano.git/commit/?id=c7033324a9e31d7b00454db04496880e889d32f0
Thanks.
>
> which perhaps added new logic which is not working in cross compile maybe ?

Lots of strcase* changes:

❯ gl --grep strcase 
4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3..f1daedcb4c6c653dfc2936847dfe55f5a076d94b
706178a93b   2025-02-21   getlocalename_l-simple: New module.
e21236c305   2025-02-20   *_l: Fix mistake.
439b7f4de8   2025-02-17   strcasecmp, strncasecmp: Fix compilation error 
on MSVC.
9b269e666a   2025-02-16   strcasecmp_l: Add tests.
6fafa36c51   2025-02-16   strcasecmp_l: New module.
a8fa6e6314   2025-02-16   strcasecmp, strncasecmp: Work around Solaris, 
Cygwin bug, part 3.
ff91cd3ce3   2025-02-16   strncasecmp: Work around Solaris, Cygwin bug, 
part 2.
557f0e4958   2025-02-16   strncasecmp: Work around Solaris, Cygwin bug.
fc6bec11ff   2025-02-16   strcasecmp: Add tests.
9980b9e526   2025-02-16   strcasecmp: Work around Solaris, Cygwin bug.
6abed08f2c   2025-02-16   strcasecmp, strncasecmp: Fix header reference.
f656293f0e   2025-02-16   c-strcasecmp, c-strncasecmp: New modules.
c17d70aaae   2025-02-16   strings-h: Don't declare strcasecmp, 
strncasecmp without the module.
b2927d1b1f   2025-02-16   strcasecmp, strncasecmp: New modules.

❯ gl 
4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3..f1daedcb4c6c653dfc2936847dfe55f5a076d94b 
| wc -l
435

❯ gl --grep strcase 
4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3..f1daedcb4c6c653dfc2936847dfe55f5a076d94b 
| wc -l
13

The old commit id was on:
❯ git branch -a --contains 4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3
* master
   remotes/origin/HEAD -> origin/master
   remotes/origin/master
   remotes/origin/stable-202501


I'm busy today but sometime next week,

I'll learn about gnulib, re-work this update and report the problem to 
upstream to gnulib devs if needed..

../Randy


>
>
>
>> It's not a key package so whatever.
>>
>>
>> ALSO: I need to resend with a corrected subject line!
>>
>> It's nano, not valkey - copy pasta!!!
>>
>> v2 sent.
>>
>> ../Randy
>>
>>
>>> Adjust the patches using devtool and manually munge the Upstream-Status-es.
>>>
>>> Signed-off-by: Randy MacLeod<Randy.MacLeod@windriver.com>
>>> ---
>>>   .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb}    | 9 ++++++++-
>>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>>   rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%)
>>>
>>> diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb
>>> similarity index 75%
>>> rename from meta-oe/recipes-support/nano/nano_8.3.bb
>>> rename to meta-oe/recipes-support/nano/nano_8.4.bb
>>> index d1af89ef8d..1aae49d3b6 100644
>>> --- a/meta-oe/recipes-support/nano/nano_8.3.bb
>>> +++ b/meta-oe/recipes-support/nano/nano_8.4.bb
>>> @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base"
>>>   PV_MAJOR ="${@d.getVar('PV').split('.')[0]}"
>>>
>>>   SRC_URI ="https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz"
>>> -SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e"
>>> +SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d"
>>>
>>>   UPSTREAM_CHECK_URI ="https://ftp.gnu.org/gnu/nano"
>>>
>>>   inherit autotools gettext pkgconfig
>>>
>>> +EXTRA_OECONF = " \
>>> +    ac_cv_func_strcasestr=yes \
>>> +    gl_cv_func_strcasecmp_works=yes \
>>> +    ac_cv_func_strcasecmp=yes \
>>> +"
>>> +
>>> +
>>>   PACKAGECONFIG[tiny] = "--enable-tiny,"
>>> --
>>> 2.34.1
>>>
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> View/Reply Online (#116546):https://lists.openembedded.org/g/openembedded-devel/message/116546
>>> Mute This Topic:https://lists.openembedded.org/mt/112047294/1997914
>>> Group Owner:openembedded-devel+owner@lists.openembedded.org
>>> Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>> --
>> # Randy MacLeod
>> # Wind River Linux
Khem Raj April 4, 2025, 3:05 p.m. UTC | #5
On Fri, Apr 4, 2025 at 7:39 AM Randy MacLeod
<randy.macleod@windriver.com> wrote:
>
> On 2025-04-03 8:56 p.m., Khem Raj wrote:
>
> On Thu, Apr 3, 2025 at 5:33 PM Randy MacLeod
> <randy.macleod@windriver.com> wrote:
>
> On 2025-04-03 5:03 p.m., Khem Raj wrote:
>
>
>
> On Thu, Apr 3, 2025 at 1:44 PM Randy MacLeod via lists.openembedded.org <randy.macleod=windriver.com@lists.openembedded.org> wrote:
>
> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>
> Release notes:
>    https://github.com/valkey-io/valkey/releases/tag/8.1.0
>
> The license file checksum changed because upstream added the line:
>    SPDX-License-Identifier: BSD-3-Clause
> Add OECONF to avoid build-time checks for strcase[str|cmp], both of
> which have been in glibc and musl for > 10 years so it's sensible to
> default to yes.
>
> Why do they fail I wonder
>
> I dug a bit but wanted to get the package update in.
>
> I looked a bit and it seems that gnulib got updated
> https://git.savannah.gnu.org/cgit/nano.git/commit/?id=c7033324a9e31d7b00454db04496880e889d32f0
>
> Thanks.
>
> which perhaps added new logic which is not working in cross compile maybe ?
>
> Lots of strcase* changes:
>
> ❯ gl --grep strcase 4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3..f1daedcb4c6c653dfc2936847dfe55f5a076d94b
> 706178a93b   2025-02-21   getlocalename_l-simple: New module.
> e21236c305   2025-02-20   *_l: Fix mistake.
> 439b7f4de8   2025-02-17   strcasecmp, strncasecmp: Fix compilation error on MSVC.
> 9b269e666a   2025-02-16   strcasecmp_l: Add tests.
> 6fafa36c51   2025-02-16   strcasecmp_l: New module.
> a8fa6e6314   2025-02-16   strcasecmp, strncasecmp: Work around Solaris, Cygwin bug, part 3.
> ff91cd3ce3   2025-02-16   strncasecmp: Work around Solaris, Cygwin bug, part 2.
> 557f0e4958   2025-02-16   strncasecmp: Work around Solaris, Cygwin bug.
> fc6bec11ff   2025-02-16   strcasecmp: Add tests.
> 9980b9e526   2025-02-16   strcasecmp: Work around Solaris, Cygwin bug.
> 6abed08f2c   2025-02-16   strcasecmp, strncasecmp: Fix header reference.
> f656293f0e   2025-02-16   c-strcasecmp, c-strncasecmp: New modules.
> c17d70aaae   2025-02-16   strings-h: Don't declare strcasecmp, strncasecmp without the module.
> b2927d1b1f   2025-02-16   strcasecmp, strncasecmp: New modules.
>
> ❯ gl 4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3..f1daedcb4c6c653dfc2936847dfe55f5a076d94b | wc -l
> 435
>
> ❯ gl --grep strcase 4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3..f1daedcb4c6c653dfc2936847dfe55f5a076d94b | wc -l
> 13
>
> The old commit id was on:
> ❯ git branch -a --contains 4631e9b4d5d3bd5ba42864c7001cf3509a00c7b3
> * master
>   remotes/origin/HEAD -> origin/master
>   remotes/origin/master
>   remotes/origin/stable-202501
>
>
> I'm busy today but sometime next week,
>
> I'll learn about gnulib, re-work this update and report the problem to upstream to gnulib devs if needed..

thanks for following up.

>
> ../Randy
>
>
>
>
>
> It's not a key package so whatever.
>
>
> ALSO: I need to resend with a corrected subject line!
>
> It's nano, not valkey - copy pasta!!!
>
> v2 sent.
>
> ../Randy
>
>
> Adjust the patches using devtool and manually munge the Upstream-Status-es.
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
>  .../recipes-support/nano/{nano_8.3.bb => nano_8.4.bb}    | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>  rename meta-oe/recipes-support/nano/{nano_8.3.bb => nano_8.4.bb} (75%)
>
> diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb
> similarity index 75%
> rename from meta-oe/recipes-support/nano/nano_8.3.bb
> rename to meta-oe/recipes-support/nano/nano_8.4.bb
> index d1af89ef8d..1aae49d3b6 100644
> --- a/meta-oe/recipes-support/nano/nano_8.3.bb
> +++ b/meta-oe/recipes-support/nano/nano_8.4.bb
> @@ -13,10 +13,17 @@ RDEPENDS:${PN} = "ncurses-terminfo-base"
>  PV_MAJOR = "${@d.getVar('PV').split('.')[0]}"
>
>  SRC_URI = "https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz"
> -SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e"
> +SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d"
>
>  UPSTREAM_CHECK_URI = "https://ftp.gnu.org/gnu/nano"
>
>  inherit autotools gettext pkgconfig
>
> +EXTRA_OECONF = " \
> +    ac_cv_func_strcasestr=yes \
> +    gl_cv_func_strcasecmp_works=yes \
> +    ac_cv_func_strcasecmp=yes \
> +"
> +
> +
>  PACKAGECONFIG[tiny] = "--enable-tiny,"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#116546): https://lists.openembedded.org/g/openembedded-devel/message/116546
> Mute This Topic: https://lists.openembedded.org/mt/112047294/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
> --
> # Randy MacLeod
> # Wind River Linux
>
>
> --
> # Randy MacLeod
> # Wind River Linux
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/nano/nano_8.3.bb b/meta-oe/recipes-support/nano/nano_8.4.bb
similarity index 75%
rename from meta-oe/recipes-support/nano/nano_8.3.bb
rename to meta-oe/recipes-support/nano/nano_8.4.bb
index d1af89ef8d..1aae49d3b6 100644
--- a/meta-oe/recipes-support/nano/nano_8.3.bb
+++ b/meta-oe/recipes-support/nano/nano_8.4.bb
@@ -13,10 +13,17 @@  RDEPENDS:${PN} = "ncurses-terminfo-base"
 PV_MAJOR = "${@d.getVar('PV').split('.')[0]}"
 
 SRC_URI = "https://nano-editor.org/dist/v${PV_MAJOR}/nano-${PV}.tar.xz"
-SRC_URI[sha256sum] = "551b717b2e28f7e90f749323686a1b5bbbd84cfa1390604d854a3ca3778f111e"
+SRC_URI[sha256sum] = "5ad29222bbd55624d87ea677928b3106a743114d6c6f9b41f36c97be2a8e628d"
 
 UPSTREAM_CHECK_URI = "https://ftp.gnu.org/gnu/nano"
 
 inherit autotools gettext pkgconfig
 
+EXTRA_OECONF = " \
+    ac_cv_func_strcasestr=yes \
+    gl_cv_func_strcasecmp_works=yes \
+    ac_cv_func_strcasecmp=yes \
+"
+
+
 PACKAGECONFIG[tiny] = "--enable-tiny,"