diff mbox series

[meta-gnome,2/2] celluloid: add recipe

Message ID 20250331062237.8115-2-f_l_k@t-online.de
State Accepted
Headers show
Series [meta-gnome,1/2] mpv: build libmpv by default | expand

Commit Message

Markus Volk March 31, 2025, 6:22 a.m. UTC
Celluloid is a nice and clean gtk4/libadwaita frontend for mpv that improves
usability in gnome

Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 .../celluloid/celluloid_0.2.7.bb              | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb

Comments

Khem Raj March 31, 2025, 9:39 p.m. UTC | #1
On Sun, Mar 30, 2025 at 11:22 PM Markus Volk via
lists.openembedded.org <f_l_k=t-online.de@lists.openembedded.org>
wrote:
>
> Celluloid is a nice and clean gtk4/libadwaita frontend for mpv that improves
> usability in gnome
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  .../celluloid/celluloid_0.2.7.bb              | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
>
> diff --git a/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb b/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
> new file mode 100644
> index 0000000000..d4aada37ff
> --- /dev/null
> +++ b/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
> @@ -0,0 +1,24 @@
> +SUMMARY = "Celluloid is a simple GTK4 frontend for mpv"
> +HOMEPAGE = "https://github.com/celluloid-player/celluloid"
> +LICENSE = "GPL-3.0-only"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=8006d9c814277c1bfc4ca22af94b59ee"
> +
> +DEPENDS = " \
> +    appstream-glib \
> +    appstream-glib-native \
> +    desktop-file-utils-native \
> +    gtk4 \
> +    glib-2.0 \
> +    glib-2.0-native \
> +    libadwaita \
> +    libepoxy \
> +    mpv \

I think due to mpv dependency  here amd mpv needing ffmpeg this needs
something like below

EXCLUDE_FROM_WORLD = "${@bb.utils.contains("LICENSE_FLAGS_ACCEPTED",
"commercial", "0", "1", d)}"


> +"
> +
> +inherit meson gettext mime-xdg pkgconfig gtk-icon-cache
> +
> +SRC_URI = "git://github.com/celluloid-player/celluloid.git;protocol=https;branch=master"
> +SRCREV = "a7d30b11693e48b18637eb8adc3cfd6a07794680"
> +S = "${WORKDIR}/git"
> +
> +FILES:${PN} += "${datadir}"
> --
> 2.49.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#116394): https://lists.openembedded.org/g/openembedded-devel/message/116394
> Mute This Topic: https://lists.openembedded.org/mt/111999601/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj March 31, 2025, 9:57 p.m. UTC | #2
another error where I have the licenses enabled still ends up with
errors on qemuarm -
https://errors.yoctoproject.org/Errors/Details/850188/

On Mon, Mar 31, 2025 at 2:39 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Sun, Mar 30, 2025 at 11:22 PM Markus Volk via
> lists.openembedded.org <f_l_k=t-online.de@lists.openembedded.org>
> wrote:
> >
> > Celluloid is a nice and clean gtk4/libadwaita frontend for mpv that improves
> > usability in gnome
> >
> > Signed-off-by: Markus Volk <f_l_k@t-online.de>
> > ---
> >  .../celluloid/celluloid_0.2.7.bb              | 24 +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
> >
> > diff --git a/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb b/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
> > new file mode 100644
> > index 0000000000..d4aada37ff
> > --- /dev/null
> > +++ b/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
> > @@ -0,0 +1,24 @@
> > +SUMMARY = "Celluloid is a simple GTK4 frontend for mpv"
> > +HOMEPAGE = "https://github.com/celluloid-player/celluloid"
> > +LICENSE = "GPL-3.0-only"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=8006d9c814277c1bfc4ca22af94b59ee"
> > +
> > +DEPENDS = " \
> > +    appstream-glib \
> > +    appstream-glib-native \
> > +    desktop-file-utils-native \
> > +    gtk4 \
> > +    glib-2.0 \
> > +    glib-2.0-native \
> > +    libadwaita \
> > +    libepoxy \
> > +    mpv \
>
> I think due to mpv dependency  here amd mpv needing ffmpeg this needs
> something like below
>
> EXCLUDE_FROM_WORLD = "${@bb.utils.contains("LICENSE_FLAGS_ACCEPTED",
> "commercial", "0", "1", d)}"
>
>
> > +"
> > +
> > +inherit meson gettext mime-xdg pkgconfig gtk-icon-cache
> > +
> > +SRC_URI = "git://github.com/celluloid-player/celluloid.git;protocol=https;branch=master"
> > +SRCREV = "a7d30b11693e48b18637eb8adc3cfd6a07794680"
> > +S = "${WORKDIR}/git"
> > +
> > +FILES:${PN} += "${datadir}"
> > --
> > 2.49.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#116394): https://lists.openembedded.org/g/openembedded-devel/message/116394
> > Mute This Topic: https://lists.openembedded.org/mt/111999601/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
Markus Volk April 1, 2025, 6:16 a.m. UTC | #3
On Mon, Mar 31 2025 at 14:39:53 -07:00:00, Khem Raj 
<raj.khem@gmail.com> wrote:
> I think due to mpv dependency  here amd mpv needing ffmpeg this needs
> something like below
> 
> EXCLUDE_FROM_WORLD = "${@bb.utils.contains 
> <mailto:${@bb.utils.contains>("LICENSE_FLAGS_ACCEPTED",
> "commercial", "0", "1", d)}"

Did you add celluloid to packagegroup-gnome-apps.bb to include it to 
world build?

If so, it might eventually help to add it as follows:
RDEPENDS:${PN} = " \
    ${@bb.utils.contains("LICENSE_FLAGS_ACCEPTED", "commercial", 
"celluloid", "", d)} \

instead of using EXCLUDE_FROM_WORLD within the celluloid recipe
Markus Volk April 1, 2025, 6:49 a.m. UTC | #4
I think I have found the issue

Luajit fails for arm with:
/usr/include/bits/long-double.h:23:10: fatal error: 
bits/long-double-32.h: No such file or directory

On Tue, Apr 1 2025 at 08:16:40 +02:00:00, Markus Volk 
<f_l_k@t-online.de> wrote:
> On Mon, Mar 31 2025 at 14:39:53 -07:00:00, Khem Raj 
> <raj.khem@gmail.com> wrote:
>> I think due to mpv dependency  here amd mpv needing ffmpeg this needs
>> something like below
>> 
>> EXCLUDE_FROM_WORLD = "${@bb.utils.contains 
>> <mailto:${@bb.utils.contains>("LICENSE_FLAGS_ACCEPTED",
>> "commercial", "0", "1", d)}"
> 
> Did you add celluloid to packagegroup-gnome-apps.bb to include it to 
> world build?
> 
> If so, it might eventually help to add it as follows:
> RDEPENDS:${PN} = " \
>     ${@bb.utils.contains("LICENSE_FLAGS_ACCEPTED", "commercial", 
> "celluloid", "", d)} \
> 
> instead of using EXCLUDE_FROM_WORLD within the celluloid recipe
Khem Raj April 1, 2025, 2:17 p.m. UTC | #5
On Mon, Mar 31, 2025 at 11:15 PM Markus Volk <f_l_k@t-online.de> wrote:
>
> On Mon, Mar 31 2025 at 14:39:53 -07:00:00, Khem Raj <raj.khem@gmail.com> wrote:
>
> I think due to mpv dependency here amd mpv needing ffmpeg this needs something like below EXCLUDE_FROM_WORLD = "${@bb.utils.contains("LICENSE_FLAGS_ACCEPTED", "commercial", "0", "1", d)}"
>
>
> Did you add celluloid to packagegroup-gnome-apps.bb to include it to world build?
>
> If so, it might eventually help to add it as follows:
> RDEPENDS:${PN} = " \
>     ${@bb.utils.contains("LICENSE_FLAGS_ACCEPTED", "commercial", "celluloid", "", d)} \
>

This will not work with bitbake world

> instead of using EXCLUDE_FROM_WORLD within the celluloid recipe
diff mbox series

Patch

diff --git a/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb b/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
new file mode 100644
index 0000000000..d4aada37ff
--- /dev/null
+++ b/meta-gnome/recipes-extended/celluloid/celluloid_0.2.7.bb
@@ -0,0 +1,24 @@ 
+SUMMARY = "Celluloid is a simple GTK4 frontend for mpv"
+HOMEPAGE = "https://github.com/celluloid-player/celluloid"
+LICENSE = "GPL-3.0-only"
+LIC_FILES_CHKSUM = "file://COPYING;md5=8006d9c814277c1bfc4ca22af94b59ee"
+
+DEPENDS = " \
+    appstream-glib \
+    appstream-glib-native \
+    desktop-file-utils-native \
+    gtk4 \
+    glib-2.0 \
+    glib-2.0-native \
+    libadwaita \
+    libepoxy \
+    mpv \
+"
+
+inherit meson gettext mime-xdg pkgconfig gtk-icon-cache
+
+SRC_URI = "git://github.com/celluloid-player/celluloid.git;protocol=https;branch=master"
+SRCREV = "a7d30b11693e48b18637eb8adc3cfd6a07794680"
+S = "${WORKDIR}/git"
+
+FILES:${PN} += "${datadir}"