diff mbox series

[5/9] miniupnpd: don't inherit autotools

Message ID 20250319120836.982987-5-ross.burton@arm.com
State New
Headers show
Series [1/9] rdisk: don't inherit autotools | expand

Commit Message

Ross Burton March 19, 2025, 12:08 p.m. UTC
This upstream does not in fact use autotools

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Ross Burton March 19, 2025, 4:23 p.m. UTC | #1
Retracting this one, I broke it.  I’ll resend it shortly.

Ross

> On 19 Mar 2025, at 12:08, Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote:
> 
> This upstream does not in fact use autotools
> 
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> .../recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb b/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
> index 1c2f030f83..5c0086f8f4 100644
> --- a/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
> +++ b/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
> @@ -7,7 +7,7 @@ SECTION = "networking"
> LICENSE = "BSD-3-Clause"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=a1ed15843ce66639bcf9f109cf247870"
> 
> -inherit autotools gettext pkgconfig systemd
> +inherit gettext pkgconfig systemd
> 
> DEPENDS += "iptables net-tools util-linux libmnl libnetfilter-conntrack"
> 
> @@ -20,12 +20,11 @@ SRC_URI[sha256sum] = "218fad7af31f3c22fb4c9db28a55a2a8b5067d41f5b38f52008a057a00
> 
> IPV6 = "${@bb.utils.contains('DISTRO_FEATURES', 'ipv6', '--ipv6', '', d)}"
> 
> -do_configure:prepend() {
> +do_configure() {
>    echo "${@d.getVar('DISTRO_VERSION')}" > ${S}/os.openembedded
> }
> 
> do_compile() {
> -    cd ${S}
>     CONFIG_OPTIONS="${IPV6} --leasefile --vendorcfg" oe_runmake -f Makefile.linux config.h
>     CONFIG_OPTIONS="${IPV6} --leasefile --vendorcfg" oe_runmake -f Makefile.linux
> }
> -- 
> 2.43.0
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#116072): https://lists.openembedded.org/g/openembedded-devel/message/116072
> Mute This Topic: https://lists.openembedded.org/mt/111787465/6875888
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ross.burton@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj March 19, 2025, 4:25 p.m. UTC | #2
On Wed, Mar 19, 2025 at 9:23 AM Ross Burton <Ross.Burton@arm.com> wrote:
>
> Retracting this one, I broke it.  I’ll resend it shortly.
>

Infact I have a fix for it already in master-next so dont worry about it

> Ross
>
> > On 19 Mar 2025, at 12:08, Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote:
> >
> > This upstream does not in fact use autotools
> >
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> > .../recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb b/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
> > index 1c2f030f83..5c0086f8f4 100644
> > --- a/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
> > +++ b/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
> > @@ -7,7 +7,7 @@ SECTION = "networking"
> > LICENSE = "BSD-3-Clause"
> > LIC_FILES_CHKSUM = "file://LICENSE;md5=a1ed15843ce66639bcf9f109cf247870"
> >
> > -inherit autotools gettext pkgconfig systemd
> > +inherit gettext pkgconfig systemd
> >
> > DEPENDS += "iptables net-tools util-linux libmnl libnetfilter-conntrack"
> >
> > @@ -20,12 +20,11 @@ SRC_URI[sha256sum] = "218fad7af31f3c22fb4c9db28a55a2a8b5067d41f5b38f52008a057a00
> >
> > IPV6 = "${@bb.utils.contains('DISTRO_FEATURES', 'ipv6', '--ipv6', '', d)}"
> >
> > -do_configure:prepend() {
> > +do_configure() {
> >    echo "${@d.getVar('DISTRO_VERSION')}" > ${S}/os.openembedded
> > }
> >
> > do_compile() {
> > -    cd ${S}
> >     CONFIG_OPTIONS="${IPV6} --leasefile --vendorcfg" oe_runmake -f Makefile.linux config.h
> >     CONFIG_OPTIONS="${IPV6} --leasefile --vendorcfg" oe_runmake -f Makefile.linux
> > }
> > --
> > 2.43.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#116072): https://lists.openembedded.org/g/openembedded-devel/message/116072
> > Mute This Topic: https://lists.openembedded.org/mt/111787465/6875888
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ross.burton@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
diff mbox series

Patch

diff --git a/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb b/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
index 1c2f030f83..5c0086f8f4 100644
--- a/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
+++ b/meta-networking/recipes-connectivity/miniupnpd/miniupnpd_2.1.20191006.bb
@@ -7,7 +7,7 @@  SECTION = "networking"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=a1ed15843ce66639bcf9f109cf247870"
 
-inherit autotools gettext pkgconfig systemd
+inherit gettext pkgconfig systemd
 
 DEPENDS += "iptables net-tools util-linux libmnl libnetfilter-conntrack"
 
@@ -20,12 +20,11 @@  SRC_URI[sha256sum] = "218fad7af31f3c22fb4c9db28a55a2a8b5067d41f5b38f52008a057a00
 
 IPV6 = "${@bb.utils.contains('DISTRO_FEATURES', 'ipv6', '--ipv6', '', d)}"
 
-do_configure:prepend() {
+do_configure() {
    echo "${@d.getVar('DISTRO_VERSION')}" > ${S}/os.openembedded
 }
 
 do_compile() {
-    cd ${S}
     CONFIG_OPTIONS="${IPV6} --leasefile --vendorcfg" oe_runmake -f Makefile.linux config.h
     CONFIG_OPTIONS="${IPV6} --leasefile --vendorcfg" oe_runmake -f Makefile.linux
 }