diff mbox series

[meta-oe,3/4] grpc: fix protobuf-lite package config

Message ID 20250208150308.2451484-3-peter.marko@siemens.com
State Accepted
Headers show
Series [meta-oe,1/4] grpc: remove unneeded dependencies | expand

Commit Message

Peter Marko Feb. 8, 2025, 3:03 p.m. UTC
From: Peter Marko <peter.marko@siemens.com>

protobuf-lite is a package, not recipe, so current code leads to
ERROR: Nothing PROVIDES 'protobuf-lite'

Moving it to 4th part (rdepends) is not needed as grpc links against it
so that rdependency is asutomatic.

Therefore protobuf-lite should be removed.

Note: for native, this packageconfig does not even compile and for
target it fails to link.

Signed-off-by: Peter Marko <peter.marko@siemens.com>
---
 meta-oe/recipes-devtools/grpc/grpc_1.68.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gyorgy Sarvari Feb. 8, 2025, 5:42 p.m. UTC | #1
> Note: for native, this packageconfig does not even compile and for
> target it fails to link.
Since it couldn't be more broken even if it tried, what do you think 
about dropping this conf altogether and simply hard-disabling it in 
EXTRA_OECMAKE (if it's not off by default)?
Peter Marko Feb. 8, 2025, 6:04 p.m. UTC | #2
> -----Original Message-----
> From: Gyorgy Sarvari <skandigraun@gmail.com>
> Sent: Saturday, February 8, 2025 18:42
> To: Marko, Peter (FT D EU SK BFS1) <Peter.Marko@siemens.com>;
> openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH 3/4] grpc: fix protobuf-lite package config
> 
> > Note: for native, this packageconfig does not even compile and for
> > target it fails to link.
> Since it couldn't be more broken even if it tried, what do you think
> about dropping this conf altogether and simply hard-disabling it in
> EXTRA_OECMAKE (if it's not off by default)?

Since I'm not using it, I don't have strong opinion on this.
Removing broken features is good, but maybe this works
in all other releases and it's broken only temporarily?

I'd defer this question to Khem.

In general, this is a problem with most of non-default
packageconfig options - not tested things are slowly rotting.
Ideally there would be autobuilder test with alternative configuration for all recipes...

Peter
Khem Raj Feb. 9, 2025, 4:32 a.m. UTC | #3
On Sat, Feb 8, 2025 at 10:04 AM Peter Marko via lists.openembedded.org
<peter.marko=siemens.com@lists.openembedded.org> wrote:
>
>
>
> > -----Original Message-----
> > From: Gyorgy Sarvari <skandigraun@gmail.com>
> > Sent: Saturday, February 8, 2025 18:42
> > To: Marko, Peter (FT D EU SK BFS1) <Peter.Marko@siemens.com>;
> > openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-oe][PATCH 3/4] grpc: fix protobuf-lite package config
> >
> > > Note: for native, this packageconfig does not even compile and for
> > > target it fails to link.
> > Since it couldn't be more broken even if it tried, what do you think
> > about dropping this conf altogether and simply hard-disabling it in
> > EXTRA_OECMAKE (if it's not off by default)?
>
> Since I'm not using it, I don't have strong opinion on this.
> Removing broken features is good, but maybe this works
> in all other releases and it's broken only temporarily?
>
> I'd defer this question to Khem.
>
> In general, this is a problem with most of non-default
> packageconfig options - not tested things are slowly rotting.
> Ideally there would be autobuilder test with alternative configuration for all recipes...
>

since its not enable in default set of packageconfig, so it wont break
common usecase
but if someone wants to use it, then they will have to fix it before
using it. So in a way
its a bad taste on one end but perhaps an opportunity to fix it on the
other. So I am
ambivalent, this change makes things better syntactically so I will
accept this patch
but if you send me another one to remove the packageconfig that can be
considered too.

> Peter
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#115315): https://lists.openembedded.org/g/openembedded-devel/message/115315
> Mute This Topic: https://lists.openembedded.org/mt/111070545/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/grpc/grpc_1.68.0.bb b/meta-oe/recipes-devtools/grpc/grpc_1.68.0.bb
index 1524168c78..6e729e9734 100644
--- a/meta-oe/recipes-devtools/grpc/grpc_1.68.0.bb
+++ b/meta-oe/recipes-devtools/grpc/grpc_1.68.0.bb
@@ -50,7 +50,7 @@  PACKAGECONFIG[objective-c] = "-DgRPC_BUILD_GRPC_OBJECTIVE_C_PLUGIN=ON,-DgRPC_BUI
 PACKAGECONFIG[php] = "-DgRPC_BUILD_GRPC_PHP_PLUGIN=ON,-DgRPC_BUILD_GRPC_PHP_PLUGIN=OFF"
 PACKAGECONFIG[python] = "-DgRPC_BUILD_GRPC_PYTHON_PLUGIN=ON,-DgRPC_BUILD_GRPC_PYTHON_PLUGIN=OFF"
 PACKAGECONFIG[ruby] = "-DgRPC_BUILD_GRPC_RUBY_PLUGIN=ON,-DgRPC_BUILD_GRPC_RUBY_PLUGIN=OFF"
-PACKAGECONFIG[protobuf-lite] = "-DgRPC_USE_PROTO_LITE=ON,-DgRPC_USE_PROTO_LITE=OFF,protobuf-lite"
+PACKAGECONFIG[protobuf-lite] = "-DgRPC_USE_PROTO_LITE=ON,-DgRPC_USE_PROTO_LITE=OFF"
 PACKAGECONFIG[shared] = "-DBUILD_SHARED_LIBS=ON,-DBUILD_SHARED_LIBS=OFF,,"
 
 do_configure:prepend() {