diff mbox series

[meta-oe,kirkstone] libssh: Add ptest

Message ID 20250203075610.238451-1-thakur.virendra1810@gmail.com
State New
Headers show
Series [meta-oe,kirkstone] libssh: Add ptest | expand

Commit Message

Virendra Thakur Feb. 3, 2025, 7:56 a.m. UTC
From: Virendra Thakur <virendrak@kpit.com>

Enable ptest for libssh , this change is backported from upstream
scarthgap.

Reference: https://git.openembedded.org/meta-openembedded/commit/?h=scarthgap&id=bf49bdea290ba8cf18f3fd6b47d1d71dfe499948

~ # ptest-runner libssh
START: ptest-runner
2025-01-28T14:28
BEGIN: /usr/lib/libssh/ptest
PASS: torture_buffer
PASS: torture_callbacks
PASS: torture_channel
PASS: torture_config
PASS: torture_crypto
PASS: torture_hashes
PASS: torture_init
PASS: torture_isipaddr
PASS: torture_keyfiles
PASS: torture_knownhosts_parsing
PASS: torture_list
PASS: torture_misc
PASS: torture_options
PASS: torture_packet
PASS: torture_packet_filter
PASS: torture_pki
PASS: torture_pki_ecdsa
PASS: torture_pki_ed25519
PASS: torture_pki_rsa
PASS: torture_rand
PASS: torture_threads_buffer
PASS: torture_threads_crypto
PASS: torture_threads_init
PASS: torture_threads_pki_rsa
DURATION: 119
END: /usr/lib/libssh/ptest
2025-01-28T14:29
STOP: ptest-runner
TOTAL: 1 FAIL: 0

Signed-off-by: Virendra Thakur <virendrak@kpit.com>
---
 ....txt-do-not-search-ssh-sshd-commands.patch | 38 ++++++++++++++++
 .../recipes-support/libssh/libssh/run-ptest   | 45 +++++++++++++++++++
 .../recipes-support/libssh/libssh_0.8.9.bb    | 19 ++++++--
 3 files changed, 99 insertions(+), 3 deletions(-)
 create mode 100644 meta-oe/recipes-support/libssh/libssh/0001-tests-CMakeLists.txt-do-not-search-ssh-sshd-commands.patch
 create mode 100644 meta-oe/recipes-support/libssh/libssh/run-ptest

Comments

Jörg Sommer Feb. 3, 2025, 4:47 p.m. UTC | #1
virendra thakur via lists.openembedded.org schrieb am Mo 03. Feb, 13:26 (+0530):
> diff --git a/meta-oe/recipes-support/libssh/libssh_0.8.9.bb b/meta-oe/recipes-support/libssh/libssh_0.8.9.bb
> index 98910d3068..7d0fc2d32f 100644
> --- a/meta-oe/recipes-support/libssh/libssh_0.8.9.bb
> +++ b/meta-oe/recipes-support/libssh/libssh_0.8.9.bb
> @@ -18,17 +18,19 @@ SRC_URI = "git://git.libssh.org/projects/libssh.git;protocol=https;branch=stable
>             file://004_CVE-2023-6004.patch \
>             file://005_CVE-2023-6004.patch \
>             file://006_CVE-2023-6004.patch \
> +           file://0001-tests-CMakeLists.txt-do-not-search-ssh-sshd-commands.patch \
> +           file://run-ptest \
>            "
>  SRCREV = "04685a74df9ce1db1bc116a83a0da78b4f4fa1f8"
>  
>  S = "${WORKDIR}/git"
>  
> -inherit cmake
> +inherit cmake ptest
>  
> -PACKAGECONFIG ??= "gcrypt"
> +PACKAGECONFIG ??= "gcrypt ${@bb.utils.contains('PTEST_ENABLED', '1', 'tests', '', d)}"

Would `oe.utils.vartrue()` be better?


Regards Jörg
Virendra Kumar Thakur Feb. 4, 2025, 12:12 p.m. UTC | #2
@Jörg Sommer<mailto:joerg.sommer@navimatix.de>

This change is already present in scarthgap branch, i am just backporting it from the scarthgap to kirkstone.

bb.utils.contains is better option as we are expecting a return based on presence of ptest enable.

[cid:75e3c0ba-b9c0-49f2-a84c-8f7a86e2ae47]<https://outlook.office.com/bookwithme/user/fcab7d9903984b91a5841c51f49bd5ec@kpit.com?anonymous&ep=bwmEmailSignature>         Book time to meet with me<https://outlook.office.com/bookwithme/user/fcab7d9903984b91a5841c51f49bd5ec@kpit.com?anonymous&ep=bwmEmailSignature>
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/libssh/libssh/0001-tests-CMakeLists.txt-do-not-search-ssh-sshd-commands.patch b/meta-oe/recipes-support/libssh/libssh/0001-tests-CMakeLists.txt-do-not-search-ssh-sshd-commands.patch
new file mode 100644
index 0000000000..91355d0c88
--- /dev/null
+++ b/meta-oe/recipes-support/libssh/libssh/0001-tests-CMakeLists.txt-do-not-search-ssh-sshd-commands.patch
@@ -0,0 +1,38 @@ 
+From d2525ba0bc7b11de12c54ea1a3d1eb862537136d Mon Sep 17 00:00:00 2001
+From: Yi Zhao <yi.zhao@windriver.com>
+Date: Wed, 15 Mar 2023 16:51:58 +0800
+Subject: [PATCH] tests/CMakeLists.txt: do not search ssh/sshd commands on host
+
+It will search ssh/sshd commands on host when configure. Since they are
+not required by unittests, we can skip the search.
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
+Signed-off-by: Virendra Thakur <virendrak@kpit.com>
+---
+ tests/CMakeLists.txt | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
+index 22a36f37..aa32ca2e 100644
+--- a/tests/CMakeLists.txt
++++ b/tests/CMakeLists.txt
+@@ -48,6 +48,7 @@ set(TEST_TARGET_LIBRARIES
+
+ add_subdirectory(unittests)
+
++if (CLIENT_TESTING OR SERVER_TESTING)
+ if (CLIENT_TESTING)
+     find_package(socket_wrapper 1.1.5 REQUIRED)
+     find_package(nss_wrapper 1.1.2 REQUIRED)
+@@ -152,6 +153,7 @@ if (WITH_SERVER AND SERVER_TESTING)
+     add_subdirectory(pkd)
+ endif (WITH_SERVER AND SERVER_TESTING)
+
++endif ()
+ if (FUZZ_TESTING)
+     add_subdirectory(fuzz)
+ endif()
+-- 
+2.25.1
diff --git a/meta-oe/recipes-support/libssh/libssh/run-ptest b/meta-oe/recipes-support/libssh/libssh/run-ptest
new file mode 100644
index 0000000000..4ab3e5d141
--- /dev/null
+++ b/meta-oe/recipes-support/libssh/libssh/run-ptest
@@ -0,0 +1,45 @@ 
+#!/bin/sh
+
+# Valid tests to run
+tests="torture_buffer \
+       torture_callbacks \
+       torture_channel \
+       torture_config \
+       torture_crypto \
+       torture_hashes \
+       torture_init \
+       torture_isipaddr \
+       torture_keyfiles \
+       torture_knownhosts_parsing \
+       torture_list \
+       torture_misc \
+       torture_options \
+       torture_packet \
+       torture_packet_filter \
+       torture_pki \
+       torture_pki_ecdsa \
+       torture_pki_ed25519 \
+       torture_pki_rsa \
+       torture_rand \
+       torture_threads_buffer \
+       torture_threads_crypto \
+       torture_threads_init \
+       torture_threads_pki_rsa \
+       "
+
+ptestdir=$(dirname "$(readlink -f "$0")")
+cd "$ptestdir"/tests || exit
+
+# Run specified tests
+for f in $tests
+do
+    if test -e ./"$f"; then
+        if ./"$f" > ./"$f".out 2> ./"$f".err; then
+            echo "PASS: $f"
+        else
+            echo "FAIL: $f"
+        fi
+    else
+        echo "SKIP: $f"
+    fi
+done
diff --git a/meta-oe/recipes-support/libssh/libssh_0.8.9.bb b/meta-oe/recipes-support/libssh/libssh_0.8.9.bb
index 98910d3068..7d0fc2d32f 100644
--- a/meta-oe/recipes-support/libssh/libssh_0.8.9.bb
+++ b/meta-oe/recipes-support/libssh/libssh_0.8.9.bb
@@ -18,17 +18,19 @@  SRC_URI = "git://git.libssh.org/projects/libssh.git;protocol=https;branch=stable
            file://004_CVE-2023-6004.patch \
            file://005_CVE-2023-6004.patch \
            file://006_CVE-2023-6004.patch \
+           file://0001-tests-CMakeLists.txt-do-not-search-ssh-sshd-commands.patch \
+           file://run-ptest \
           "
 SRCREV = "04685a74df9ce1db1bc116a83a0da78b4f4fa1f8"
 
 S = "${WORKDIR}/git"
 
-inherit cmake
+inherit cmake ptest
 
-PACKAGECONFIG ??= "gcrypt"
+PACKAGECONFIG ??= "gcrypt ${@bb.utils.contains('PTEST_ENABLED', '1', 'tests', '', d)}"
 PACKAGECONFIG[gssapi] = "-DWITH_GSSAPI=1, -DWITH_GSSAPI=0, krb5, "
 PACKAGECONFIG[gcrypt] = "-DWITH_GCRYPT=1, -DWITH_GCRYPT=0, libgcrypt, "
-
+PACKAGECONFIG[tests] = "-DUNIT_TESTING=1, -DUNIT_TESTING=0, cmocka"
 ARM_INSTRUCTION_SET:armv5 = "arm"
 
 EXTRA_OECMAKE = " \
@@ -44,6 +46,17 @@  do_configure:prepend () {
         || bbfatal "Failed to disable examples"
 }
 
+do_compile:prepend () {
+    if [ ${PTEST_ENABLED} = "1" ]; then
+        sed -i -e 's|${B}|${PTEST_PATH}|g' ${B}/config.h
+    fi
+}
+
+do_install_ptest () {
+    install -d ${D}${PTEST_PATH}/tests
+    cp -f ${B}/tests/unittests/torture_* ${D}${PTEST_PATH}/tests/
+}
+
 TOOLCHAIN = "gcc"
 
 BBCLASSEXTEND = "native nativesdk"