diff mbox series

[meta-oe,3/8] protobuf: use system jsoncpp

Message ID 20250202213910.284312-3-peter.marko@siemens.com
State Accepted
Headers show
Series [meta-oe,1/8] protobuf: remove unneeded atomic linker flag | expand

Commit Message

Peter Marko Feb. 2, 2025, 9:39 p.m. UTC 
From: Peter Marko <peter.marko@siemens.com>

We should not use additional vendored jsoncpp unless required due to
compatibility issues.

Signed-off-by: Peter Marko <peter.marko@siemens.com>
---
 meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Khem Raj Feb. 3, 2025, 6:58 a.m. UTC | #1 
ERROR: Nothing PROVIDES 'nativesdk-jsoncpp' (but
virtual:nativesdk:/mnt/b/yoe/master/sources/meta-openembedded/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
DEPENDS on or otherwise requires it). Close matches:
  nativesdk-cjson
  nativesdk-json-c
  nativesdk-ncp

On Sun, Feb 2, 2025 at 1:40 PM Peter Marko via lists.openembedded.org
<peter.marko=siemens.com@lists.openembedded.org> wrote:
>
> From: Peter Marko <peter.marko@siemens.com>
>
> We should not use additional vendored jsoncpp unless required due to
> compatibility issues.
>
> Signed-off-by: Peter Marko <peter.marko@siemens.com>
> ---
>  meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
> index c7e9408870..470c368cf3 100644
> --- a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
> +++ b/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
> @@ -7,7 +7,7 @@ SECTION = "console/tools"
>  LICENSE = "BSD-3-Clause"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=37b5762e07f0af8c74ce80a8bda4266b"
>
> -DEPENDS = "zlib abseil-cpp"
> +DEPENDS = "zlib abseil-cpp jsoncpp"
>  DEPENDS:append:class-target = " protobuf-native"
>
>  SRCREV = "9d0ec0f92b5b5fdeeda11f9dcecc1872ff378014"
> @@ -37,6 +37,7 @@ EXTRA_OECMAKE += "\
>      -Dprotobuf_BUILD_TESTS=OFF \
>      -Dprotobuf_BUILD_EXAMPLES=OFF \
>      -Dprotobuf_ABSL_PROVIDER="package" \
> +    -Dprotobuf_JSONCPP_PROVIDER="package" \
>  "
>
>  TEST_SRC_DIR = "examples"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#115222): https://lists.openembedded.org/g/openembedded-devel/message/115222
> Mute This Topic: https://lists.openembedded.org/mt/110959919/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Peter Marko Feb. 3, 2025, 5:37 p.m. UTC | #2 
I will add nativesdk support  to jsoncpp recipe in v2
Peter

> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com>
> Sent: Monday, February 3, 2025 7:58
> To: Marko, Peter (FT D EU SK BFS1) <Peter.Marko@siemens.com>
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH 3/8] protobuf: use system jsoncpp
> 
> ERROR: Nothing PROVIDES 'nativesdk-jsoncpp' (but
> virtual:nativesdk:/mnt/b/yoe/master/sources/meta-openembedded/meta-
> oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
> DEPENDS on or otherwise requires it). Close matches:
>   nativesdk-cjson
>   nativesdk-json-c
>   nativesdk-ncp
> 
> On Sun, Feb 2, 2025 at 1:40 PM Peter Marko via lists.openembedded.org
> <peter.marko=siemens.com@lists.openembedded.org> wrote:
> >
> > From: Peter Marko <peter.marko@siemens.com>
> >
> > We should not use additional vendored jsoncpp unless required due to
> > compatibility issues.
> >
> > Signed-off-by: Peter Marko <peter.marko@siemens.com>
> > ---
> >  meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb b/meta-
> oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
> > index c7e9408870..470c368cf3 100644
> > --- a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
> > +++ b/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
> > @@ -7,7 +7,7 @@ SECTION = "console/tools"
> >  LICENSE = "BSD-3-Clause"
> >  LIC_FILES_CHKSUM =
> "file://LICENSE;md5=37b5762e07f0af8c74ce80a8bda4266b"
> >
> > -DEPENDS = "zlib abseil-cpp"
> > +DEPENDS = "zlib abseil-cpp jsoncpp"
> >  DEPENDS:append:class-target = " protobuf-native"
> >
> >  SRCREV = "9d0ec0f92b5b5fdeeda11f9dcecc1872ff378014"
> > @@ -37,6 +37,7 @@ EXTRA_OECMAKE += "\
> >      -Dprotobuf_BUILD_TESTS=OFF \
> >      -Dprotobuf_BUILD_EXAMPLES=OFF \
> >      -Dprotobuf_ABSL_PROVIDER="package" \
> > +    -Dprotobuf_JSONCPP_PROVIDER="package" \
> >  "
> >
> >  TEST_SRC_DIR = "examples"
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#115222):
> https://lists.openembedded.org/g/openembedded-devel/message/115222
> > Mute This Topic: https://lists.openembedded.org/mt/110959919/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
> [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
index c7e9408870..470c368cf3 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_4.25.5.bb
@@ -7,7 +7,7 @@  SECTION = "console/tools"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=37b5762e07f0af8c74ce80a8bda4266b"
 
-DEPENDS = "zlib abseil-cpp"
+DEPENDS = "zlib abseil-cpp jsoncpp"
 DEPENDS:append:class-target = " protobuf-native"
 
 SRCREV = "9d0ec0f92b5b5fdeeda11f9dcecc1872ff378014"
@@ -37,6 +37,7 @@  EXTRA_OECMAKE += "\
     -Dprotobuf_BUILD_TESTS=OFF \
     -Dprotobuf_BUILD_EXAMPLES=OFF \
     -Dprotobuf_ABSL_PROVIDER="package" \
+    -Dprotobuf_JSONCPP_PROVIDER="package" \
 "
 
 TEST_SRC_DIR = "examples"