diff mbox series

can-utils: RRECOMMENDS only ip from iproute2

Message ID 20250130071432.2946804-1-sean@geanix.com
State Accepted
Headers show
Series can-utils: RRECOMMENDS only ip from iproute2 | expand

Commit Message

Sean Nyekjaer Jan. 30, 2025, 7:14 a.m. UTC
There is no need for RRECOMMENDS on the full iproute2 package.

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 meta-oe/recipes-extended/socketcan/can-utils_2023.03.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gyorgy Sarvari Jan. 30, 2025, 11:09 a.m. UTC | #1
>   # busybox ip fails to configure can interfaces, so we need iproute2 to do so.
>   # See details in http://www.armadeus.com/wiki/index.php?title=CAN_bus_Linux_driver.
> -RRECOMMENDS:${PN} += "iproute2"
> +RRECOMMENDS:${PN} += "iproute2-ip"
I wonder if the comment is still true with oe-core master. One of the 
features[1] that made their way to Busybox 1.37 is CAN support for the 
"ip" command. (Unfortunately have no CAN hw at my hand to try , so I 
just keep wondering)

[1]: 
https://git.busybox.net/busybox/commit/?h=1_37_stable&id=f873c63085e3f3745040286999779077ccc03987
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/socketcan/can-utils_2023.03.bb b/meta-oe/recipes-extended/socketcan/can-utils_2023.03.bb
index ca6cb7db58..51d6327b75 100644
--- a/meta-oe/recipes-extended/socketcan/can-utils_2023.03.bb
+++ b/meta-oe/recipes-extended/socketcan/can-utils_2023.03.bb
@@ -46,5 +46,5 @@  ALTERNATIVE_LINK_NAME[cansequence] = "${bindir}/cansequence"
 
 # busybox ip fails to configure can interfaces, so we need iproute2 to do so.
 # See details in http://www.armadeus.com/wiki/index.php?title=CAN_bus_Linux_driver.
-RRECOMMENDS:${PN} += "iproute2"
+RRECOMMENDS:${PN} += "iproute2-ip"