| Message ID | 20240810152807.899873-2-akuster808@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe,scarthgap,1/7] fwupd: skip buildpaths errors | expand |
This doesn't work with multilib where the package is named ${PN}-src
(e.g. lib32-gcab-src) and it's better to just lower buildpaths from
ERROR_QA to WARN_QA instead of skipping it completely, because it's
still an issue which should be fixed (at least to improve hashserv
efficiency if you don't care about reproducibility itself)
Why was this even backported to scarthgap where buildpaths QA issues
aren't fatal?
On Sat, Aug 10, 2024 at 5:28 PM Armin Kuster via
lists.openembedded.org <akuster808=gmail.com@lists.openembedded.org>
wrote:
>
> From: Mikko Rapeli <mikko.rapeli@linaro.org>
>
> gcab-src has some meson generated files which embed
> absolute paths from build environment. meson seems
> ot do this on purpose to fix other issues.
>
> Ignored those issues for now.
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> (cherry picked from commit db91757e7bd98494666ca00bc7727a7607b6004f)
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> meta-oe/recipes-gnome/gcab/gcab_1.6.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta-oe/recipes-gnome/gcab/gcab_1.6.bb b/meta-oe/recipes-gnome/gcab/gcab_1.6.bb
> index 4278fc9453..49c64f0ba6 100644
> --- a/meta-oe/recipes-gnome/gcab/gcab_1.6.bb
> +++ b/meta-oe/recipes-gnome/gcab/gcab_1.6.bb
> @@ -22,3 +22,6 @@ PACKAGECONFIG[nls] = "-Dnls=true,-Dnls=false"
> PACKAGECONFIG[tests] = "-Dtests=true -Dinstalled_tests=true,-Dtests=false -Dinstalled_tests=false"
>
> BBCLASSEXTEND = "native"
> +
> +# meson embeds absolute paths to generated files on purpose
> +INSANE_SKIP:gcab-src += "buildpaths"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111739): https://lists.openembedded.org/g/openembedded-devel/message/111739
> Mute This Topic: https://lists.openembedded.org/mt/107826456/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff --git a/meta-oe/recipes-gnome/gcab/gcab_1.6.bb b/meta-oe/recipes-gnome/gcab/gcab_1.6.bb index 4278fc9453..49c64f0ba6 100644 --- a/meta-oe/recipes-gnome/gcab/gcab_1.6.bb +++ b/meta-oe/recipes-gnome/gcab/gcab_1.6.bb @@ -22,3 +22,6 @@ PACKAGECONFIG[nls] = "-Dnls=true,-Dnls=false" PACKAGECONFIG[tests] = "-Dtests=true -Dinstalled_tests=true,-Dtests=false -Dinstalled_tests=false" BBCLASSEXTEND = "native" + +# meson embeds absolute paths to generated files on purpose +INSANE_SKIP:gcab-src += "buildpaths"