diff mbox series

[meta-networking] tnftp: Disable incompatible-pointer-types warning as error

Message ID 20240613084703.1858419-1-changqing.li@windriver.com
State New
Headers show
Series [meta-networking] tnftp: Disable incompatible-pointer-types warning as error | expand

Commit Message

Changqing Li June 13, 2024, 8:47 a.m. UTC
From: Changqing Li <changqing.li@windriver.com>

Fix lib32-tnftp do_compile failure with gcc-14:
../../tnftp-20230507/libedit/terminal.c:597:56: error: passing argument 2 of 'terminal_overwrite' from incompatible pointer type [-Wincompatible-pointer-types]
  597 |                                 terminal_overwrite(el, &el->el_display[
      |                                                        ^~~~~~~~~~~~~~~~
      |                                                        |
      |                                                        wint_t * {aka unsigned int *}
  598 |                                     el->el_cursor.v][el->el_cursor.h],
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../tnftp-20230507/libedit/refresh.c:114:38: error: initialization of 'wchar_t *' {aka 'long int *'} from incompatible pointer type 'wint_t *' {aka 'unsigned int *'} [-Wincompatible-pointer-types]
  114 |                 wchar_t *firstline = el->el_vdisplay[0];

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta-networking/recipes-support/tnftp/tnftp_20230507.bb | 3 +++
 1 file changed, 3 insertions(+)

Comments

Khem Raj June 13, 2024, 3:39 p.m. UTC | #1
On Thu, Jun 13, 2024 at 1:47 AM Changqing Li via
lists.openembedded.org
<changqing.li=windriver.com@lists.openembedded.org> wrote:
>
> From: Changqing Li <changqing.li@windriver.com>
>
> Fix lib32-tnftp do_compile failure with gcc-14:
> ../../tnftp-20230507/libedit/terminal.c:597:56: error: passing argument 2 of 'terminal_overwrite' from incompatible pointer type [-Wincompatible-pointer-types]
>   597 |                                 terminal_overwrite(el, &el->el_display[
>       |                                                        ^~~~~~~~~~~~~~~~
>       |                                                        |
>       |                                                        wint_t * {aka unsigned int *}
>   598 |                                     el->el_cursor.v][el->el_cursor.h],
>       |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../tnftp-20230507/libedit/refresh.c:114:38: error: initialization of 'wchar_t *' {aka 'long int *'} from incompatible pointer type 'wint_t *' {aka 'unsigned int *'} [-Wincompatible-pointer-types]
>   114 |                 wchar_t *firstline = el->el_vdisplay[0];
>

there is a new release available
https://ftp.netbsd.org/pub/NetBSD/misc/tnftp/tnftpd-20231001.tar.gz
it might be good to upgrade it while here, and check if the issue is
fixed upstream or not.
secondly, it would be good to see if we can fix the problem or explain
it what's going on.

> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta-networking/recipes-support/tnftp/tnftp_20230507.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta-networking/recipes-support/tnftp/tnftp_20230507.bb b/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
> index bdd9759f2..da4466794 100644
> --- a/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
> +++ b/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
> @@ -36,3 +36,6 @@ PACKAGECONFIG ?= "openssl \
>  "
>  PACKAGECONFIG[openssl] = "--enable-ssl, --disable-ssl --with-ssl=no, openssl"
>  PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
> +
> +#fix lib32-tnftp do_compile error with gcc-14
> +CFLAGS += "-Wno-error=incompatible-pointer-types"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110889): https://lists.openembedded.org/g/openembedded-devel/message/110889
> Mute This Topic: https://lists.openembedded.org/mt/106648104/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Changqing Li June 14, 2024, 1:04 a.m. UTC | #2
On 6/13/24 23:39, Khem Raj via lists.openembedded.org wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Thu, Jun 13, 2024 at 1:47 AM Changqing Li via
> lists.openembedded.org
> <changqing.li=windriver.com@lists.openembedded.org>  wrote:
>> From: Changqing Li<changqing.li@windriver.com>
>>
>> Fix lib32-tnftp do_compile failure with gcc-14:
>> ../../tnftp-20230507/libedit/terminal.c:597:56: error: passing argument 2 of 'terminal_overwrite' from incompatible pointer type [-Wincompatible-pointer-types]
>>    597 |                                 terminal_overwrite(el, &el->el_display[
>>        |                                                        ^~~~~~~~~~~~~~~~
>>        |                                                        |
>>        |                                                        wint_t * {aka unsigned int *}
>>    598 |                                     el->el_cursor.v][el->el_cursor.h],
>>        |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../../tnftp-20230507/libedit/refresh.c:114:38: error: initialization of 'wchar_t *' {aka 'long int *'} from incompatible pointer type 'wint_t *' {aka 'unsigned int *'} [-Wincompatible-pointer-types]
>>    114 |                 wchar_t *firstline = el->el_vdisplay[0];
>>
> there is a new release available
> https://ftp.netbsd.org/pub/NetBSD/misc/tnftp/tnftpd-20231001.tar.gz

This new release is for ftp daemon,  and this recipe is for ftp client,  
so no new release

avaiable,  but I will check if we can fix the the problem or check if 
there is fix upstream.

Thanks.

//Changqing

> it might be good to upgrade it while here, and check if the issue is
> fixed upstream or not.
> secondly, it would be good to see if we can fix the problem or explain
> it what's going on.
>> Signed-off-by: Changqing Li<changqing.li@windriver.com>
>> ---
>>   meta-networking/recipes-support/tnftp/tnftp_20230507.bb | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-networking/recipes-support/tnftp/tnftp_20230507.bb b/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
>> index bdd9759f2..da4466794 100644
>> --- a/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
>> +++ b/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
>> @@ -36,3 +36,6 @@ PACKAGECONFIG ?= "openssl \
>>   "
>>   PACKAGECONFIG[openssl] = "--enable-ssl, --disable-ssl --with-ssl=no, openssl"
>>   PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
>> +
>> +#fix lib32-tnftp do_compile error with gcc-14
>> +CFLAGS += "-Wno-error=incompatible-pointer-types"
>> --
>> 2.25.1
>>
>>
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#110895):https://lists.openembedded.org/g/openembedded-devel/message/110895
>> Mute This Topic:https://lists.openembedded.org/mt/106648104/3616873
>> Group Owner:openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub  [changqing.li@windriver.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta-networking/recipes-support/tnftp/tnftp_20230507.bb b/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
index bdd9759f2..da4466794 100644
--- a/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
+++ b/meta-networking/recipes-support/tnftp/tnftp_20230507.bb
@@ -36,3 +36,6 @@  PACKAGECONFIG ?= "openssl \
 "
 PACKAGECONFIG[openssl] = "--enable-ssl, --disable-ssl --with-ssl=no, openssl"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
+
+#fix lib32-tnftp do_compile error with gcc-14
+CFLAGS += "-Wno-error=incompatible-pointer-types"