diff mbox series

[meta-oe,scarthgap] opencl: fix virtual PROVIDES warnings

Message ID 20240531071903.3257195-1-bin.lan.cn@eng.windriver.com
State New
Headers show
Series [meta-oe,scarthgap] opencl: fix virtual PROVIDES warnings | expand

Commit Message

Bin Lan May 31, 2024, 7:19 a.m. UTC
From: Bin Lan <bin.lan.cn@windriver.com>

oe-core has started to warn when virtual/ is used outside of
the RPROVIDES (build) context.

We tweak provides/depends to use virtual- instead to
avoid the warning:

  RPROVIDES is set to virtual/opencl-icd, the substring 'virtual/'
  holds no meaning in this context. It is suggested to use the 'virtual-'

Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
---
 meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb                | 2 +-
 meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb | 2 +-
 meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb       | 2 +-
 meta-oe/recipes-support/opencv/opencv_4.9.0.bb              | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Comments

Martin Jansa May 31, 2024, 7:52 a.m. UTC | #1
You're changing the build time dependencies, the warning is about
runtime dependencies, so I don't think this is correct.

You probably have some bad RPROVIDES in different recipe or bbappend,
see bitbake-getvar.

On Fri, May 31, 2024 at 9:19 AM Bin Lan via lists.openembedded.org
<bin.lan.cn=eng.windriver.com@lists.openembedded.org> wrote:
>
> From: Bin Lan <bin.lan.cn@windriver.com>
>
> oe-core has started to warn when virtual/ is used outside of
> the RPROVIDES (build) context.
>
> We tweak provides/depends to use virtual- instead to
> avoid the warning:
>
>   RPROVIDES is set to virtual/opencl-icd, the substring 'virtual/'
>   holds no meaning in this context. It is suggested to use the 'virtual-'
>
> Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
> ---
>  meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb                | 2 +-
>  meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb | 2 +-
>  meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb       | 2 +-
>  meta-oe/recipes-support/opencv/opencv_4.9.0.bb              | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
> index d43ea281ae..bc1a645217 100644
> --- a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
> +++ b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
> @@ -14,7 +14,7 @@ S = "${WORKDIR}/git"
>  inherit autotools
>
>  DEPENDS = "ruby-native"
> -PROVIDES = "virtual/opencl-icd"
> +PROVIDES = "virtual-opencl-icd"
>  RPROVIDES:${PN} = "virtual-opencl-icd"
>
>  BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb b/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb
> index 146ec6e472..9901e47616 100644
> --- a/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb
> +++ b/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb
> @@ -8,7 +8,7 @@ inherit pkgconfig cmake
>
>  DEPENDS += "opencl-headers"
>
> -PROVIDES = "virtual/opencl-icd"
> +PROVIDES = "virtual-opencl-icd"
>  RPROVIDES:${PN} = "virtual-opencl-icd"
>
>  S = "${WORKDIR}/git"
> diff --git a/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb b/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb
> index 6cacd3722c..3e9ea48993 100644
> --- a/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb
> +++ b/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb
> @@ -13,7 +13,7 @@ SRCREV = "748c3930a9b9cb826e631d77439e2cb8f84f5bcf"
>
>  S = "${WORKDIR}/git"
>
> -DEPENDS += "opencl-headers virtual/opencl-icd"
> +DEPENDS += "opencl-headers virtual-opencl-icd"
>
>  do_install() {
>         oe_runmake install PREFIX=${D}${prefix} MANDIR=${D}${mandir}
> diff --git a/meta-oe/recipes-support/opencv/opencv_4.9.0.bb b/meta-oe/recipes-support/opencv/opencv_4.9.0.bb
> index cf836d3ecf..2e72f12658 100644
> --- a/meta-oe/recipes-support/opencv/opencv_4.9.0.bb
> +++ b/meta-oe/recipes-support/opencv/opencv_4.9.0.bb
> @@ -109,7 +109,7 @@ PACKAGECONFIG[java] = "-DJAVA_INCLUDE_PATH=${JAVA_HOME}/include -DJAVA_INCLUDE_P
>  PACKAGECONFIG[jpeg] = "-DWITH_JPEG=ON,-DWITH_JPEG=OFF,jpeg,"
>  PACKAGECONFIG[libav] = "-DWITH_FFMPEG=ON,-DWITH_FFMPEG=OFF,libav,"
>  PACKAGECONFIG[libv4l] = "-DWITH_LIBV4L=ON,-DWITH_LIBV4L=OFF,v4l-utils,"
> -PACKAGECONFIG[opencl] = "-DWITH_OPENCL=ON,-DWITH_OPENCL=OFF,opencl-headers virtual/opencl-icd,"
> +PACKAGECONFIG[opencl] = "-DWITH_OPENCL=ON,-DWITH_OPENCL=OFF,opencl-headers virtual-opencl-icd,"
>  PACKAGECONFIG[openvino] = "-DWITH_OPENVINO=ON,-DWITH_OPENVINO=OFF,openvino-inference-engine,openvino-inference-engine"
>  PACKAGECONFIG[oracle-java] = "-DJAVA_INCLUDE_PATH=${ORACLE_JAVA_HOME}/include -DJAVA_INCLUDE_PATH2=${ORACLE_JAVA_HOME}/include/linux -DJAVA_AWT_INCLUDE_PATH=${ORACLE_JAVA_HOME}/include -DJAVA_AWT_LIBRARY=${ORACLE_JAVA_HOME}/lib/amd64/libjawt.so -DJAVA_JVM_LIBRARY=${ORACLE_JAVA_HOME}/lib/amd64/server/libjvm.so,,ant-native oracle-jse-jdk oracle-jse-jdk-native,"
>  PACKAGECONFIG[png] = "-DWITH_PNG=ON,-DWITH_PNG=OFF,libpng,"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110650): https://lists.openembedded.org/g/openembedded-devel/message/110650
> Mute This Topic: https://lists.openembedded.org/mt/106403783/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
index d43ea281ae..bc1a645217 100644
--- a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
+++ b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
@@ -14,7 +14,7 @@  S = "${WORKDIR}/git"
 inherit autotools
 
 DEPENDS = "ruby-native"
-PROVIDES = "virtual/opencl-icd"
+PROVIDES = "virtual-opencl-icd"
 RPROVIDES:${PN} = "virtual-opencl-icd"
 
 BBCLASSEXTEND = "native nativesdk"
diff --git a/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb b/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb
index 146ec6e472..9901e47616 100644
--- a/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb
+++ b/meta-oe/recipes-core/opencl/opencl-icd-loader_2023.12.14.bb
@@ -8,7 +8,7 @@  inherit pkgconfig cmake
 
 DEPENDS += "opencl-headers"
 
-PROVIDES = "virtual/opencl-icd"
+PROVIDES = "virtual-opencl-icd"
 RPROVIDES:${PN} = "virtual-opencl-icd"
 
 S = "${WORKDIR}/git"
diff --git a/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb b/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb
index 6cacd3722c..3e9ea48993 100644
--- a/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb
+++ b/meta-oe/recipes-support/opencl/clinfo_3.0.23.01.25.bb
@@ -13,7 +13,7 @@  SRCREV = "748c3930a9b9cb826e631d77439e2cb8f84f5bcf"
 
 S = "${WORKDIR}/git"
 
-DEPENDS += "opencl-headers virtual/opencl-icd"
+DEPENDS += "opencl-headers virtual-opencl-icd"
 
 do_install() {
 	oe_runmake install PREFIX=${D}${prefix} MANDIR=${D}${mandir}
diff --git a/meta-oe/recipes-support/opencv/opencv_4.9.0.bb b/meta-oe/recipes-support/opencv/opencv_4.9.0.bb
index cf836d3ecf..2e72f12658 100644
--- a/meta-oe/recipes-support/opencv/opencv_4.9.0.bb
+++ b/meta-oe/recipes-support/opencv/opencv_4.9.0.bb
@@ -109,7 +109,7 @@  PACKAGECONFIG[java] = "-DJAVA_INCLUDE_PATH=${JAVA_HOME}/include -DJAVA_INCLUDE_P
 PACKAGECONFIG[jpeg] = "-DWITH_JPEG=ON,-DWITH_JPEG=OFF,jpeg,"
 PACKAGECONFIG[libav] = "-DWITH_FFMPEG=ON,-DWITH_FFMPEG=OFF,libav,"
 PACKAGECONFIG[libv4l] = "-DWITH_LIBV4L=ON,-DWITH_LIBV4L=OFF,v4l-utils,"
-PACKAGECONFIG[opencl] = "-DWITH_OPENCL=ON,-DWITH_OPENCL=OFF,opencl-headers virtual/opencl-icd,"
+PACKAGECONFIG[opencl] = "-DWITH_OPENCL=ON,-DWITH_OPENCL=OFF,opencl-headers virtual-opencl-icd,"
 PACKAGECONFIG[openvino] = "-DWITH_OPENVINO=ON,-DWITH_OPENVINO=OFF,openvino-inference-engine,openvino-inference-engine"
 PACKAGECONFIG[oracle-java] = "-DJAVA_INCLUDE_PATH=${ORACLE_JAVA_HOME}/include -DJAVA_INCLUDE_PATH2=${ORACLE_JAVA_HOME}/include/linux -DJAVA_AWT_INCLUDE_PATH=${ORACLE_JAVA_HOME}/include -DJAVA_AWT_LIBRARY=${ORACLE_JAVA_HOME}/lib/amd64/libjawt.so -DJAVA_JVM_LIBRARY=${ORACLE_JAVA_HOME}/lib/amd64/server/libjvm.so,,ant-native oracle-jse-jdk oracle-jse-jdk-native,"
 PACKAGECONFIG[png] = "-DWITH_PNG=ON,-DWITH_PNG=OFF,libpng,"