diff mbox series

[meta-oe] android-tools-configfs: point S to UNPACKDIR

Message ID 20240528091459.3885623-1-dmitry.baryshkov@linaro.org
State Under Review
Headers show
Series [meta-oe] android-tools-configfs: point S to UNPACKDIR | expand

Commit Message

Dmitry Baryshkov May 28, 2024, 9:14 a.m. UTC
android-tools-configfs doesn't have any checked out source files, which
results in a warning regarding S not existing. Fix the warning by
pointing S to UNPACKDIR.

The warning text:

WARNING: android-tools-conf-configfs-1.0-r0 do_unpack:
android-tools-conf-configfs: the directory ${WORKDIR}/${BP} (<scrubbed>)
pointed to by the S variable doesn't exist - please set S within the
recipe to point to where the source has been unpacked to

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../android-tools/android-tools-conf-configfs_1.0.bb            | 2 ++
 1 file changed, 2 insertions(+)

Comments

Khem Raj May 28, 2024, 3:42 p.m. UTC | #1
On Tue, May 28, 2024 at 2:15 AM Dmitry Baryshkov via
lists.openembedded.org <dbaryshkov=gmail.com@lists.openembedded.org>
wrote:
>
> android-tools-configfs doesn't have any checked out source files, which
> results in a warning regarding S not existing. Fix the warning by
> pointing S to UNPACKDIR.
>
> The warning text:
>
> WARNING: android-tools-conf-configfs-1.0-r0 do_unpack:
> android-tools-conf-configfs: the directory ${WORKDIR}/${BP} (<scrubbed>)
> pointed to by the S variable doesn't exist - please set S within the
> recipe to point to where the source has been unpacked to
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../android-tools/android-tools-conf-configfs_1.0.bb            | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb b/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
> index 430b53c4d0cf..b50437615ebf 100644
> --- a/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
> +++ b/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
> @@ -3,6 +3,8 @@ SECTION = "console/utils"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
>
> +S = "${UNPACKDIR}"
> +

perhaps follow the pattern we are using elsewhere

S = "${WORKDIR}/sources"
UNPACKDIR = "${S}"

>  SRC_URI = " \
>      file://android-gadget-setup \
>      file://android-gadget-start \
> --
> 2.39.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110579): https://lists.openembedded.org/g/openembedded-devel/message/110579
> Mute This Topic: https://lists.openembedded.org/mt/106345437/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Dmitry Baryshkov May 28, 2024, 4:07 p.m. UTC | #2
On Tue, 28 May 2024 at 18:42, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Tue, May 28, 2024 at 2:15 AM Dmitry Baryshkov via
> lists.openembedded.org <dbaryshkov=gmail.com@lists.openembedded.org>
> wrote:
> >
> > android-tools-configfs doesn't have any checked out source files, which
> > results in a warning regarding S not existing. Fix the warning by
> > pointing S to UNPACKDIR.
> >
> > The warning text:
> >
> > WARNING: android-tools-conf-configfs-1.0-r0 do_unpack:
> > android-tools-conf-configfs: the directory ${WORKDIR}/${BP} (<scrubbed>)
> > pointed to by the S variable doesn't exist - please set S within the
> > recipe to point to where the source has been unpacked to
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  .../android-tools/android-tools-conf-configfs_1.0.bb            | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb b/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
> > index 430b53c4d0cf..b50437615ebf 100644
> > --- a/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
> > +++ b/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
> > @@ -3,6 +3,8 @@ SECTION = "console/utils"
> >  LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
> >
> > +S = "${UNPACKDIR}"
> > +
>
> perhaps follow the pattern we are using elsewhere
>
> S = "${WORKDIR}/sources"
> UNPACKDIR = "${S}"

Hmm. Why not.

>
> >  SRC_URI = " \
> >      file://android-gadget-setup \
> >      file://android-gadget-start \
> > --
> > 2.39.2
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#110579): https://lists.openembedded.org/g/openembedded-devel/message/110579
> > Mute This Topic: https://lists.openembedded.org/mt/106345437/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb b/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
index 430b53c4d0cf..b50437615ebf 100644
--- a/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
+++ b/meta-oe/recipes-devtools/android-tools/android-tools-conf-configfs_1.0.bb
@@ -3,6 +3,8 @@  SECTION = "console/utils"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
 
+S = "${UNPACKDIR}"
+
 SRC_URI = " \
     file://android-gadget-setup \
     file://android-gadget-start \