| Message ID | 20240527073320.3472465-1-yoann.congal@smile.fr |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-multimedia] sample-content: Set UNPACKDIR to S to avoid a QA warning | expand |
I think you need to do the opposite, setting S using UNPACKDIR. Regards, Qi On 5/27/24 15:33, Yoann Congal via lists.openembedded.org wrote: > Since recent UNPACKDIR work, default S directory is not created anymore. > By setting UNPACKDIR to S, S in indirectly created in do_unpack. > > Fixes these warnings: > WARNING: bigbuckbunny-480p-1.0-r0 do_unpack: bigbuckbunny-480p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/bigbuckbunny-480p/1.0/bigbuckbunny-480p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to > WARNING: bigbuckbunny-720p-1.0-r0 do_unpack: bigbuckbunny-720p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/bigbuckbunny-720p/1.0/bigbuckbunny-720p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to > WARNING: bigbuckbunny-1080p-1.0-r0 do_unpack: bigbuckbunny-1080p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/bigbuckbunny-1080p/1.0/bigbuckbunny-1080p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to > WARNING: tearsofsteel-1080p-1.0-r0 do_unpack: tearsofsteel-1080p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/tearsofsteel-1080p/1.0/tearsofsteel-1080p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to > > Signed-off-by: Yoann Congal <yoann.congal@smile.fr> > Reviewed-by: Alexandre Truong <alexandre.truong@smile.fr> > --- > .../recipes-multimedia/sample-content/bigbuckbunny-1080p.bb | 2 ++ > .../recipes-multimedia/sample-content/bigbuckbunny-480p.bb | 2 ++ > .../recipes-multimedia/sample-content/bigbuckbunny-720p.bb | 2 ++ > .../recipes-multimedia/sample-content/tearsofsteel-1080p.bb | 2 ++ > 4 files changed, 8 insertions(+) > > diff --git a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb > index e5a8f085b..83ad136b4 100644 > --- a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb > +++ b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb > @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = "69fe2cfe7154a6e752688e3a0d7d6b07b1605bbaf75b56f6470dc7b4c2 > > inherit allarch > > +UNPACKDIR = "${S}" > + > do_install() { > install -d ${D}${datadir}/movies > install -m 0644 ${UNPACKDIR}/big_buck_bunny_1080p_surround.avi ${D}${datadir}/movies/ > diff --git a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb > index 37e519790..b054948e6 100644 > --- a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb > +++ b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb > @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = "40d1cf5bc8e1b0e55dac7bb2e3fbc2aea05b6679444864781299b24db0 > > inherit allarch > > +UNPACKDIR = "${S}" > + > do_install() { > install -d ${D}${datadir}/movies > install -m 0644 ${UNPACKDIR}/big_buck_bunny_480p_surround-fix.avi ${D}${datadir}/movies/ > diff --git a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb > index 2b233d3e1..4b80d110a 100644 > --- a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb > +++ b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb > @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = "b957d6e6212638441b52d3b620af157cc8d40c2a0342669294854a06ed > > inherit allarch > > +UNPACKDIR = "${S}" > + > do_install() { > install -d ${D}${datadir}/movies > install -m 0644 ${UNPACKDIR}/big_buck_bunny_720p_surround.avi ${D}${datadir}/movies/ > diff --git a/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb b/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb > index 34753fdb1..02b3c3048 100644 > --- a/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb > +++ b/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb > @@ -8,6 +8,8 @@ SRC_URI[sha256sum] = "bd2b5bc6c16d4085034f47ef7e4b3938afe86b4eec4ac3cf2685367d3b > > inherit allarch > > +UNPACKDIR = "${S}" > + > do_install() { > install -d ${D}${datadir}/movies > install -m 0644 ${UNPACKDIR}/ToS-4k-1920.mov ${D}${datadir}/movies/ > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#110533): https://lists.openembedded.org/g/openembedded-devel/message/110533 > Mute This Topic: https://lists.openembedded.org/mt/106326666/3618072 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [Qi.Chen@windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi, Le lun. 27 mai 2024 à 09:58, Chen Qi via lists.openembedded.org <Qi.Chen= windriver.com@lists.openembedded.org> a écrit : > I think you need to do the opposite, setting S using UNPACKDIR. > Thanks for your review. I've asked this question at the weekly technical meeting. The answer was to try to be consistent to handle S/UNPACKDIR. So, I've sent a v2 to align the patch to what OE-Core does : https://lists.openembedded.org/g/openembedded-devel/topic/meta_multimedia_patch_v2/106353038 I've also sent a doc patch to (try to) clarify : https://lists.yoctoproject.org/g/docs/topic/master_next_patch/106353882 Regards, > > Regards, > Qi > > > On 5/27/24 15:33, Yoann Congal via lists.openembedded.org wrote: > > Since recent UNPACKDIR work, default S directory is not created anymore. > > By setting UNPACKDIR to S, S in indirectly created in do_unpack. > > > > Fixes these warnings: > > WARNING: bigbuckbunny-480p-1.0-r0 do_unpack: bigbuckbunny-480p: the > directory ${WORKDIR}/${BP} > (.../tmp/work/all-poky-linux/bigbuckbunny-480p/1.0/bigbuckbunny-480p-1.0) > pointed to by the S variable doesn't exist - please set S within the recipe > to point to where the source has been unpacked to > > WARNING: bigbuckbunny-720p-1.0-r0 do_unpack: bigbuckbunny-720p: the > directory ${WORKDIR}/${BP} > (.../tmp/work/all-poky-linux/bigbuckbunny-720p/1.0/bigbuckbunny-720p-1.0) > pointed to by the S variable doesn't exist - please set S within the recipe > to point to where the source has been unpacked to > > WARNING: bigbuckbunny-1080p-1.0-r0 do_unpack: bigbuckbunny-1080p: the > directory ${WORKDIR}/${BP} > (.../tmp/work/all-poky-linux/bigbuckbunny-1080p/1.0/bigbuckbunny-1080p-1.0) > pointed to by the S variable doesn't exist - please set S within the recipe > to point to where the source has been unpacked to > > WARNING: tearsofsteel-1080p-1.0-r0 do_unpack: tearsofsteel-1080p: the > directory ${WORKDIR}/${BP} > (.../tmp/work/all-poky-linux/tearsofsteel-1080p/1.0/tearsofsteel-1080p-1.0) > pointed to by the S variable doesn't exist - please set S within the recipe > to point to where the source has been unpacked to > > > > Signed-off-by: Yoann Congal <yoann.congal@smile.fr> > > Reviewed-by: Alexandre Truong <alexandre.truong@smile.fr> > > --- > > .../recipes-multimedia/sample-content/bigbuckbunny-1080p.bb | 2 ++ > > .../recipes-multimedia/sample-content/bigbuckbunny-480p.bb | 2 ++ > > .../recipes-multimedia/sample-content/bigbuckbunny-720p.bb | 2 ++ > > .../recipes-multimedia/sample-content/tearsofsteel-1080p.bb | 2 ++ > > 4 files changed, 8 insertions(+) > > > > diff --git a/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-1080p.bb b/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-1080p.bb > > index e5a8f085b..83ad136b4 100644 > > --- a/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-1080p.bb > > +++ b/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-1080p.bb > > @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = > "69fe2cfe7154a6e752688e3a0d7d6b07b1605bbaf75b56f6470dc7b4c2 > > > > inherit allarch > > > > +UNPACKDIR = "${S}" > > + > > do_install() { > > install -d ${D}${datadir}/movies > > install -m 0644 ${UNPACKDIR}/big_buck_bunny_1080p_surround.avi > ${D}${datadir}/movies/ > > diff --git a/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-480p.bb b/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-480p.bb > > index 37e519790..b054948e6 100644 > > --- a/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-480p.bb > > +++ b/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-480p.bb > > @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = > "40d1cf5bc8e1b0e55dac7bb2e3fbc2aea05b6679444864781299b24db0 > > > > inherit allarch > > > > +UNPACKDIR = "${S}" > > + > > do_install() { > > install -d ${D}${datadir}/movies > > install -m 0644 ${UNPACKDIR}/big_buck_bunny_480p_surround-fix.avi > ${D}${datadir}/movies/ > > diff --git a/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-720p.bb b/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-720p.bb > > index 2b233d3e1..4b80d110a 100644 > > --- a/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-720p.bb > > +++ b/meta-multimedia/recipes-multimedia/sample-content/ > bigbuckbunny-720p.bb > > @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = > "b957d6e6212638441b52d3b620af157cc8d40c2a0342669294854a06ed > > > > inherit allarch > > > > +UNPACKDIR = "${S}" > > + > > do_install() { > > install -d ${D}${datadir}/movies > > install -m 0644 ${UNPACKDIR}/big_buck_bunny_720p_surround.avi > ${D}${datadir}/movies/ > > diff --git a/meta-multimedia/recipes-multimedia/sample-content/ > tearsofsteel-1080p.bb b/meta-multimedia/recipes-multimedia/sample-content/ > tearsofsteel-1080p.bb > > index 34753fdb1..02b3c3048 100644 > > --- a/meta-multimedia/recipes-multimedia/sample-content/ > tearsofsteel-1080p.bb > > +++ b/meta-multimedia/recipes-multimedia/sample-content/ > tearsofsteel-1080p.bb > > @@ -8,6 +8,8 @@ SRC_URI[sha256sum] = > "bd2b5bc6c16d4085034f47ef7e4b3938afe86b4eec4ac3cf2685367d3b > > > > inherit allarch > > > > +UNPACKDIR = "${S}" > > + > > do_install() { > > install -d ${D}${datadir}/movies > > install -m 0644 ${UNPACKDIR}/ToS-4k-1920.mov ${D}${datadir}/movies/ > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#110534): > https://lists.openembedded.org/g/openembedded-devel/message/110534 > Mute This Topic: https://lists.openembedded.org/mt/106326666/4316185 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > yoann.congal@smile.fr] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb index e5a8f085b..83ad136b4 100644 --- a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb +++ b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-1080p.bb @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = "69fe2cfe7154a6e752688e3a0d7d6b07b1605bbaf75b56f6470dc7b4c2 inherit allarch +UNPACKDIR = "${S}" + do_install() { install -d ${D}${datadir}/movies install -m 0644 ${UNPACKDIR}/big_buck_bunny_1080p_surround.avi ${D}${datadir}/movies/ diff --git a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb index 37e519790..b054948e6 100644 --- a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb +++ b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-480p.bb @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = "40d1cf5bc8e1b0e55dac7bb2e3fbc2aea05b6679444864781299b24db0 inherit allarch +UNPACKDIR = "${S}" + do_install() { install -d ${D}${datadir}/movies install -m 0644 ${UNPACKDIR}/big_buck_bunny_480p_surround-fix.avi ${D}${datadir}/movies/ diff --git a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb index 2b233d3e1..4b80d110a 100644 --- a/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb +++ b/meta-multimedia/recipes-multimedia/sample-content/bigbuckbunny-720p.bb @@ -9,6 +9,8 @@ SRC_URI[sha256sum] = "b957d6e6212638441b52d3b620af157cc8d40c2a0342669294854a06ed inherit allarch +UNPACKDIR = "${S}" + do_install() { install -d ${D}${datadir}/movies install -m 0644 ${UNPACKDIR}/big_buck_bunny_720p_surround.avi ${D}${datadir}/movies/ diff --git a/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb b/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb index 34753fdb1..02b3c3048 100644 --- a/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb +++ b/meta-multimedia/recipes-multimedia/sample-content/tearsofsteel-1080p.bb @@ -8,6 +8,8 @@ SRC_URI[sha256sum] = "bd2b5bc6c16d4085034f47ef7e4b3938afe86b4eec4ac3cf2685367d3b inherit allarch +UNPACKDIR = "${S}" + do_install() { install -d ${D}${datadir}/movies install -m 0644 ${UNPACKDIR}/ToS-4k-1920.mov ${D}${datadir}/movies/
Since recent UNPACKDIR work, default S directory is not created anymore. By setting UNPACKDIR to S, S in indirectly created in do_unpack. Fixes these warnings: WARNING: bigbuckbunny-480p-1.0-r0 do_unpack: bigbuckbunny-480p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/bigbuckbunny-480p/1.0/bigbuckbunny-480p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to WARNING: bigbuckbunny-720p-1.0-r0 do_unpack: bigbuckbunny-720p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/bigbuckbunny-720p/1.0/bigbuckbunny-720p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to WARNING: bigbuckbunny-1080p-1.0-r0 do_unpack: bigbuckbunny-1080p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/bigbuckbunny-1080p/1.0/bigbuckbunny-1080p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to WARNING: tearsofsteel-1080p-1.0-r0 do_unpack: tearsofsteel-1080p: the directory ${WORKDIR}/${BP} (.../tmp/work/all-poky-linux/tearsofsteel-1080p/1.0/tearsofsteel-1080p-1.0) pointed to by the S variable doesn't exist - please set S within the recipe to point to where the source has been unpacked to Signed-off-by: Yoann Congal <yoann.congal@smile.fr> Reviewed-by: Alexandre Truong <alexandre.truong@smile.fr> --- .../recipes-multimedia/sample-content/bigbuckbunny-1080p.bb | 2 ++ .../recipes-multimedia/sample-content/bigbuckbunny-480p.bb | 2 ++ .../recipes-multimedia/sample-content/bigbuckbunny-720p.bb | 2 ++ .../recipes-multimedia/sample-content/tearsofsteel-1080p.bb | 2 ++ 4 files changed, 8 insertions(+)