diff mbox series

[meta-oe] flatpak: add PACKAGECONFIG knob for malcontent

Message ID 20240521164945.333290-1-f_l_k@t-online.de
State Accepted
Headers show
Series [meta-oe] flatpak: add PACKAGECONFIG knob for malcontent | expand

Commit Message

Markus Volk May 21, 2024, 4:49 p.m. UTC
Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin Jansa June 28, 2024, 7:24 a.m. UTC | #1
Hi,

is there some knob for dconf?

It's not caused by this change as dconf dependency was included in the
original flatpak recipe from you:
https://git.openembedded.org/meta-openembedded/commit/?id=841daa24d5d0730bfa1fdb0dc7898b29061face4
we've recently enabled polkit required by flatpak and now I'm seeing
unsatisfied dependency in world builds.

dconf is only available in meta-gnome while flatpak is in meta-oe and
meta-oe doesn't (and shouldn't) depend on meta-gnome.

Can flatpak and all recipes depending on it (quick grep shows
malcontent-ui, xdg-dbus-proxy, xdg-desktop-portal and pipewire in
meta-multimedia where the flatpak PACKAGECONFIG should be off by
default after the move) be moved to meta-gnome or to dynamic layer for
meta-gnome?

Regards,

On Tue, May 21, 2024 at 6:49 PM Markus Volk via lists.openembedded.org
<f_l_k=t-online.de@lists.openembedded.org> wrote:
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb b/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb
> index fba7bc49a..8351e7d65 100644
> --- a/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb
> +++ b/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb
> @@ -55,6 +55,7 @@ PACKAGECONFIG[soup] = "-Dhttp_backend=soup,,libsoup-2.4"
>  PACKAGECONFIG[tests] = "-Dtests=true,-Dtests=false,xauth socat-native"
>  PACKAGECONFIG[xauth] = "-Dxauth=enabled,-Dxauth=disabled,xauth"
>  PACKAGECONFIG[seccomp] = "-Dseccomp=enabled,-Dseccomp=disabled,libseccomp"
> +PACKAGECONFIG[malcontent] = "-Dmalcontent=enabled,-Dmalcontent=disabled,malcontent"
>  PACKAGECONFIG[selinux] = "-Dselinux_module=enabled,-Dselinux_module=disabled,libselinux"
>  PACKAGECONFIG[wayland-security-context] = "-Dwayland_security_context=enabled,-Dwayland_security_context=disabled,wayland wayland-native wayland-protocols"
>
> --
> 2.44.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110448): https://lists.openembedded.org/g/openembedded-devel/message/110448
> Mute This Topic: https://lists.openembedded.org/mt/106226893/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Markus Volk June 28, 2024, 8:32 a.m. UTC | #2
On Fri, Jun 28 2024 at 09:24:10 AM +02:00:00, Martin Jansa 
<martin.jansa@gmail.com> wrote:
> is there some knob for dconf?

In fact, there is.
<https://github.com/flatpak/flatpak/blob/92d7f9ec49e2db4ad93040d8e607531791165024/meson_options.txt#L10>

Making pipewire dependent on meta-gnome doesn't feel right to me. Would 
it be acceptable to just disable dconf for flatpak by default?
Martin Jansa June 28, 2024, 8:47 a.m. UTC | #3
On Fri, Jun 28, 2024 at 10:32 AM Markus Volk <f_l_k@t-online.de> wrote:
>
> On Fri, Jun 28 2024 at 09:24:10 AM +02:00:00, Martin Jansa <martin.jansa@gmail.com> wrote:
>
> is there some knob for dconf?
>
>
> In fact, there is.
> https://github.com/flatpak/flatpak/blob/92d7f9ec49e2db4ad93040d8e607531791165024/meson_options.txt#L10
>
> Making pipewire dependent on meta-gnome doesn't feel right to me. Would it be acceptable to just disable dconf for flatpak by default?

I'm not using flatpak so it's fine with me (I don't know what runtime
features missing dconf support affects).
Markus Volk June 28, 2024, 9:31 a.m. UTC | #4
On Fri, Jun 28 2024 at 10:47:25 AM +02:00:00, Martin Jansa 
<martin.jansa@gmail.com> wrote:
> I'm not using flatpak so it's fine with me (I don't know what runtime
> features missing dconf support affects).

Maybe we could add a bbappend to meta-gnome that enables dconf? For 
Gnome it would be nice to have i guess
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb b/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb
index fba7bc49a..8351e7d65 100644
--- a/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb
+++ b/meta-oe/recipes-extended/flatpak/flatpak_1.15.8.bb
@@ -55,6 +55,7 @@  PACKAGECONFIG[soup] = "-Dhttp_backend=soup,,libsoup-2.4"
 PACKAGECONFIG[tests] = "-Dtests=true,-Dtests=false,xauth socat-native"
 PACKAGECONFIG[xauth] = "-Dxauth=enabled,-Dxauth=disabled,xauth"
 PACKAGECONFIG[seccomp] = "-Dseccomp=enabled,-Dseccomp=disabled,libseccomp"
+PACKAGECONFIG[malcontent] = "-Dmalcontent=enabled,-Dmalcontent=disabled,malcontent"
 PACKAGECONFIG[selinux] = "-Dselinux_module=enabled,-Dselinux_module=disabled,libselinux"
 PACKAGECONFIG[wayland-security-context] = "-Dwayland_security_context=enabled,-Dwayland_security_context=disabled,wayland wayland-native wayland-protocols"