diff mbox series

[meta-python] python3-incremental: cleanup RDEPENDS

Message ID 20240418092910.3585-1-gudnimar@noxmedical.com
State Under Review
Headers show
Series [meta-python] python3-incremental: cleanup RDEPENDS | expand

Commit Message

Guðni Már Gilbert April 18, 2024, 9:29 a.m. UTC
incremental package does not need all twisted packages. Only the core package is required.
The goal with this change is to minimize dependency memory requirements.

Signed-off-by: Guðni Már Gilbert <gudnimar@noxmedical.com>
---
 .../recipes-devtools/python/python3-incremental_22.10.0.bb      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Orling April 19, 2024, 2:08 p.m. UTC | #1
On Thu, Apr 18, 2024 at 2:29 AM Guðni Már Gilbert via lists.openembedded.org
<gudnimar=noxmedical.com@lists.openembedded.org> wrote:

> incremental package does not need all twisted packages. Only the core
> package is required.
> The goal with this change is to minimize dependency memory requirements.
>
> Signed-off-by: Guðni Már Gilbert <gudnimar@noxmedical.com>
> ---
> .../recipes-devtools/python/python3-incremental_22.10.0.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-python/recipes-devtools/python/
> python3-incremental_22.10.0.bb b/meta-python/recipes-devtools/python/
> python3-incremental_22.10.0.bb
> index 3d93cc05e..79fa15311 100644
> --- a/meta-python/recipes-devtools/python/python3-incremental_22.10.0.bb
> +++ b/meta-python/recipes-devtools/python/python3-incremental_22.10.0.bb
> @@ -8,7 +8,7 @@ SRC_URI[sha256sum] =
> "912feeb5e0f7e0188e6f42241d2f450002e11bbc0937c65865045854c2
> inherit pypi setuptools3
>

This package defines a proper build-backend, so we should also consider
“inherit python_setuptools_build_meta” instead of setuptools.
https://github.com/twisted/incremental/blob/19a308d70d72d0aa95380125988d60abb23b64e3/pyproject.toml#L7


>
> RDEPENDS:${PN} += " \
> - python3-twisted \
> + python3-twisted-core \
> python3-click \
> "
>
> --
> 2.34.1
>
>
> Warning: Copyright Nox Health. This communication is confidential and may
> contain privileged information. By the use of email over the Internet or
> other communication systems, Nox Health is not waiving either
> confidentiality of, or legal privilege in, the content of the email and of
> any attachments. If the recipient of this message is not the intended
> addressee, please call Nox Health immediately by calling (+1) 888.505.0280
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110052):
> https://lists.openembedded.org/g/openembedded-devel/message/110052
> Mute This Topic: https://lists.openembedded.org/mt/105594757/924729
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Alper Ak April 19, 2024, 6:22 p.m. UTC | #2
Hi Gilbert,

First of all, thank you for your patch. But I'm getting error while building the recipe. Output:

ERROR: Nothing RPROVIDES 'python3-twisted-core-native' (but virtual:native:/opt/yocto_co/sources/meta-openembedded/meta-python/recipes-devtools/python/python3-incremental_22.10.0.bb RDEPENDS on or otherwise requires it)

NOTE: Runtime target 'python3-twisted-core-native' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['python3-twisted-core-native']

NOTE: Runtime target 'python3-twisted-core' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['python3-twisted-core', 'python3-incremental-native', 'python3-twisted-core-native']

ERROR: Required build target 'python3-incremental' has no buildable providers.
Missing or unbuildable dependency chain was: ['python3-incremental', 'python3-twisted-core', 'python3-incremental-native', 'python3-twisted-core-native']

It would be nice if you could take a look at your free time.

Best Regards
diff mbox series

Patch

diff --git a/meta-python/recipes-devtools/python/python3-incremental_22.10.0.bb b/meta-python/recipes-devtools/python/python3-incremental_22.10.0.bb
index 3d93cc05e..79fa15311 100644
--- a/meta-python/recipes-devtools/python/python3-incremental_22.10.0.bb
+++ b/meta-python/recipes-devtools/python/python3-incremental_22.10.0.bb
@@ -8,7 +8,7 @@  SRC_URI[sha256sum] = "912feeb5e0f7e0188e6f42241d2f450002e11bbc0937c65865045854c2
 inherit pypi setuptools3
 
 RDEPENDS:${PN} += " \
-    python3-twisted \
+    python3-twisted-core \
     python3-click \
 "