| Message ID | 20240408092657.436963-1-xiangyu.chen@eng.windriver.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-oe] libgpiod: fix QA error in ptest RDEPENDS | expand |
On Mon, Apr 8, 2024 at 1:47 AM Xiangyu Chen <xiangyu.chen@eng.windriver.com> wrote: > > From: Xiangyu Chen <xiangyu.chen@windriver.com> > > The bash in ptest RDEPENDS would cause following QA error: > > ERROR: QA Issue: lib32-libgpiod package lib32-libgpiod-ptest-dev - > suspicious values 'bash-dev' in RRECOMMENDS [multilib] > > Add a ptest enable dependency to avoid this QA error happens. > > Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com> > --- > meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb > index c62c9a3567..4a568b4fbe 100644 > --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb > +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb > @@ -21,7 +21,7 @@ FILES:${PN}-ptest += "${libdir}/libgpiosim.so.*" > FILES:${PN}-ptest-dev += "${includedir}/gpiosim.h" > > RDEPENDS:${PN}-ptest += " \ > - bash \ > + ${@bb.utils.contains('PTEST_ENABLED', '1', 'bash', '', d)} \ This check is already available below, so just add it next to shunit2 > ${@bb.utils.contains('PTEST_ENABLED', '1', 'shunit2', '', d)} \ > " > RRECOMMENDS:${PN}-ptest += "kernel-module-gpio-sim kernel-module-configfs" > -- > 2.35.5 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#109861): https://lists.openembedded.org/g/openembedded-devel/message/109861 > Mute This Topic: https://lists.openembedded.org/mt/105397634/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 4/9/24 00:12, Khem Raj wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Mon, Apr 8, 2024 at 1:47 AM Xiangyu Chen > <xiangyu.chen@eng.windriver.com> wrote: >> From: Xiangyu Chen <xiangyu.chen@windriver.com> >> >> The bash in ptest RDEPENDS would cause following QA error: >> >> ERROR: QA Issue: lib32-libgpiod package lib32-libgpiod-ptest-dev - >> suspicious values 'bash-dev' in RRECOMMENDS [multilib] >> >> Add a ptest enable dependency to avoid this QA error happens. >> >> Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com> >> --- >> meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb >> index c62c9a3567..4a568b4fbe 100644 >> --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb >> +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb >> @@ -21,7 +21,7 @@ FILES:${PN}-ptest += "${libdir}/libgpiosim.so.*" >> FILES:${PN}-ptest-dev += "${includedir}/gpiosim.h" >> >> RDEPENDS:${PN}-ptest += " \ >> - bash \ >> + ${@bb.utils.contains('PTEST_ENABLED', '1', 'bash', '', d)} \ > This check is already available below, so just add it next to shunit2 Thanks for your suggestion, a v2 patch has been sent to maillist, could you revert current patch on yoe/mut? https://git.openembedded.org/meta-openembedded-contrib/commit/?h=yoe/mut&id=d3a20f5d7ea5a85c1d0fb298a6f3fc93dff0e828 thanks! > >> ${@bb.utils.contains('PTEST_ENABLED', '1', 'shunit2', '', d)} \ >> " >> RRECOMMENDS:${PN}-ptest += "kernel-module-gpio-sim kernel-module-configfs" >> -- >> 2.35.5 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#109861): https://lists.openembedded.org/g/openembedded-devel/message/109861 >> Mute This Topic: https://lists.openembedded.org/mt/105397634/1997914 >> Group Owner: openembedded-devel+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb index c62c9a3567..4a568b4fbe 100644 --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb @@ -21,7 +21,7 @@ FILES:${PN}-ptest += "${libdir}/libgpiosim.so.*" FILES:${PN}-ptest-dev += "${includedir}/gpiosim.h" RDEPENDS:${PN}-ptest += " \ - bash \ + ${@bb.utils.contains('PTEST_ENABLED', '1', 'bash', '', d)} \ ${@bb.utils.contains('PTEST_ENABLED', '1', 'shunit2', '', d)} \ " RRECOMMENDS:${PN}-ptest += "kernel-module-gpio-sim kernel-module-configfs"