diff mbox series

[meta-oe] bpftool: Add missing dep on elfutils-native

Message ID 20240201072150.3751126-1-raj.khem@gmail.com
State Accepted
Headers show
Series [meta-oe] bpftool: Add missing dep on elfutils-native | expand

Commit Message

Khem Raj Feb. 1, 2024, 7:21 a.m. UTC 
Point host CC to OE defined BUILD_CC

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-kernel/bpftool/bpftool.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

chenheyun June 20, 2024, 7:06 a.m. UTC | #1 
hi，
this patch may be have some problem。
bitbake bpftool：
chy@ubuntu:/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work-shared/qemuarm64/kernel-source/tools/bpf/bpftool$ make -C /home/sam/work/qemu-buildsystem/buildsystem3.0/buildsystem/source/kernel/linux-6.1.83/tools/lib/bpf OUTPUT=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/  DESTDIR=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf prefix=  ARCH= CROSS_COMPILE= CC=gcc  -isystem/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/recipe-sysroot-native/usr/include -O2 -pipe LD=ld AR=ar /home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/libbpf.a install_headers
make: invalid option -- 'y'
make: invalid option -- '/'

i guss that：
HOSTCC="${BUILD_CC} ${BUILD_CFLAGS}"
should be this：
HOSTCC="${BUILD_CC}

because， HOSTCC is used in ：

$(LIBBPF_BOOTSTRAP): $(wildcard $(BPF_DIR)/*.[ch] $(BPF_DIR)/Makefile) | $(LIBBPF_BOOTSTRAP_OUTPUT)
echo chy____________1___$(BPF_DIR) _______________________
$(Q)$(MAKE) -C $(BPF_DIR) OUTPUT=$(LIBBPF_BOOTSTRAP_OUTPUT) \
DESTDIR=$(LIBBPF_BOOTSTRAP_DESTDIR:/=) prefix= \
ARCH= CROSS_COMPILE= CC=$(HOSTCC) LD=$(HOSTLD) AR=$(HOSTAR) $@ install_headers
echo chy____________2__________________________

if HOSTCC= ${BUILD_CC} and ${BUILD_CFLAGS}
it will be err in step make -C ：

make -C /home/sam/work/qemu-buildsystem/buildsystem3.0/buildsystem/source/kernel/linux-6.1.83/tools/lib/bpf OUTPUT=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/  DESTDIR=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf prefix=  ARCH= CROSS_COMPILE= *CC=gcc* *-isystem/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/recipe-sysroot-native/usr/include -O2 -pipe* LD=ld AR=ar /home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/libbpf.a install_headers
Khem Raj June 20, 2024, 7:50 p.m. UTC | #2 
can you try changing it to

HOSTCC="'${BUILD_CC} ${BUILD_CFLAGS}'"

On Thu, Jun 20, 2024 at 12:06 AM chenheyun via lists.openembedded.org
<chen_heyun=163.com@lists.openembedded.org> wrote:
>
> hi，
>   this patch may be have some problem。
>   bitbake bpftool：
> chy@ubuntu:/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work-shared/qemuarm64/kernel-source/tools/bpf/bpftool$ make -C /home/sam/work/qemu-buildsystem/buildsystem3.0/buildsystem/source/kernel/linux-6.1.83/tools/lib/bpf OUTPUT=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/  DESTDIR=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf prefix=  ARCH= CROSS_COMPILE= CC=gcc  -isystem/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/recipe-sysroot-native/usr/include -O2 -pipe LD=ld AR=ar /home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/libbpf.a install_headers
> make: invalid option -- 'y'
> make: invalid option -- '/'
>
> i guss that：
> HOSTCC="${BUILD_CC} ${BUILD_CFLAGS}"
> should be this：
> HOSTCC="${BUILD_CC}
>
> because，HOSTCC is used in ：
>
> $(LIBBPF_BOOTSTRAP): $(wildcard $(BPF_DIR)/*.[ch] $(BPF_DIR)/Makefile) | $(LIBBPF_BOOTSTRAP_OUTPUT)
>     echo chy____________1___$(BPF_DIR) _______________________
>     $(Q)$(MAKE) -C $(BPF_DIR) OUTPUT=$(LIBBPF_BOOTSTRAP_OUTPUT) \
>         DESTDIR=$(LIBBPF_BOOTSTRAP_DESTDIR:/=) prefix= \
>         ARCH= CROSS_COMPILE= CC=$(HOSTCC) LD=$(HOSTLD) AR=$(HOSTAR) $@ install_headers
>     echo chy____________2__________________________
>
> if HOSTCC= ${BUILD_CC} and  ${BUILD_CFLAGS}
> it will be err in step make -C ：
>
> make -C /home/sam/work/qemu-buildsystem/buildsystem3.0/buildsystem/source/kernel/linux-6.1.83/tools/lib/bpf OUTPUT=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/  DESTDIR=/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf prefix=  ARCH= CROSS_COMPILE= CC=gcc  -isystem/home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/recipe-sysroot-native/usr/include -O2 -pipe LD=ld AR=ar /home/sam/work/qemu-buildsystem/buildsystem3.0/build/qemuarm64/tmp/work/qemuarm64-poky-linux/bpftool/1.0-r0/bpftool-1.0/bootstrap/libbpf/libbpf.a install_headers
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110971): https://lists.openembedded.org/g/openembedded-devel/message/110971
> Mute This Topic: https://lists.openembedded.org/mt/104092706/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-kernel/bpftool/bpftool.bb b/meta-oe/recipes-kernel/bpftool/bpftool.bb
index 317ec19266..b22334fe90 100644
--- a/meta-oe/recipes-kernel/bpftool/bpftool.bb
+++ b/meta-oe/recipes-kernel/bpftool/bpftool.bb
@@ -2,7 +2,7 @@  SUMMARY = "Inspect and manipulate eBPF programs and maps"
 DESCRIPTION = "bpftool is a kernel tool for inspection and simple manipulation \
 of eBPF programs and maps."
 LICENSE = "GPL-2.0-only"
-DEPENDS = "binutils elfutils"
+DEPENDS = "binutils elfutils elfutils-native"
 PROVIDES = "virtual/bpftool"
 
 inherit bash-completion kernelsrc kernel-arch
@@ -15,6 +15,7 @@  EXTRA_OEMAKE = "\
     O=${B} \
     CROSS=${TARGET_PREFIX} \
     CC="${CC} ${DEBUG_PREFIX_MAP} -fdebug-prefix-map=${STAGING_KERNEL_DIR}=${KERNEL_SRC_PATH}" \
+    HOSTCC="${BUILD_CC} ${BUILD_CFLAGS}" \
     LD="${LD}" \
     AR=${AR} \
     ARCH=${ARCH} \