diff mbox series

abseil-cpp: readd use of -std=c++14

Message ID 20240109124350.206419-1-throos@amazon.de
State New
Headers show
Series abseil-cpp: readd use of -std=c++14 | expand

Commit Message

Roos, Thomas Jan. 9, 2024, 12:43 p.m. UTC 
From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Petr Chernikov Jan. 9, 2024, 1:14 p.m. UTC | #1 
Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Thomas Roos <throos@amazon.de>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake

 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
--
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094
Petr Chernikov Jan. 9, 2024, 1:24 p.m. UTC | #2 
Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Thomas Roos <throos@amazon.de>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake

 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
--
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094
Petr Chernikov Jan. 9, 2024, 1:26 p.m. UTC | #3 
Sorry, typo, on the master branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:24 PM
To: Petr Chernikov <p.chernikov@yadro.com>; throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Thomas Roos <throos@amazon.de>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake

 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
--
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@  ASNEEDED:class-nativesdk = ""
 inherit cmake
 
 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "