diff mbox series

[meta-oe] driverctl: fix installed-vs-shipped

Message ID 20231229104005.1133493-1-martin.jansa@gmail.com
State Accepted
Headers show
Series [meta-oe] driverctl: fix installed-vs-shipped | expand

Commit Message

Martin Jansa Dec. 29, 2023, 10:40 a.m. UTC
* introduced in upgrade to 0.115 version:
  https://git.openembedded.org/meta-openembedded/commit/?id=1f2c2ebcbcf5944225462f530e0d56b20f1b4630

* fixes:
ERROR: driverctl-0.115-r0 do_package: QA Issue: driverctl: Files/directories were installed but not shipped in any package:
  /usr/lib/systemd
  /usr/lib/systemd/system
  /usr/lib/systemd/system/driverctl@.service
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
driverctl: 3 installed and not shipped files. [installed-vs-shipped]

  when systemd_system_unitdir isn't subdirectory of libdir, e.g. with multilib using:
  export libdir="/usr/lib64"
  export systemd_system_unitdir="/usr/lib/systemd/system"

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
---
 meta-oe/recipes-support/driverctl/driverctl_0.115.bb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Khem Raj Dec. 31, 2023, 12:38 a.m. UTC | #1
On Fri, 29 Dec 2023 11:40:05 +0100, Martin Jansa wrote:
> * introduced in upgrade to 0.115 version:
>   https://git.openembedded.org/meta-openembedded/commit/?id=1f2c2ebcbcf5944225462f530e0d56b20f1b4630
> 
> * fixes:
> ERROR: driverctl-0.115-r0 do_package: QA Issue: driverctl: Files/directories were installed but not shipped in any package:
>   /usr/lib/systemd
>   /usr/lib/systemd/system
>   /usr/lib/systemd/system/driverctl@.service
> Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> driverctl: 3 installed and not shipped files. [installed-vs-shipped]
> 
> [...]

Applied, thanks!

[1/1] driverctl: fix installed-vs-shipped
      commit: 079cd908fcaad88440f293a13e4917e4e64c42b5

Best regards,
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/driverctl/driverctl_0.115.bb b/meta-oe/recipes-support/driverctl/driverctl_0.115.bb
index d37563eda9..970844f982 100644
--- a/meta-oe/recipes-support/driverctl/driverctl_0.115.bb
+++ b/meta-oe/recipes-support/driverctl/driverctl_0.115.bb
@@ -18,6 +18,9 @@  do_install () {
 	oe_runmake install DESTDIR=${D}
 }
 
-FILES:${PN} += "${libdir}"
-FILES:${PN} += "${datadir}"
+FILES:${PN} += " \
+    ${libdir} \
+    ${datadir} \
+    ${systemd_system_unitdir} \
+"