diff mbox series

[meta-oe,2/2] meta-oe/dynamic-layers: add one more missing Upstream-Status and fix one malformed

Message ID 20230929140215.522222-2-martin.jansa@gmail.com
State Under Review
Headers show
Series [meta-oe,1/2] meta-oe/dynamic-layers: add Upstream-Status where missing | expand

Commit Message

Martin Jansa Sept. 29, 2023, 2:02 p.m. UTC
* even openembedded-core/scripts/yocto-check-layer didn't spot missing Upstream-Status in:
  /OE/layers/meta-openembedded/meta-oe/dynamic-layers/gnome-layer/recipes-graphics/openbox/openbox-xdgmenu/7_6.diff

  nor

  Malformed Upstream-Status 'Malformed Upstream-Status in patch
  /OE/layers/meta-openembedded/meta-oe/dynamic-layers/meta-python/recipes-connectivity/lirc/lirc/0001-Unbolt-ubuntu-hack.patch
  Please correct according to https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status :
  Upstream-Status: Inappropriates [ Cross-compile specific ]' (/OE/layers/meta-openembedded/meta-oe/dynamic-layers/meta-python/recipes-connectivity/lirc/lirc/0001-Unbolt-ubuntu-hack.patch)
  Unknown Upstream-Status value 'inappropriates' (/OE/layers/meta-openembedded/meta-oe/dynamic-layers/meta-python/recipes-connectivity/lirc/lirc/0001-Unbolt-ubuntu-hack.patch)

  those were caught by patchreview.py again, but executed on dynamic-layers/* as:
  openembedded-core# for l in /OE/layers/meta-openembedded/meta-oe/dynamic-layers/*; do ./scripts/contrib/patchreview.py -v $l > $l.qa-patches; done

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
---
 .../recipes-graphics/openbox/openbox-xdgmenu/7_6.diff           | 2 ++
 .../lirc/lirc/0001-Unbolt-ubuntu-hack.patch                     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/meta-oe/dynamic-layers/gnome-layer/recipes-graphics/openbox/openbox-xdgmenu/7_6.diff b/meta-oe/dynamic-layers/gnome-layer/recipes-graphics/openbox/openbox-xdgmenu/7_6.diff
index 8ab5386dc1..cdb29f24dc 100644
--- a/meta-oe/dynamic-layers/gnome-layer/recipes-graphics/openbox/openbox-xdgmenu/7_6.diff
+++ b/meta-oe/dynamic-layers/gnome-layer/recipes-graphics/openbox/openbox-xdgmenu/7_6.diff
@@ -1,3 +1,5 @@ 
+Upstream-Status: Pending
+
 === modified file 'openbox-xdgmenu.c'
 --- openbox-xdgmenu.c	2011-09-03 20:13:39 +0000
 +++ openbox-xdgmenu.c	2013-12-28 17:41:04 +0000
diff --git a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/lirc/lirc/0001-Unbolt-ubuntu-hack.patch b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/lirc/lirc/0001-Unbolt-ubuntu-hack.patch
index e58a93b6f6..73bacc9139 100644
--- a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/lirc/lirc/0001-Unbolt-ubuntu-hack.patch
+++ b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/lirc/lirc/0001-Unbolt-ubuntu-hack.patch
@@ -7,7 +7,7 @@  This bites during cross compiling where the target is different than
 build host and build host might be ubuntu but that does not matter in
 cross compilation case. This fails builds when usrmerge feature is used
 
-Upstream-Status: Inappropriates [ Cross-compile specific ]
+Upstream-Status: Inappropriate [ Cross-compile specific ]
 Signed-off-by: Khem Raj <raj.khem@gmail.com>
 ---
  configure.ac | 2 +-