diff mbox series

[meta-oe] libusbgx: usbgx.service: use Type=oneshot

Message ID 20230814084103.10932-1-liu.ming50@gmail.com
State Under Review
Headers show
Series [meta-oe] libusbgx: usbgx.service: use Type=oneshot | expand

Commit Message

Ming Liu Aug. 14, 2023, 8:41 a.m. UTC 
From: Ming Liu <liu.ming50@gmail.com>

A regression was introduced by commit:
```
commit 48bc4b2d5e4688bac10bcca26657a5fe660b93ab
Author: Ming Liu <liu.ming50@gmail.com>
Date:   Tue May 9 13:36:20 2023 +0200

    libusbgx: fix some systemd service conditions

    Let usbgx.service require and run after sys-kernel-config.mount.

    Use "Type=simple" rather than "Type=oneshot", this ensures
    usbgx.service would not hang on failures, failures could happen in
    many conditions, like if the end user has manually configured
    something in configfs, or start usbgx.service twice, or someting
    wrong in /etc/default/usbgx or /etc/usbgx/*.schema.

    Signed-off-by: Ming Liu <liu.ming50@gmail.com>
    Signed-off-by: Khem Raj <raj.khem@gmail.com>
```

In the case when 'Type=simple' is set, 'ExecStartPost=' will execute
right after the process in 'ExecStart=' is started, but we need it
execute after the last 'ExecStart=' process exited successfully, so
change back to "Type=oneshot".

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service b/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service
index ba92f1ab8..d7d394cfe 100644
--- a/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service
+++ b/meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service
@@ -4,7 +4,7 @@  Requires=sys-kernel-config.mount
 After=sys-kernel-config.mount
 
 [Service]
-Type=simple
+Type=oneshot
 ExecStart=/usr/bin/gadget-start
 
 [Install]