| Message ID | 20230712011122.105264-1-marex@denx.de |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe,1/2] libiio: update to version 0.25 | expand |
On Tue, Jul 11, 2023 at 6:11 PM Marek Vasut <marex@denx.de> wrote: > > The version 0.25 has been released, it has not been tagged however. > Update the this version anyway. hmm how do we know where to peg SRCREV ? I wonder if we should wait for tag to appear. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Christian Eggers <ceggers@arri.de> > Cc: Khem Raj <raj.khem@gmail.com> > Cc: Martin Siegumfeldt <mns@gomspace.com> > --- > meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-oe/recipes-support/libiio/libiio_git.bb b/meta-oe/recipes-support/libiio/libiio_git.bb > index ea51c19f4..b89ae29ea 100644 > --- a/meta-oe/recipes-support/libiio/libiio_git.bb > +++ b/meta-oe/recipes-support/libiio/libiio_git.bb > @@ -4,8 +4,8 @@ SECTION = "libs" > LICENSE = "LGPL-2.1-or-later" > LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c" > > -SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5" > -PV = "0.24" > +SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7" > +PV = "0.25" > > SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master" > UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)" > -- > 2.40.1 >
On Tue, Jul 11, 2023 at 6:11 PM Marek Vasut <marex@denx.de> wrote: > > The version 0.25 has been released, it has not been tagged however. > Update the this version anyway. hmm how do we know where to peg SRCREV ? I wonder if we should wait for tag to appear. I agree in waiting for tag to be published. Also, would it make sense to rename the recipe file according to the actual version rather than 'git'? In the past I think the recipe referred arbitrary git commits, however we have moved to referring actual release commits now. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Christian Eggers <ceggers@arri.de> > Cc: Khem Raj <raj.khem@gmail.com> > Cc: Martin Siegumfeldt <mns@gomspace.com> > --- > meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-oe/recipes-support/libiio/libiio_git.bb b/meta-oe/recipes-support/libiio/libiio_git.bb > index ea51c19f4..b89ae29ea 100644 > --- a/meta-oe/recipes-support/libiio/libiio_git.bb > +++ b/meta-oe/recipes-support/libiio/libiio_git.bb > @@ -4,8 +4,8 @@ SECTION = "libs" > LICENSE = "LGPL-2.1-or-later" > LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c" > > -SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5" > -PV = "0.24" > +SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7" > +PV = "0.25" > > SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master" > UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)" > -- > 2.40.1 > ________________________ This email was scanned by Bitdefender
On 7/12/23 08:40, Martin Siegumfeldt wrote: > On Tue, Jul 11, 2023 at 6:11 PM Marek Vasut <marex@denx.de> wrote: >> >> The version 0.25 has been released, it has not been tagged however. >> Update the this version anyway. > > hmm how do we know where to peg SRCREV ? I wonder if we should wait > for tag to appear. The 0.24 appeared on matching commit "CMake: Bump version to v0.24" Same for 0.23, 0.22, 0.21. 0.20 was not tagged like this 0.25. 0.19 was tagged again etc. I think it is safe to assume the tag was just missed or not pushed, but I planned to ping Paul about it. Might as well add Paul to CC help and ask that way. Paul, is the libiio 0.25 tag just missing ? > I agree in waiting for tag to be published. See above. > Also, would it make sense to rename the recipe file according to the actual version rather than 'git'? In the past I think the recipe referred arbitrary git commits, however we have moved to referring actual release commits now. Yes, good point, but that's a separate patch. I made a local commit so it isn't forgotten.
On 7/12/23 09:35, Paul Cercueil wrote: > Hi, > > Le mercredi 12 juillet 2023 à 09:25 +0200, Marek Vasut a écrit : >> On 7/12/23 08:40, Martin Siegumfeldt wrote: >>> On Tue, Jul 11, 2023 at 6:11 PM Marek Vasut <marex@denx.de> wrote: >>>> >>>> The version 0.25 has been released, it has not been tagged >>>> however. >>>> Update the this version anyway. >>> >>> hmm how do we know where to peg SRCREV ? I wonder if we should wait >>> for tag to appear. >> >> The 0.24 appeared on matching commit >> "CMake: Bump version to v0.24" >> Same for 0.23, 0.22, 0.21. 0.20 was not tagged like this 0.25. 0.19 >> was >> tagged again etc. >> >> I think it is safe to assume the tag was just missed or not pushed, >> but >> I planned to ping Paul about it. Might as well add Paul to CC help >> and >> ask that way. >> >> Paul, is the libiio 0.25 tag just missing ? >> >>> I agree in waiting for tag to be published. > > Yes, please wait for the tag. The commit that bumps the version number > in the CMake script is not necesarily the top commit at each release. Then we wait, thanks!
On Tue, Jul 11, 2023 at 11:40 PM Martin Siegumfeldt <mns@gomspace.com> wrote: > > On Tue, Jul 11, 2023 at 6:11 PM Marek Vasut <marex@denx.de> wrote: > > > > The version 0.25 has been released, it has not been tagged however. > > Update the this version anyway. > > hmm how do we know where to peg SRCREV ? I wonder if we should wait > for tag to appear. > > I agree in waiting for tag to be published. > > Also, would it make sense to rename the recipe file according to the actual version rather than 'git'? In the past I think the recipe referred arbitrary git commits, however we have moved to referring actual release commits now. Yes it is preferred that PV is moved to recipe name in such cases. > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > --- > > Cc: Christian Eggers <ceggers@arri.de> > > Cc: Khem Raj <raj.khem@gmail.com> > > Cc: Martin Siegumfeldt <mns@gomspace.com> > > --- > > meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meta-oe/recipes-support/libiio/libiio_git.bb b/meta-oe/recipes-support/libiio/libiio_git.bb > > index ea51c19f4..b89ae29ea 100644 > > --- a/meta-oe/recipes-support/libiio/libiio_git.bb > > +++ b/meta-oe/recipes-support/libiio/libiio_git.bb > > @@ -4,8 +4,8 @@ SECTION = "libs" > > LICENSE = "LGPL-2.1-or-later" > > LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c" > > > > -SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5" > > -PV = "0.24" > > +SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7" > > +PV = "0.25" > > > > SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master" > > UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)" > > -- > > 2.40.1 > > > > ________________________ > This email was scanned by Bitdefender >
diff --git a/meta-oe/recipes-support/libiio/libiio_git.bb b/meta-oe/recipes-support/libiio/libiio_git.bb index ea51c19f4..b89ae29ea 100644 --- a/meta-oe/recipes-support/libiio/libiio_git.bb +++ b/meta-oe/recipes-support/libiio/libiio_git.bb @@ -4,8 +4,8 @@ SECTION = "libs" LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c" -SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5" -PV = "0.24" +SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7" +PV = "0.25" SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master" UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
The version 0.25 has been released, it has not been tagged however. Update the this version anyway. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Christian Eggers <ceggers@arri.de> Cc: Khem Raj <raj.khem@gmail.com> Cc: Martin Siegumfeldt <mns@gomspace.com> --- meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)