diff mbox series

[meta-java,3/3] rxtx: Remove obsolete rename of libtool

Message ID 20230609144646.1977-3-jermain.horsman@nedap.com
State New
Headers show
Series [meta-java,1/3] javasqlite: Revert changes to LIC_FILES_CHKSUM | expand

Commit Message

jhatnedap@gmail.com June 9, 2023, 2:46 p.m. UTC
From: Jermain Horsman <jermain.horsman@nedap.com>

Autoconf no longer generates libtool with a host alias prefix,
this causes do_compile to fail as it is unable to find libtool
without the prefix.

Since the rename is no longer needed the edit in the do_configure
step can be removed.

Signed-off-by: Jermain Horsman <jermain.horsman@nedap.com>
---
 recipes-extended/rxtx/rxtx_2.2.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Orling March 23, 2024, 11:14 p.m. UTC | #1
Still seeing a do_compile failure (attached)

Can you investigate and send a revised solution?

On Fri, Jun 9, 2023 at 7:48 AM Jermain Horsman <jermain.horsman@nedap.com>
wrote:

> From: Jermain Horsman <jermain.horsman@nedap.com>
>
> Autoconf no longer generates libtool with a host alias prefix,
> this causes do_compile to fail as it is unable to find libtool
> without the prefix.
>
> Since the rename is no longer needed the edit in the do_configure
> step can be removed.
>
> Signed-off-by: Jermain Horsman <jermain.horsman@nedap.com>
> ---
>  recipes-extended/rxtx/rxtx_2.2.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/rxtx/rxtx_2.2.0.bb b/recipes-extended/rxtx/
> rxtx_2.2.0.bb
> index 27935bc..a74f11e 100644
> --- a/recipes-extended/rxtx/rxtx_2.2.0.bb
> +++ b/recipes-extended/rxtx/rxtx_2.2.0.bb
> @@ -40,7 +40,7 @@ do_configure:prepend() {
>      # Ugly but don't complain to me, but upstream ;-)
>      sed -e 's,bin/javah,bin/gjavah,g' \
>          -e 's,bin/jar,bin/fastjar,g' \
> -        -e 's,\$(TOP)/libtool,\$(TOP)/\${host_alias}-libtool,g' -i ${S}/
> configure.in
> +        -i ${S}/configure.in
>      rm -f ${S}/acinclude.m4 \
>            ${S}/aclocal.m4 \
>            ${S}/ltconfig \
> --
> 2.39.2.windows.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#103203):
> https://lists.openembedded.org/g/openembedded-devel/message/103203
> Mute This Topic: https://lists.openembedded.org/mt/99429856/924729
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Jermain Horsman March 25, 2024, 10:40 a.m. UTC | #2
> Still seeing a do_compile failure (attached)

I believe this is caused by sstate being incorrect,
If you do a clean build this should not happen.

> Can you investigate and send a revised solution?

I could increase the PR, I believe that should prevent the issue.
Would that be acceptable?

Sincerely,

Jermain Horsman
Tim Orling March 25, 2024, 3:57 p.m. UTC | #3
On Mon, Mar 25, 2024 at 3:40 AM Jermain Horsman <jermain.horsman@nedap.com>
wrote:

> > Still seeing a do_compile failure (attached)
>
> I believe this is caused by sstate being incorrect,
> If you do a clean build this should not happen.
>
> > Can you investigate and send a revised solution?
>
> I could increase the PR, I believe that should prevent the issue.
> Would that be acceptable?


Ah. Good points/ideas. Let me test that after my current build/test run
completes.

I’ll just add the PR bump to this commit.


>
> Sincerely,
>
> Jermain Horsman
>
diff mbox series

Patch

diff --git a/recipes-extended/rxtx/rxtx_2.2.0.bb b/recipes-extended/rxtx/rxtx_2.2.0.bb
index 27935bc..a74f11e 100644
--- a/recipes-extended/rxtx/rxtx_2.2.0.bb
+++ b/recipes-extended/rxtx/rxtx_2.2.0.bb
@@ -40,7 +40,7 @@  do_configure:prepend() {
     # Ugly but don't complain to me, but upstream ;-)
     sed -e 's,bin/javah,bin/gjavah,g' \
         -e 's,bin/jar,bin/fastjar,g' \
-        -e 's,\$(TOP)/libtool,\$(TOP)/\${host_alias}-libtool,g' -i ${S}/configure.in
+        -i ${S}/configure.in
     rm -f ${S}/acinclude.m4 \
           ${S}/aclocal.m4 \
           ${S}/ltconfig \