diff mbox series

[meta-oe] lmsensors: do not pull in unneeded perl modules for run-time dependencies

Message ID 20230608103731.103220-1-beniaminsandu@gmail.com
State Under Review
Headers show
Series [meta-oe] lmsensors: do not pull in unneeded perl modules for run-time dependencies | expand

Commit Message

Beniamin Sandu June 8, 2023, 10:37 a.m. UTC
Signed-off-by: Beniamin Sandu <beniaminsandu@gmail.com>
---
 meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Randy MacLeod June 14, 2023, 6:52 p.m. UTC | #1
On 2023-06-08 06:37, Beniamin Sandu via lists.openembedded.org wrote:
> Signed-off-by: Beniamin Sandu<beniaminsandu@gmail.com>
> ---
>   meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> index f821cdaf4..aba5ab587 100644
> --- a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> +++ b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
> @@ -151,12 +151,13 @@ RRECOMMENDS:${PN}-fancontrol = "lmsensors-config-fancontrol"
>   # sensors-detect script files
>   FILES:${PN}-sensorsdetect = "${sbindir}/sensors-detect"
>   FILES:${PN}-sensorsdetect-doc = "${mandir}/man8/sensors-detect.8"
> -RDEPENDS:${PN}-sensorsdetect = "${PN}-sensors perl perl-modules"
> +RDEPENDS:${PN}-sensorsdetect = "${PN}-sensors perl perl-module-fcntl perl-module-file-basename \
> +	perl-module-strict perl-module-constant"
>   
>   # sensors-conf-convert script files
>   FILES:${PN}-sensorsconfconvert = "${bindir}/sensors-conf-convert"
>   FILES:${PN}-sensorsconfconvert-doc = "${mandir}/man8/sensors-conf-convert.8"
> -RDEPENDS:${PN}-sensorsconfconvert = "${PN}-sensors perl perl-modules"
> +RDEPENDS:${PN}-sensorsconfconvert = "${PN}-sensors perl perl-module-strict perl-module-vars"
>   
>   # pwmconfig script files
>   FILES:${PN}-pwmconfig = "${sbindir}/pwmconfig"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#103185):https://lists.openembedded.org/g/openembedded-devel/message/103185
> Mute This Topic:https://lists.openembedded.org/mt/99403887/3616765
> Group Owner:openembedded-devel+owner@lists.openembedded.org
> Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub  [randy.macleod@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
The original RDEPENDS on the full set of perl-modules was from:
    c00f3c285 lmsensors: Initial commit
back in 2012!

Armin,

Would it make sense to backport this change that saves quite a bit of 
space in images to
mickledore and kirkstone and maybe even dunfell?


$ git cherry-pick c07fe3639a48602c7ed79e5b96b5f732c537e858

works cleanly for mickledore and kirkstone but not dunfell so

can you pull them into mickledore and kirkstone  or do you want someone 
to send a commit?
diff mbox series

Patch

diff --git a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
index f821cdaf4..aba5ab587 100644
--- a/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
+++ b/meta-oe/recipes-bsp/lm_sensors/lmsensors_3.6.0.bb
@@ -151,12 +151,13 @@  RRECOMMENDS:${PN}-fancontrol = "lmsensors-config-fancontrol"
 # sensors-detect script files
 FILES:${PN}-sensorsdetect = "${sbindir}/sensors-detect"
 FILES:${PN}-sensorsdetect-doc = "${mandir}/man8/sensors-detect.8"
-RDEPENDS:${PN}-sensorsdetect = "${PN}-sensors perl perl-modules"
+RDEPENDS:${PN}-sensorsdetect = "${PN}-sensors perl perl-module-fcntl perl-module-file-basename \
+	perl-module-strict perl-module-constant"
 
 # sensors-conf-convert script files
 FILES:${PN}-sensorsconfconvert = "${bindir}/sensors-conf-convert"
 FILES:${PN}-sensorsconfconvert-doc = "${mandir}/man8/sensors-conf-convert.8"
-RDEPENDS:${PN}-sensorsconfconvert = "${PN}-sensors perl perl-modules"
+RDEPENDS:${PN}-sensorsconfconvert = "${PN}-sensors perl perl-module-strict perl-module-vars"
 
 # pwmconfig script files
 FILES:${PN}-pwmconfig = "${sbindir}/pwmconfig"