| Message ID | 20230518101233.3885135-1-Martin.Jansa@gmail.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe] networkmanager: enable vala only with GI_DATA_ENABLED | expand |
On Thu, May 18, 2023 at 3:12 AM Martin Jansa <Martin.Jansa@gmail.com> wrote: > > * cannot be enabled without: > http://errors.yoctoproject.org/Errors/Details/704353/ > NetworkManager-1.42.6/meson.build:816:4: ERROR: Assert failed: vala api require GObject introspection. Use -Dvapi=false to disable it > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > --- > .../networkmanager/networkmanager_1.42.6.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb > index 31687a30b9..2412775cf1 100644 > --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb > +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb > @@ -70,11 +70,12 @@ do_compile:prepend() { > export GI_TYPELIB_PATH="${B}}/src/libnm-client-impl${GI_TYPELIB_PATH:+:$GI_TYPELIB_PATH}" > } > > -PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli vala \ > +PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli \ > ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d), d)} \ > ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ > ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit', d)} \ > ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit', '', d)} \ > + ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'vala', '', d)} \ > " I think vala support should be added via inheriting vala class. The problem is still there when GI_DATA_ENABLED is True. > > inherit ${@bb.utils.contains('PACKAGECONFIG', 'vala', 'vala', '', d)} > -- > 2.40.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#102657): https://lists.openembedded.org/g/openembedded-devel/message/102657 > Mute This Topic: https://lists.openembedded.org/mt/98988017/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
The vala inherit is conditional on vala PACKAGECONFIG, so it seems to work fine. On Thu, May 18, 2023 at 7:58 PM Khem Raj <raj.khem@gmail.com> wrote: > On Thu, May 18, 2023 at 3:12 AM Martin Jansa <Martin.Jansa@gmail.com> > wrote: > > > > * cannot be enabled without: > > http://errors.yoctoproject.org/Errors/Details/704353/ > > NetworkManager-1.42.6/meson.build:816:4: ERROR: Assert failed: vala > api require GObject introspection. Use -Dvapi=false to disable it > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > > --- > > .../networkmanager/networkmanager_1.42.6.bb | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/meta-networking/recipes-connectivity/networkmanager/ > networkmanager_1.42.6.bb > b/meta-networking/recipes-connectivity/networkmanager/ > networkmanager_1.42.6.bb > > index 31687a30b9..2412775cf1 100644 > > --- a/meta-networking/recipes-connectivity/networkmanager/ > networkmanager_1.42.6.bb > > +++ b/meta-networking/recipes-connectivity/networkmanager/ > networkmanager_1.42.6.bb > > @@ -70,11 +70,12 @@ do_compile:prepend() { > > export > GI_TYPELIB_PATH="${B}}/src/libnm-client-impl${GI_TYPELIB_PATH:+:$GI_TYPELIB_PATH}" > > } > > > > -PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli vala \ > > +PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli \ > > ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', > bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d), d)} \ > > ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', > d)} \ > > ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit', d)} \ > > ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit', > '', d)} \ > > + ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'vala', '', d)} \ > > " > > I think vala support should be added via inheriting vala class. The > problem is still there when GI_DATA_ENABLED > is True. > > > > > inherit ${@bb.utils.contains('PACKAGECONFIG', 'vala', 'vala', '', d)} > > -- > > 2.40.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#102657): > https://lists.openembedded.org/g/openembedded-devel/message/102657 > > Mute This Topic: https://lists.openembedded.org/mt/98988017/1997914 > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > raj.khem@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > >
On Thu, May 18, 2023 at 11:09 AM Martin Jansa <martin.jansa@gmail.com> wrote: > > The vala inherit is conditional on vala PACKAGECONFIG, so it seems to work fine. > > On Thu, May 18, 2023 at 7:58 PM Khem Raj <raj.khem@gmail.com> wrote: >> >> On Thu, May 18, 2023 at 3:12 AM Martin Jansa <Martin.Jansa@gmail.com> wrote: >> > >> > * cannot be enabled without: >> > http://errors.yoctoproject.org/Errors/Details/704353/ >> > NetworkManager-1.42.6/meson.build:816:4: ERROR: Assert failed: vala api require GObject introspection. Use -Dvapi=false to disable it >> > >> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> >> > --- >> > .../networkmanager/networkmanager_1.42.6.bb | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb >> > index 31687a30b9..2412775cf1 100644 >> > --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb >> > +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb >> > @@ -70,11 +70,12 @@ do_compile:prepend() { >> > export GI_TYPELIB_PATH="${B}}/src/libnm-client-impl${GI_TYPELIB_PATH:+:$GI_TYPELIB_PATH}" >> > } >> > >> > -PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli vala \ >> > +PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli \ >> > ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d), d)} \ >> > ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ >> > ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit', d)} \ >> > ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit', '', d)} \ >> > + ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'vala', '', d)} \ >> > " >> >> I think vala support should be added via inheriting vala class. The >> problem is still there when GI_DATA_ENABLED >> is True. >> >> > >> > inherit ${@bb.utils.contains('PACKAGECONFIG', 'vala', 'vala', '', d)} Its not working in my workspace and ends with error you were seeing without this change. >> > -- >> > 2.40.1 >> > >> > >> > -=-=-=-=-=-=-=-=-=-=-=- >> > Links: You receive all messages sent to this group. >> > View/Reply Online (#102657): https://lists.openembedded.org/g/openembedded-devel/message/102657 >> > Mute This Topic: https://lists.openembedded.org/mt/98988017/1997914 >> > Group Owner: openembedded-devel+owner@lists.openembedded.org >> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] >> > -=-=-=-=-=-=-=-=-=-=-=- >> >
On Thu, May 18, 2023 at 11:20 AM Khem Raj <raj.khem@gmail.com> wrote: > > On Thu, May 18, 2023 at 11:09 AM Martin Jansa <martin.jansa@gmail.com> wrote: > > > > The vala inherit is conditional on vala PACKAGECONFIG, so it seems to work fine. > > > > On Thu, May 18, 2023 at 7:58 PM Khem Raj <raj.khem@gmail.com> wrote: > >> > >> On Thu, May 18, 2023 at 3:12 AM Martin Jansa <Martin.Jansa@gmail.com> wrote: > >> > > >> > * cannot be enabled without: > >> > http://errors.yoctoproject.org/Errors/Details/704353/ > >> > NetworkManager-1.42.6/meson.build:816:4: ERROR: Assert failed: vala api require GObject introspection. Use -Dvapi=false to disable it > >> > > >> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > >> > --- > >> > .../networkmanager/networkmanager_1.42.6.bb | 3 ++- > >> > 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > >> > diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb > >> > index 31687a30b9..2412775cf1 100644 > >> > --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb > >> > +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb > >> > @@ -70,11 +70,12 @@ do_compile:prepend() { > >> > export GI_TYPELIB_PATH="${B}}/src/libnm-client-impl${GI_TYPELIB_PATH:+:$GI_TYPELIB_PATH}" > >> > } > >> > > >> > -PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli vala \ > >> > +PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli \ > >> > ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d), d)} \ > >> > ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ > >> > ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit', d)} \ > >> > ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit', '', d)} \ > >> > + ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'vala', '', d)} \ > >> > " > >> > >> I think vala support should be added via inheriting vala class. The > >> problem is still there when GI_DATA_ENABLED > >> is True. > >> > >> > > >> > inherit ${@bb.utils.contains('PACKAGECONFIG', 'vala', 'vala', '', d)} > > Its not working in my workspace and ends with error you were seeing > without this change. I am building with abelloni/master-next from poky-contrib btw. which has the g-i rework changes. > > >> > -- > >> > 2.40.1 > >> > > >> > > >> > -=-=-=-=-=-=-=-=-=-=-=- > >> > Links: You receive all messages sent to this group. > >> > View/Reply Online (#102657): https://lists.openembedded.org/g/openembedded-devel/message/102657 > >> > Mute This Topic: https://lists.openembedded.org/mt/98988017/1997914 > >> > Group Owner: openembedded-devel+owner@lists.openembedded.org > >> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > >> > -=-=-=-=-=-=-=-=-=-=-=- > >> >
diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb index 31687a30b9..2412775cf1 100644 --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.42.6.bb @@ -70,11 +70,12 @@ do_compile:prepend() { export GI_TYPELIB_PATH="${B}}/src/libnm-client-impl${GI_TYPELIB_PATH:+:$GI_TYPELIB_PATH}" } -PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli vala \ +PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli \ ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d), d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit', '', d)} \ + ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'vala', '', d)} \ " inherit ${@bb.utils.contains('PACKAGECONFIG', 'vala', 'vala', '', d)}
* cannot be enabled without: http://errors.yoctoproject.org/Errors/Details/704353/ NetworkManager-1.42.6/meson.build:816:4: ERROR: Assert failed: vala api require GObject introspection. Use -Dvapi=false to disable it Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> --- .../networkmanager/networkmanager_1.42.6.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)