Message ID | 20230509124612.37627-1-f_l_k@t-online.de |
---|---|
State | Under Review |
Headers | show |
Series | [meta-oe,1/2] paprefs: add recipe | expand |
On Tue, May 9, 2023 at 2:46 PM Markus Volk <f_l_k@t-online.de> wrote: > Signed-off-by: Markus Volk <f_l_k@t-online.de> > --- > .../pulseaudio/paprefs_1.2.bb | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb > > diff --git a/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb > b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb > new file mode 100644 > index 0000000000..6d0cf7ed7f > --- /dev/null > +++ b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb > @@ -0,0 +1,18 @@ > +DESCRIPTION = "PulseAudio Preferences (paprefs) is a simple GTK based > configuration dialog for the PulseAudio sound server." > +HOMEPAGE = "https://freedesktop.org/software/pulseaudio/paprefs/" > +LICENSE = "GPL-2.0-only" > +LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe" > + > +DEPENDS = "pulseaudio gtkmm3 gtk+3 libsigc++-3 glibmm" > + > +inherit meson pkgconfig features_check > + > +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}" > This doesn't build with any gtk3 DISTRO_FEATURES, without x11 in DISTRO_FEATURES gtk3+ doesn't provide gdkx.h and paprefs build fails with: http://errors.yoctoproject.org/Errors/Details/704195/ ../paprefs-1.2/src/paprefs.cc:30:10: fatal error: gdk/gdkx.h: No such file or directory 30 | #include <gdk/gdkx.h> | ^~~~~~~~~~~~ Please change it to REQUIRED_DISTRO_FEATURES = "x11" if you don't care about non-x11 usecase or fix otherwise if you do care. Regards,
In the end I've sent one as well: https://lists.openembedded.org/g/openembedded-devel/message/102602 both do the same, lets see which one is picked by Khem sooner. On Tue, May 16, 2023 at 6:39 AM Markus Volk <mrksvolk@googlemail.com> wrote: > Thanks for pointing me to this issue. I've sent a patch that adds > REQUIRED_DISTRO_FEATURES = "x11" > > Am Mo, 15. Mai 2023 um 10:13:41 +0200 schrieb Martin Jansa < > martin.jansa@gmail.com>: > > On Tue, May 9, 2023 at 2:46 PM Markus Volk <f_l_k@t-online.de> wrote: > >> Signed-off-by: Markus Volk <f_l_k@t-online.de> >> --- >> .../pulseaudio/paprefs_1.2.bb | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >> >> diff --git a/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >> b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >> new file mode 100644 >> index 0000000000..6d0cf7ed7f >> --- /dev/null >> +++ b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >> @@ -0,0 +1,18 @@ >> +DESCRIPTION = "PulseAudio Preferences (paprefs) is a simple GTK based >> configuration dialog for the PulseAudio sound server." >> +HOMEPAGE = "https://freedesktop.org/software/pulseaudio/paprefs/" >> +LICENSE = "GPL-2.0-only" >> +LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe" >> + >> +DEPENDS = "pulseaudio gtkmm3 gtk+3 libsigc++-3 glibmm" >> + >> +inherit meson pkgconfig features_check >> + >> +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}" >> > > This doesn't build with any gtk3 DISTRO_FEATURES, without x11 in > DISTRO_FEATURES gtk3+ doesn't provide gdkx.h and paprefs build fails with: > http://errors.yoctoproject.org/Errors/Details/704195/ > > ../paprefs-1.2/src/paprefs.cc:30:10: fatal error: gdk/gdkx.h: No such file > or directory > 30 | #include <gdk/gdkx.h> > | ^~~~~~~~~~~~ > > Please change it to REQUIRED_DISTRO_FEATURES = "x11" if you don't care > about non-x11 usecase or fix otherwise if you do care. > > Regards, > >
Thanks for this. Your patch has the far better commit message Am Di, 16. Mai 2023 um 08:21:13 +0200 schrieb Martin Jansa <Martin.Jansa@gmail.com>: > In the end I've sent one as well: > <https://lists.openembedded.org/g/openembedded-devel/message/102602> > both do the same, lets see which one is picked by Khem sooner. > > On Tue, May 16, 2023 at 6:39 AM Markus Volk > <mrksvolk@googlemail.com <mailto:mrksvolk@googlemail.com>> wrote: >> Thanks for pointing me to this issue. I've sent a patch that adds >> REQUIRED_DISTRO_FEATURES = "x11" >> >> Am Mo, 15. Mai 2023 um 10:13:41 +0200 schrieb Martin Jansa >> <martin.jansa@gmail.com <mailto:martin.jansa@gmail.com>>: >>> On Tue, May 9, 2023 at 2:46 PM Markus Volk <f_l_k@t-online.de >>> <mailto:f_l_k@t-online.de>> wrote: >>>> Signed-off-by: Markus Volk <f_l_k@t-online.de >>>> <mailto:f_l_k@t-online.de>> >>>> --- >>>> .../pulseaudio/paprefs_1.2.bb <http://paprefs_1.2.bb/> >>>> | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> create mode 100644 >>>> meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >>>> <http://paprefs_1.2.bb/> >>>> >>>> diff --git a/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >>>> <http://paprefs_1.2.bb/> >>>> b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >>>> <http://paprefs_1.2.bb/> >>>> new file mode 100644 >>>> index 0000000000..6d0cf7ed7f >>>> --- /dev/null >>>> +++ b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb >>>> <http://paprefs_1.2.bb/> >>>> @@ -0,0 +1,18 @@ >>>> +DESCRIPTION = "PulseAudio Preferences (paprefs) is a simple GTK >>>> based configuration dialog for the PulseAudio sound server." >>>> +HOMEPAGE = >>>> "<https://freedesktop.org/software/pulseaudio/paprefs/>" >>>> +LICENSE = "GPL-2.0-only" >>>> +LIC_FILES_CHKSUM = >>>> "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe" >>>> + >>>> +DEPENDS = "pulseaudio gtkmm3 gtk+3 libsigc++-3 glibmm" >>>> + >>>> +inherit meson pkgconfig features_check >>>> + >>>> +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}" >>> >>> This doesn't build with any gtk3 DISTRO_FEATURES, without x11 in >>> DISTRO_FEATURES gtk3+ doesn't provide gdkx.h and paprefs build >>> fails with: >>> <http://errors.yoctoproject.org/Errors/Details/704195/> >>> >>> ../paprefs-1.2/src/paprefs.cc:30:10: fatal error: gdk/gdkx.h: No >>> such file or directory >>> 30 | #include <gdk/gdkx.h> >>> | ^~~~~~~~~~~~ >>> >>> Please change it to REQUIRED_DISTRO_FEATURES = "x11" if you don't >>> care about non-x11 usecase or fix otherwise if you do care. >>> >>> Regards,
diff --git a/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb new file mode 100644 index 0000000000..6d0cf7ed7f --- /dev/null +++ b/meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb @@ -0,0 +1,18 @@ +DESCRIPTION = "PulseAudio Preferences (paprefs) is a simple GTK based configuration dialog for the PulseAudio sound server." +HOMEPAGE = "https://freedesktop.org/software/pulseaudio/paprefs/" +LICENSE = "GPL-2.0-only" +LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe" + +DEPENDS = "pulseaudio gtkmm3 gtk+3 libsigc++-3 glibmm" + +inherit meson pkgconfig features_check + +ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}" + +SRC_URI = "http://freedesktop.org/software/pulseaudio/paprefs/${BP}.tar.xz" + +SRC_URI[sha256sum] = "b3f21e40dc3936d15e3ffc910fb0c07c14b88e8c287715b456a948c17638f633" + +EXTRA_OEMESON = "-Dlynx=false" + +RDEPENDS:${PN} += "pulseaudio-server"
Signed-off-by: Markus Volk <f_l_k@t-online.de> --- .../pulseaudio/paprefs_1.2.bb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 meta-oe/recipes-multimedia/pulseaudio/paprefs_1.2.bb