diff mbox series

[meta-oe,v2,7/7] lvgl: Add dependency on fbdev into lvgl-demo-fb DISTRO_FEATURES

Message ID 20230509024355.79006-7-marex@denx.de
State Under Review
Headers show
Series [meta-oe,v2,1/7] lvgl: Upgrade lvgl to 8.3.7 and lv-driver to 8.3.0 | expand

Commit Message

Marek Vasut May 9, 2023, 2:43 a.m. UTC
This recipe hard depends on fbdev, since it specifically targets
systems using it. Add the DISTRO_FEATURES dependency to indicate
it.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@denx.de>
Cc: Khem Raj <raj.khem@gmail.com>
Cc: Martin Jansa <martin.jansa@gmail.com>
Cc: Philippe Coval <philippe.coval.ext@huawei.com>
Cc: Philippe Coval <philippe.coval@huawei.com>
---
V2: New patch
---
 meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Martin Jansa May 14, 2023, 8:26 p.m. UTC | #1
This is missing the features_check inherit causing:

ERROR: QA Issue: lvgl-demo-fb: recipe doesn't inherit features_check
[unhandled-features-check]

On Tue, May 9, 2023 at 4:44 AM Marek Vasut <marex@denx.de> wrote:

> This recipe hard depends on fbdev, since it specifically targets
> systems using it. Add the DISTRO_FEATURES dependency to indicate
> it.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Khem Raj <raj.khem@gmail.com>
> Cc: Martin Jansa <martin.jansa@gmail.com>
> Cc: Philippe Coval <philippe.coval.ext@huawei.com>
> Cc: Philippe Coval <philippe.coval@huawei.com>
> ---
> V2: New patch
> ---
>  meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb
> b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb
> index d86d6ff9c..8e0b91cac 100644
> --- a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb
> +++ b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb
> @@ -10,6 +10,8 @@ SRCREV = "adf2c4490e17a1b9ec1902cc412a24b3b8235c8e"
>
>  S = "${WORKDIR}/git"
>
> +REQUIRED_DISTRO_FEATURES = "fbdev"
> +
>  EXTRA_OEMAKE = "DESTDIR=${D}"
>
>  do_install() {
> --
> 2.39.2
>
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb
index d86d6ff9c..8e0b91cac 100644
--- a/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb
+++ b/meta-oe/recipes-graphics/lvgl/lvgl-demo-fb_8.3.0.bb
@@ -10,6 +10,8 @@  SRCREV = "adf2c4490e17a1b9ec1902cc412a24b3b8235c8e"
 
 S = "${WORKDIR}/git"
 
+REQUIRED_DISTRO_FEATURES = "fbdev"
+
 EXTRA_OEMAKE = "DESTDIR=${D}"
 
 do_install() {